Commit Graph
896 Commits
Author SHA1 Message Date
stathisandClaude Sonnet 5 f6d8725c96 fix(mail): add missing Greek language support for mail reply/forward
Replying to a message with Greek selected as the interface language
was broken: SOGoMailObject+Draft.m builds the reply page class name
dynamically as SOGoMail<Language>Reply and instantiates it via
pageWithName:, but no SOGoMailGreekReply class was ever declared in
SOGoMailReply.h/.m, even though the Greek.lproj translations and the
SOGoMailGreekReply.wo template already existed on disk.

Also add SOGoMailGreekForward.wo and SOGoMailGreekReply.wo to
Mailer_RESOURCE_FILES in the GNUmakefile. Without this, neither
template gets installed into the built bundle, so Greek mail
forwarding was silently broken too, despite the SOGoMailGreekForward
class already existing in code.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-11-19 09:25:36 +01:00
Alex J ee02866730 fix(mail): check buffer length before reading TNEF properties
Several places in the TNEF attachment decoder read a fixed number of
bytes, or index at a fixed offset, out of a MAPI property's data buffer
without checking the buffer is actually that large:

- the possibly-embedded-TNEF signature, read at offset 16 for an object
  property and at offset 0 for plain file data
- the same object-attachment data, when building the actual attachment
  content a few lines later: the length used there is derived from the
  same unchecked offset and underflows to a huge value for a short buffer
- the classification flag, read as an 8-byte value
- the recurrence pattern, indexed up to offset 0x23 but only checked for
  0x1F bytes

A short enough attachment property made these read, or in the attachment
case allocate, past the end of the buffer.

Add the missing length checks; where no further data is left to build
from, skip that part of the output instead.
2026-11-06 16:21:03 +01:00
Hivert Quentin 370a4a433c feat(acccount): Add read only account 2026-10-21 09:33:37 +02:00
Hivert Quentin 0b71116c95 fix(draft): check the name of the draft 2026-10-14 11:07:46 +02:00
Hadrien Blanc 20779cf353 fix(mail): sanitize the domain part of generated message-ids
generateMessageID: appended the substring following the last '@'
without sanitizing it, so a sender value such as 'Doe, John <a@b>'
produced 'Message-Id: <uuid@b>>' with a duplicated closing bracket on
calendar invitations. A nil domain also left the message-id
unterminated.

The domain part is now cut at the first address delimiter or
whitespace - a domain is a single token, and anything else would
allow header injection through generated message-ids.

Fixes #6201
2026-10-07 11:13:33 +02:00
Hivert Quentin 1caa25711f fix(bug): incorrect method called 2026-08-11 17:06:27 +02:00
smizrahi f11f34cdef fix(mail): escape References/Organization/Newsgroups headers in HTML forward so message-id chevrons aren't parsed as HTML tags hiding the quoted body. Closes #6046. 2026-06-04 11:53:58 +02:00
Hivert Quentin 1fdb4d3026 i18n(pt): Add Greek (partial) 2026-03-02 15:01:52 +01:00
Hivert Quentin a7f7950d91 fix(eas): use proper imap mech for EAS request when using openid 2025-09-19 16:47:16 +02:00
Hivert Quentin 7bee193413 fix(mail): preoperly generates the message-id header value 2025-07-28 17:40:14 +02:00
Hivert Quentin f5f8f112cd chore(language): Add Thai language 2025-07-03 16:59:56 +02:00
Hivert Quentin 08bc6aff3f chore(language): Add Korean language 2025-07-03 09:35:50 +02:00
Hivert Quentin 7c6b6743e0 fix(tnef): add protection against malformed winmail.dat 2025-03-26 16:22:12 +01:00
Hivert Quentin 4c09ebfb6e i18n(ja): Update Japanese translations 2025-03-24 09:57:06 +01:00
Hivert Quentin c3234882eb feat(openID): second part with a lot of fixes and cleaning 2025-03-13 15:25:56 +01:00
Hivert Quentin 458d39d48a feat(openID): first stable version 2025-03-13 15:24:03 +01:00
smizrahi 0a828a739e fix(mail): Fix assertion when failed to decode base64 mime body mail part 2024-12-18 10:39:27 +01:00
smizrahi 6f86506b28 feat(mail): Deletion of mail older than x. Closes #6023. 2024-11-20 16:50:15 +01:00
smizrahi 617c1bbc64 fix(mail): Correct attachment handling when creating emails from templates 2024-11-06 16:48:39 +01:00
smizrahi b3c77a0e00 fix(mail): Add 'Return-Receipt-To' header for mail receipt 2024-10-16 09:44:53 +02:00
Hivert Quentin 41aecca692 i18n(tr_TR): Update TurkishTurkey translations 2024-10-08 11:59:46 +02:00
Hivert Quentin 68f4fc1343 fix(mail): improve algo to fetch imap folders for mail view 2024-09-11 09:05:53 +02:00
Hivert Quentin 6e11cdf289 i18n(es_ES): Update SpanishSpain translations 2024-08-07 10:49:40 +02:00
smizrahi 99da6e0f81 fix(mail): Update len value as data is modified in loop. This fixes the issue on sanitizedContentUsingVoidTags whenthere are meta html tags in mail content. 2024-07-19 13:31:20 +02:00
smizrahi ef88039a4a fix(mail): Fix invalid content when forwarding a text/plain mail. Fixes #5983. 2024-07-11 17:41:14 +02:00
smizrahi 43388ac42c fix(mail): Fix invalid content when forwarding a text/plain mail. Fixes #5983. 2024-06-24 16:41:07 +02:00
smizrahi 7ec7a7d6ae fix(mail): Fix not called draft expunge function when sending mail. 2024-05-29 10:07:55 +02:00
smizrahi 19ee54fe05 fix(mail): Fix template issues with Galician and Basque 2024-04-30 10:21:26 +02:00
Hivert Quentin 2e2e36e0a2 fix(attachment): properly download openxmlformats in attachments 2024-04-29 14:21:03 +02:00
Hivert Quentin 2e37e59ed1 fix(vulnerability): prevent cross-site scripting when previewing attachments 2024-04-03 17:34:16 +02:00
smizrahi e6ff9a408d fix(mail): Add encoding fallback when there are ISO char in file name. Fixes #5388. 2024-03-18 15:15:35 +01:00
Hivert Quentin 96331cac90 feat(mail): add options to not add X-Foward header in mail 2024-03-07 15:36:40 +01:00
Hivert Quentin f609c31a32 feat(ytnef): add possibility to add event to calendar from winmail.dat 2024-03-06 16:50:38 +01:00
smizrahi e92fb8f52d feat(core): Update to ckeditor 5. Fixes #5920. 2024-02-27 14:29:59 +01:00
Hivert Quentin adc2d74e54 feat(accounts): Can now add smtp server to auxilliary accounts 2024-02-08 17:07:25 +01:00
Hivert Quentin f0010afef4 feat(accounts): Can now add smtp server to auxilliary accounts 2024-02-01 16:55:41 +01:00
smizrahi 0d0eda2698 fix(mail): Disable inline images in attachments when HTML emails writing is disabled. Fixes #5877. 2024-01-22 09:40:10 +01:00
smizrahi d1634054d6 fix(mail): Clean temporary files when mail is sent. Check if body part is NGMimeFileData to add path for cleaning. 2023-11-07 10:38:54 +01:00
smizrahi f35a37bbdd fix(mail): Clean temporary files when mail is sent 2023-11-01 15:40:33 +01:00
smizrahi 9c0948518b fix(mail): Fix duplication of images when saving draft. Fixes #5888. Clean old code 2023-11-01 10:29:25 +01:00
smizrahi ee9899fe3d fix(mail): Fix duplication of images when saving draft. Fixes #5888 2023-10-13 10:29:42 +02:00
Hivert Quentin b396a277f0 feat(reply): add references header when replying 2023-10-04 14:55:27 +02:00
smizrahi 4f7c73143f fix(calendar): Fix MacOS X Ventura calendar support. Fixes #5639 2023-08-22 18:11:53 +02:00
Hivert Quentin e959583390 fix(mail): Templates namespace is correctly returned 2023-08-09 16:30:33 +02:00
smizrahi 87bbba0c8d feat(calendar): Add CALDAV Mac OS X Sonoma (14) support 2023-07-31 09:19:15 +02:00
smizrahi 8582e423bd feat(preferences): Add user preferences to enable / disable signature for new mail, reply and forward 2023-07-26 19:38:57 +02:00
Hivert Quentin 665861d830 i181(gl_ES) add Galician language support 2023-06-12 08:56:30 +02:00
smizrahi 9da6521cfb Merge branch 'master' into SOGo-5.8 2023-05-30 18:25:41 +02:00
Hivert Quentin 5f47fc7bcb i18n(cy): Update Welsh translations 2023-05-30 09:47:00 +02:00
Hivert Quentin 2b7552a5a9 i18n(es_ES): Update SpanishSpain translations 2023-05-30 09:47:00 +02:00