Monotone-Parent: aa4f4dab1e9d7e5e3e3e654a9e43c3a7409de48b

Monotone-Revision: 11b16e47828dac92fd5fc6a0141e90ca854b7b89

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2009-10-10T18:37:10
Monotone-Branch: ca.inverse.sogo

ChangeLog

@@ -1,5 +1,15 @@
 2009-10-10  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
 
+	* UI/MailPartViewers/UIxMailPartICalActions.m (-_emailEvent):
+	"eventString" is now released to avoid a leak.
+
+	* UI/MailPartViewers/UIxMailPartHTMLViewer.m (-dealloc): ignoreTag
+	is released, to avoid a leak if the HTML content was not compliant.
+
+	* UI/Contacts/UIxListView.m (-checkListReferences): the copy of
+	"card" must be released once put in the "invalid" array, in order
+	to avoid a leak.
+
 	* Main/SOGo.m (-init): released "rm" when no longer needed.
 	(-dispatchRequest:): simplified leak catching code.
 

UI/Contacts/UIxListView.m

@@ -71,7 +71,7 @@
 - (void) checkListReferences
 {
   NSMutableArray *invalid;
-  NGVCardReference *card;
+  NGVCardReference *card, *cardCopy;
   int i, count;
   id test;
 
@@ -87,7 +87,9 @@
       if ([test isKindOfClass: [NSException class]])
         {
           NSLog (@"%@ not found", [card reference]);
-          [invalid addObject: [card copy]];
+          cardCopy = [card copy];
+          [invalid addObject: cardCopy];
+          [cardCopy release];
         }
     }
 
@@ -135,7 +137,7 @@
     {
       card = [[list cardReferences] objectAtIndex: i];
       [data addObject: [NSArray arrayWithObjects: [card reference], [card fn], 
-        [card email], nil]];
+                                [card email], nil]];
     }
 
   rc = [context response];

UI/MailPartViewers/UIxMailPartHTMLViewer.m

@@ -148,6 +148,7 @@ _xmlCharsetForCharset (NSString *charset)
 {
   [result release];
   [css release];
+  [ignoreTag release];
   [super dealloc];
 }
 

UI/MailPartViewers/UIxMailPartICalActions.m

@@ -66,6 +66,7 @@
     eventString = [[NSString alloc] initWithData: content
 				    encoding: NSISOLatin1StringEncoding];
   emailCalendar = [iCalCalendar parseSingleFromSource: eventString];
+  [eventString release];
 
   return (iCalEvent *) [emailCalendar firstChildWithTag: @"vevent"];
 }