diff --git a/ChangeLog b/ChangeLog index ce6918a78..57851a118 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,15 @@ 2009-10-10 Wolfgang Sourdeau + * UI/MailPartViewers/UIxMailPartICalActions.m (-_emailEvent): + "eventString" is now released to avoid a leak. + + * UI/MailPartViewers/UIxMailPartHTMLViewer.m (-dealloc): ignoreTag + is released, to avoid a leak if the HTML content was not compliant. + + * UI/Contacts/UIxListView.m (-checkListReferences): the copy of + "card" must be released once put in the "invalid" array, in order + to avoid a leak. + * Main/SOGo.m (-init): released "rm" when no longer needed. (-dispatchRequest:): simplified leak catching code. diff --git a/UI/Contacts/UIxListView.m b/UI/Contacts/UIxListView.m index d52338179..31cf69c0a 100644 --- a/UI/Contacts/UIxListView.m +++ b/UI/Contacts/UIxListView.m @@ -71,7 +71,7 @@ - (void) checkListReferences { NSMutableArray *invalid; - NGVCardReference *card; + NGVCardReference *card, *cardCopy; int i, count; id test; @@ -87,7 +87,9 @@ if ([test isKindOfClass: [NSException class]]) { NSLog (@"%@ not found", [card reference]); - [invalid addObject: [card copy]]; + cardCopy = [card copy]; + [invalid addObject: cardCopy]; + [cardCopy release]; } } @@ -135,7 +137,7 @@ { card = [[list cardReferences] objectAtIndex: i]; [data addObject: [NSArray arrayWithObjects: [card reference], [card fn], - [card email], nil]]; + [card email], nil]]; } rc = [context response]; diff --git a/UI/MailPartViewers/UIxMailPartHTMLViewer.m b/UI/MailPartViewers/UIxMailPartHTMLViewer.m index d475200a7..98387e813 100644 --- a/UI/MailPartViewers/UIxMailPartHTMLViewer.m +++ b/UI/MailPartViewers/UIxMailPartHTMLViewer.m @@ -148,6 +148,7 @@ _xmlCharsetForCharset (NSString *charset) { [result release]; [css release]; + [ignoreTag release]; [super dealloc]; } diff --git a/UI/MailPartViewers/UIxMailPartICalActions.m b/UI/MailPartViewers/UIxMailPartICalActions.m index d91193c81..9e7ebe283 100644 --- a/UI/MailPartViewers/UIxMailPartICalActions.m +++ b/UI/MailPartViewers/UIxMailPartICalActions.m @@ -66,6 +66,7 @@ eventString = [[NSString alloc] initWithData: content encoding: NSISOLatin1StringEncoding]; emailCalendar = [iCalCalendar parseSingleFromSource: eventString]; + [eventString release]; return (iCalEvent *) [emailCalendar firstChildWithTag: @"vevent"]; }