added warnings

Monotone-Parent: baa7bc0bc74871932c7f4e4d759f25a216d0c939
Monotone-Revision: 754cc32ff48ea7363d073e4e89e453b7a4d66a4c

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2009-10-10T18:27:21
Monotone-Branch: ca.inverse.sogo

Main/SOGoProductLoader.m

@@ -84,6 +84,7 @@ static NSString *productDirectoryName = @"SOGo";
 
   if (!searchPathes)
     {
+#warning we should work on searchPathes directly instead of ma
       ma = [NSMutableArray arrayWithCapacity: 6];
 
       [self _addGNUstepSearchPathesToArray: ma];

SoObjects/Mailer/SOGoMailBodyPart.m

@@ -115,6 +115,7 @@ static BOOL debugOn = NO;
   if (pathToPart != nil)
     return ([pathToPart isNotNull] ? (id)pathToPart : nil);
   
+#warning partToPart should be populated directly
   p = [[NSMutableArray alloc] initWithCapacity:8];
   for (obj = self; [obj isKindOfClass:[SOGoMailBodyPart class]]; 
        obj = [obj container]) {

SoObjects/Mailer/SOGoMailFolder.m

@@ -355,7 +355,8 @@ static NSString *spoolFolder = nil;
   NSMutableArray *zipTaskArguments;
   WOResponse *response;
   int i;
-  
+
+#warning this method should be rewritten according to our coding styles  
   spoolPath = [self userSpoolFolderPath];
   if ( ![self ensureSpoolFolderPath] ) {
     error = [NSException exceptionWithHTTPStatus: 500 

SoObjects/Mailer/SOGoMailObject.m

@@ -1424,7 +1424,7 @@ static BOOL debugSoParts       = NO;
 {
   NSDictionary *fetch;
   NSData *data;
-  NSString *value, *rc;;
+  NSString *value, *rc;
 
   rc = nil;
   fetch = [self _fetchProperty: @"BODY[HEADER.FIELDS (REFERENCES)]"];

UI/AdministrationUI/UIxAdministrationFilterPanel.m

@@ -32,19 +32,13 @@
 
 @implementation UIxAdministrationFilterPanel
 
-static NSArray      *filters           = nil;
+static NSMutableArray      *filters           = nil;
 
 + (void) initialize
 {
-  NSMutableDictionary *md;
-  NSMutableArray *ma;
-  
-  md = [[NSMutableDictionary alloc] initWithCapacity:8];
-  ma = [[NSMutableArray alloc] initWithCapacity:4];
-
-  filters           = [ma copy];
-  [md release]; md = nil;
-  [ma release]; ma = nil;
+#warning how useful is this?
+  if (!filters)
+    filters = [[NSMutableArray alloc] initWithCapacity: 4];
 }
 
 - (id) init
@@ -69,12 +63,12 @@ static NSArray      *filters           = nil;
 
 - (void) setSearchText: (NSString *)_txt
 {
-  ASSIGNCOPY(searchText, _txt);
+  ASSIGNCOPY (searchText, _txt);
 }
 
 - (void) setSearchCriteria: (NSString *)_txt
 {
-  ASSIGNCOPY(searchText, _txt);
+  ASSIGNCOPY (searchText, _txt);
 }
 
 - (NSString *) searchText

UI/Contacts/UIxContactsFilterPanel.m

@@ -31,19 +31,13 @@
 
 @implementation UIxContactsFilterPanel
 
-static NSArray      *filters           = nil;
+static NSMutableArray *filters = nil;
 
 + (void) initialize
 {
-  NSMutableDictionary *md;
-  NSMutableArray *ma;
-  
-  md = [[NSMutableDictionary alloc] initWithCapacity:8];
-  ma = [[NSMutableArray alloc] initWithCapacity:4];
-
-  filters           = [ma copy];
-  [md release]; md = nil;
-  [ma release]; ma = nil;
+#warning how useful is this?
+  if (!filters)
+    filters = [[NSMutableArray alloc] initWithCapacity:4];
 }
 
 - (id) init
@@ -68,12 +62,12 @@ static NSArray      *filters           = nil;
 
 - (void) setSearchText: (NSString *)_txt
 {
-  ASSIGNCOPY(searchText, _txt);
+  ASSIGNCOPY (searchText, _txt);
 }
 
 - (void) setSearchCriteria: (NSString *)_txt
 {
-  ASSIGNCOPY(searchText, _txt);
+  ASSIGNCOPY (searchText, _txt);
 }
 
 - (NSString *) searchText

UI/MailerUI/UIxMailFilterPanel.m

@@ -52,6 +52,7 @@ static NSArray *filters = nil;
   NSMutableArray *ma;
   unsigned i;
   
+#warning why not populate "filters" directly, as an NSMutableArray?
   md = [[NSMutableDictionary alloc] initWithCapacity:8];
   ma = [[NSMutableArray alloc] initWithCapacity:4];