diff --git a/Main/SOGoProductLoader.m b/Main/SOGoProductLoader.m index d942ebd99..b9b6eb5d1 100644 --- a/Main/SOGoProductLoader.m +++ b/Main/SOGoProductLoader.m @@ -84,6 +84,7 @@ static NSString *productDirectoryName = @"SOGo"; if (!searchPathes) { +#warning we should work on searchPathes directly instead of ma ma = [NSMutableArray arrayWithCapacity: 6]; [self _addGNUstepSearchPathesToArray: ma]; diff --git a/SoObjects/Mailer/SOGoMailBodyPart.m b/SoObjects/Mailer/SOGoMailBodyPart.m index 8d6842a65..d94b69d49 100644 --- a/SoObjects/Mailer/SOGoMailBodyPart.m +++ b/SoObjects/Mailer/SOGoMailBodyPart.m @@ -115,6 +115,7 @@ static BOOL debugOn = NO; if (pathToPart != nil) return ([pathToPart isNotNull] ? (id)pathToPart : nil); +#warning partToPart should be populated directly p = [[NSMutableArray alloc] initWithCapacity:8]; for (obj = self; [obj isKindOfClass:[SOGoMailBodyPart class]]; obj = [obj container]) { diff --git a/SoObjects/Mailer/SOGoMailFolder.m b/SoObjects/Mailer/SOGoMailFolder.m index 62703ac82..dae84dc29 100644 --- a/SoObjects/Mailer/SOGoMailFolder.m +++ b/SoObjects/Mailer/SOGoMailFolder.m @@ -355,7 +355,8 @@ static NSString *spoolFolder = nil; NSMutableArray *zipTaskArguments; WOResponse *response; int i; - + +#warning this method should be rewritten according to our coding styles spoolPath = [self userSpoolFolderPath]; if ( ![self ensureSpoolFolderPath] ) { error = [NSException exceptionWithHTTPStatus: 500 diff --git a/SoObjects/Mailer/SOGoMailObject.m b/SoObjects/Mailer/SOGoMailObject.m index 2ca751a33..e352d1fcf 100644 --- a/SoObjects/Mailer/SOGoMailObject.m +++ b/SoObjects/Mailer/SOGoMailObject.m @@ -1424,7 +1424,7 @@ static BOOL debugSoParts = NO; { NSDictionary *fetch; NSData *data; - NSString *value, *rc;; + NSString *value, *rc; rc = nil; fetch = [self _fetchProperty: @"BODY[HEADER.FIELDS (REFERENCES)]"]; diff --git a/UI/AdministrationUI/UIxAdministrationFilterPanel.m b/UI/AdministrationUI/UIxAdministrationFilterPanel.m index 4af89ffca..97635d4bd 100644 --- a/UI/AdministrationUI/UIxAdministrationFilterPanel.m +++ b/UI/AdministrationUI/UIxAdministrationFilterPanel.m @@ -32,19 +32,13 @@ @implementation UIxAdministrationFilterPanel -static NSArray *filters = nil; +static NSMutableArray *filters = nil; + (void) initialize { - NSMutableDictionary *md; - NSMutableArray *ma; - - md = [[NSMutableDictionary alloc] initWithCapacity:8]; - ma = [[NSMutableArray alloc] initWithCapacity:4]; - - filters = [ma copy]; - [md release]; md = nil; - [ma release]; ma = nil; +#warning how useful is this? + if (!filters) + filters = [[NSMutableArray alloc] initWithCapacity: 4]; } - (id) init @@ -69,12 +63,12 @@ static NSArray *filters = nil; - (void) setSearchText: (NSString *)_txt { - ASSIGNCOPY(searchText, _txt); + ASSIGNCOPY (searchText, _txt); } - (void) setSearchCriteria: (NSString *)_txt { - ASSIGNCOPY(searchText, _txt); + ASSIGNCOPY (searchText, _txt); } - (NSString *) searchText diff --git a/UI/Contacts/UIxContactsFilterPanel.m b/UI/Contacts/UIxContactsFilterPanel.m index c78796b81..55fa93af5 100644 --- a/UI/Contacts/UIxContactsFilterPanel.m +++ b/UI/Contacts/UIxContactsFilterPanel.m @@ -31,19 +31,13 @@ @implementation UIxContactsFilterPanel -static NSArray *filters = nil; +static NSMutableArray *filters = nil; + (void) initialize { - NSMutableDictionary *md; - NSMutableArray *ma; - - md = [[NSMutableDictionary alloc] initWithCapacity:8]; - ma = [[NSMutableArray alloc] initWithCapacity:4]; - - filters = [ma copy]; - [md release]; md = nil; - [ma release]; ma = nil; +#warning how useful is this? + if (!filters) + filters = [[NSMutableArray alloc] initWithCapacity:4]; } - (id) init @@ -68,12 +62,12 @@ static NSArray *filters = nil; - (void) setSearchText: (NSString *)_txt { - ASSIGNCOPY(searchText, _txt); + ASSIGNCOPY (searchText, _txt); } - (void) setSearchCriteria: (NSString *)_txt { - ASSIGNCOPY(searchText, _txt); + ASSIGNCOPY (searchText, _txt); } - (NSString *) searchText diff --git a/UI/MailerUI/UIxMailFilterPanel.m b/UI/MailerUI/UIxMailFilterPanel.m index ea38b7ed1..89e83dc0d 100644 --- a/UI/MailerUI/UIxMailFilterPanel.m +++ b/UI/MailerUI/UIxMailFilterPanel.m @@ -52,6 +52,7 @@ static NSArray *filters = nil; NSMutableArray *ma; unsigned i; +#warning why not populate "filters" directly, as an NSMutableArray? md = [[NSMutableDictionary alloc] initWithCapacity:8]; ma = [[NSMutableArray alloc] initWithCapacity:4];