mirror of
https://github.com/inverse-inc/sogo.git
synced 2026-11-08 10:13:40 +00:00
Jordi Mallach
a863283680
AngularJS (EOL since 2022-01) and AngularJS Material no longer receive
security fixes, so any new vulnerability in them will stay unpatched.
In AngularJS, templates are code: any attacker-controlled text that
ends up in a compiled template is evaluated as an expression, and
since 1.6 there is no expression sandbox, so a single
{{constructor.constructor('...')()}} gives full script execution.
SOGo renders untrusted data (mail bodies, invitations, attachment
names, contact fields) into such templates and currently relies on
server-side filtering, like stripping "{{" and "}}", to prevent this.
Any gap in that filtering, or a bypass of $sanitize/ng-bind-html,
would mean XSS in the webmail session: reading and sending mail as
the user, and access to calendars and contacts.
A Content Security Policy adds a second layer in the browser that
doesn't depend on catching every injection. The new
SOGoContentSecurityPolicy system default ("report-only" or "enforce",
disabled when unset) sends a strict policy with the pages of the web
interface:
script-src 'self' 'nonce-<random>' (no 'unsafe-inline'/'unsafe-eval')
style-src 'self' 'unsafe-inline' (Angular Material, CKEditor 5)
object-src 'none'; base-uri 'self'; frame-ancestors 'self'; ...
The policy is generated by sogod, since a fresh 128-bit nonce is needed
per response: it is shared by all components of the response and set
on the inline configuration scripts of the page frame and module views.
The page also gets ng-csp="no-unsafe-eval", so AngularJS evaluates
expressions with its interpreter instead of Function().
With the policy enforced, an expression injected into a compiled
template, such as {{constructor.constructor('...')()}}, can no longer
reach Function() and fails with an EvalError, and injected inline
scripts are blocked. Injected expressions are limited to calling
functions available on the scope.
Tested with Chromium in both modes on login, Mail (HTML messages,
remote content, invitations, compose), Calendar and Contacts editors,
Preferences and Administration: no violations from SOGo's own code.
With the default unset, the generated output is unchanged.
form-action is deliberately not restricted, so SAML2/CAS/OpenID
logins posting to an external IdP keep working. Scripts listed in
SOGoUIAdditionalJSFiles are served from WebServerResources and allowed,
but must not load scripts from other origins, use eval() or rely on
inline handlers; their dependencies have to be installed and listed
alongside them.
133 lines
3.7 KiB
Objective-C
133 lines
3.7 KiB
Objective-C
/*
|
|
Copyright (C) 2007-2019 Inverse inc.
|
|
|
|
This file is part of SOGo
|
|
|
|
SOGo is free software; you can redistribute it and/or modify it under
|
|
the terms of the GNU Lesser General Public License as published by the
|
|
Free Software Foundation; either version 2, or (at your option) any
|
|
later version.
|
|
|
|
SOGo is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public
|
|
License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with OGo; see the file COPYING. If not, write to the
|
|
Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
|
|
02111-1307, USA.
|
|
*/
|
|
|
|
#ifndef __UIxComponent_H_
|
|
#define __UIxComponent_H_
|
|
|
|
#import <NGObjWeb/SoComponent.h>
|
|
#import <NGObjWeb/WOContext+SoObjects.h>
|
|
|
|
#import <SOGo/SOGoObject.h>
|
|
|
|
/*
|
|
UIxComponent
|
|
|
|
Common superclass for most components used in SOGo.
|
|
|
|
TODO: document facilities.
|
|
*/
|
|
|
|
@class NSCalendarDate, NSTimeZone, NSMutableDictionary, SoUser, SOGoUserDefaults;
|
|
|
|
@interface UIxComponent : SoComponent
|
|
{
|
|
NSMutableDictionary *queryParameters;
|
|
NSCalendarDate *_selectedDate;
|
|
NSDictionary *locale;
|
|
SOGoUserDefaults *userDefaults;
|
|
NSArray *languages;
|
|
}
|
|
|
|
+ (NSArray *) amPmLabelKeys;
|
|
+ (NSArray *) monthLabelKeys;
|
|
+ (NSArray *) abbrMonthLabelKeys;
|
|
|
|
- (NSString *)queryParameterForKey:(NSString *)_key;
|
|
- (NSDictionary *)queryParameters;
|
|
|
|
/* use this to set 'sticky' query parameters */
|
|
- (void)setQueryParameter:(NSString *)_param forKey:(NSString *)_key;
|
|
|
|
/* date related query parameters */
|
|
- (NSDictionary *)queryParametersBySettingSelectedDate:(NSCalendarDate *)_date;
|
|
- (void)setSelectedDateQueryParameter:(NSCalendarDate *)_newDate
|
|
inDictionary:(NSMutableDictionary *)_qp;
|
|
|
|
/* appends queryParameters to _method if any are set */
|
|
- (NSString *)completeHrefForMethod:(NSString *)_method;
|
|
|
|
- (NSString *)ownMethodName;
|
|
|
|
- (NSString *)userFolderPath;
|
|
- (NSString *)applicationPath;
|
|
- (NSString *)modulePath;
|
|
|
|
- (NSString *)ownPath;
|
|
- (NSString *)relativePathToUserFolderSubPath:(NSString *)_sub;
|
|
|
|
/* date selection */
|
|
- (NSCalendarDate *) selectedDate;
|
|
|
|
- (NSString *) dateStringForDate: (NSCalendarDate *)_date;
|
|
|
|
- (BOOL) hideFrame;
|
|
|
|
/* SoUser */
|
|
- (NSString *) shortUserNameForDisplay;
|
|
|
|
/* Common defaults and settings */
|
|
- (int) minimumSearchLength;
|
|
- (NSString *) minimumSearchLengthLabel;
|
|
|
|
/* labels */
|
|
- (NSString *) labelForKey:(NSString *)_key;
|
|
- (NSString *) commonLabelForKey:(NSString *)_key;
|
|
- (NSString *) labelForKey: (NSString *) _str
|
|
withResourceManager: (WOResourceManager *) _rm;
|
|
|
|
- (NSString *) localizedNameForDayOfWeek:(unsigned)_dayOfWeek;
|
|
- (NSString *) localizedAbbreviatedNameForDayOfWeek:(unsigned)_dayOfWeek;
|
|
- (NSString *) localizedNameForMonthOfYear:(unsigned)_monthOfYear;
|
|
- (NSString *) localizedAbbreviatedNameForMonthOfYear:(unsigned)_monthOfYear;
|
|
|
|
/* HTTP method safety */
|
|
- (BOOL) isInvokedBySafeMethod;
|
|
|
|
/* display the "save" button */
|
|
- (BOOL) canCreateOrModify;
|
|
|
|
/* locale */
|
|
- (NSDictionary *)locale;
|
|
- (NSString *) localeCode;
|
|
|
|
/* cached resource filenames */
|
|
- (WOResourceManager *) pageResourceManager;
|
|
- (NSString *) urlForResourceFilename: (NSString *) filename;
|
|
|
|
- (WOResponse *) responseWithStatus: (unsigned int) status;
|
|
- (WOResponse *) responseWithStatus: (unsigned int) status
|
|
andString: (NSString *) contentString;
|
|
- (WOResponse *) responseWithStatus: (unsigned int) status
|
|
andJSONRepresentation: (NSObject *) contentObject;
|
|
- (WOResponse *) responseWith204;
|
|
- (WOResponse *) redirectToLocation: (NSString *) newLocation;
|
|
|
|
/* Debugging */
|
|
- (NSString *) buildDate;
|
|
- (BOOL) isUIxDebugEnabled;
|
|
|
|
/* Content Security Policy */
|
|
- (NSString *) cspNonce;
|
|
|
|
@end
|
|
|
|
#endif /* __UIxComponent_H_ */
|