Commit Graph
56 Commits
Author SHA1 Message Date
Patrice Levesque 7a09bbf498 Remove unsupported Thunderbird versions from docs. 2016-06-28 13:14:45 -04:00
Patrice Levesque 74efb6a0b1 Fresher version numbers and slight reformulations. 2016-06-23 13:14:23 -04:00
Patrice Levesque 551405fac6 Comment out 'su' logrotate parameter
This parameter needs logrotate >= 3.8.0 which is too recent for
half our supported distributions and is not strictly necessary.
2016-06-22 09:30:59 -04:00
Patrice Levesque 61381225d9 Loosen logrotate directives for custom deployments
Logrotate refuses to rotate logfiles if /var/log/sogo has permissive write
permissions, but sometimes that is needed, especially with setups involving
multiple SOGo installs running under different UNIX users.
2016-06-20 15:55:47 -04:00
Patrice Levesque fa78566d72 Fix builds in directory names containing spaces
Prevent ./configure failure when run from a directory
such as "/home/bob/my own sogo directory/"
2016-06-09 15:17:14 -04:00
Patrice Levesque d6d3e49158 Remove Makefile condition for test-uninitialized 2016-06-09 13:00:01 -04:00
Patrice Levesque a69e99b4c8 Do not force -frecord-gcc-switches flag
The -frecord-gcc-switches flag does not exist for
GCC <= 4.3; hence only use it when available.
2016-06-06 11:03:32 -04:00
Patrice Levesque 5983c5cf4d Fix sogo system user creation (extra)
Missing file in commit 9dcc25abc5
2016-06-06 10:33:49 -04:00
Patrice Levesque 04d12f52f8 Add -O2 compilation by default and -g debug info
Also store GCC command-line switches in the binaries for easier
debugging.
2016-06-02 11:37:19 -04:00
Patrice Levesque 0d507ff038 Use table naming convention from the documentation 2016-05-31 11:36:33 -04:00
Patrice Levesque 2e38215988 Add safeguard to optional SQL upgrade script.
Ensure nobody runs this by mistake, it can seriously break a SOGo installation.
2016-05-30 15:18:36 -04:00
Patrice Levesque c46a5f8df7 Ensure 'sogo' UNIX group exists at installation
Previous logic only checked for user existence.
2016-05-30 11:40:25 -04:00
Patrice Levesque 8225a4ccb0 Soft-ensure SOGo is started after MariaDB. 2016-05-24 10:29:33 -04:00
Patrice Levesque 0bcfadc780 (doc) Add missing mention of two tables SOGo creates.
Which are sogo_quick_appointment and sogo_quick_contact.
2016-05-12 18:02:05 -04:00
Patrice Levesque 49a6d58a07 Add MySQL utf8mb4-enabled database schema
This alternative database schema can be used to enable complete Unicode coverage on SOGo with MySQL, under certain circumstances.
2016-05-12 17:34:19 -04:00
Patrice Levesque f36570fb90 Add missing EOF that got lost somewhere 2016-04-13 09:41:05 -04:00
Patrice Levesque 117af61609 Port two recent debian packaging commits to debian-multiarch
Add a post-install/upgrade note on DB schema upgrade.
commit 9d7a21883a

Make example scripts in documentation executable.
commit 1f029c9c70
2016-04-12 13:18:22 -04:00
Patrice Levesque 02bb9ba9d0 Wrap RequestHeader in conditional for safety.
Prevent breaking users' Apache configuration (and prevent frightening
error message) when mod_headers is not turned on at SOGo installation.
2016-04-12 13:04:50 -04:00
Patrice Levesque 9d7a21883a Add a post-install/upgrade note on DB schema upgrade. 2016-04-11 17:07:47 -04:00
Patrice Levesque e88ce682f3 Make example scripts in documentation executable (RHEL).
Addresses bug #3053 at http://sogo.nu/bugs/view.php?id=3053
2016-04-11 14:23:02 -04:00
Patrice Levesque 1f029c9c70 Make example scripts in documentation executable.
Addresses bug #3053 at http://sogo.nu/bugs/view.php?id=3053
2016-04-11 11:30:23 -04:00
Patrice Levesque 990a5f4823 Fix behaviour change in error handling, introduced by commit f284fb71dda0ea9754f1582c6951d5f462e947bc
As pointed out on https://github.com/inverse-inc/sogo/pull/201#discussion_r54881994
2016-03-07 10:50:17 -05:00
Patrice Levesque c3f69416be Replace stubs with parent implementations.
Which makes real sense; reference from
https://github.com/inverse-inc/sogo/pull/201#discussion_r54880038 and
https://github.com/inverse-inc/sogo/pull/201#discussion_r54880094
2016-03-07 10:46:40 -05:00
Patrice Levesque 4210131e12 Initialize highestmodseq to avoid any surprise.
Strongly inspired by comment at https://github.com/inverse-inc/sogo/pull/201#discussion-diff-54879796
2016-03-07 10:43:38 -05:00
Patrice Levesque ce38a9c606 Fix one warning: expected ‘struct NSError **’ but argument is of type ‘id’
nil is not recognized by GCC as a (NSError**), but as an (id).  NULL works the
same but does not spawn warnings.
2016-03-07 10:34:41 -05:00
Patrice Levesque a813e38897 Comment out sendMail method in SOGoDraftObject and replace its sole known usage by sendMailAndCopyToSent.
In a 2011-09-26 commit (in Changelog.old), I understand the author wanted to
phase sendMail out and replace it by sendMailAndCopyToSent.  Since there are
compilation warnings related to sendMail, removing the sendMail method and
replacing the sole call to it seemed like the cleanest way.
2016-03-07 10:34:41 -05:00
Patrice Levesque fc9dde885b Fix warnings; both ‘WORequest’ may not respond to ‘-httpRequest’ and no ‘-parts’ method found. 2016-03-07 10:34:41 -05:00
Patrice Levesque 281062a1a1 Fix warning: incomplete implementation of category ‘SOGoExtensions’
Original method was commented out, but not its matching .h declaration;
hence commenting out the .h declaration.
2016-03-07 10:34:41 -05:00
Patrice Levesque f55391b7d0 Add missing header declarations that made the compiler spit out warnings. 2016-03-07 10:34:41 -05:00
Patrice Levesque c1095a5ea9 Fix warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
As previous commit, this code assumed pointers are unsigned int, for display
purpose.  Replaced the cast with the native '%p' token from
NSMutableString::appendFormat that's provided for pointer address output.
2016-03-07 10:34:41 -05:00
Patrice Levesque 022fd81474 Fix warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Those are all log formatting routines that assume pointers are unsigned int,
for display purpose.  Replace the cast with the native '%p' token from
NSString::stringWithFormat that's provided for pointer address output.
2016-03-07 10:34:41 -05:00
Patrice Levesque 478b313122 Fix warning: distinct Objective-C type in return
Method is supposed to return a WOResponse pointer, but currently returns a
NSException pointer; typecast the return value, just like the archiveUIDs
method does.
2016-03-07 10:34:41 -05:00
Patrice Levesque 3ba0e9f82f Implement stubs for SOGoCalendarComponent::isNew and SOGoCalendarComponent::setIsNew methods.
Those are required to implement the SOGoComponentOccurence protocol hence
their absence creates compilation warnings.
2016-03-07 10:34:40 -05:00
Patrice Levesque 0b1cf9faaf Avoid warning: the address of ‘timezone’ will always evaluate as ‘true’
As timezone is a pointer allocated on the stack, there is no need to check
for a NULL pointer - if that was ever the initial intention.
2016-03-07 10:34:40 -05:00
Patrice Levesque 986665f011 Workaround warning: ‘locale’ is used uninitialized in this function [-Wuninitialized]
'locale' being an uninitialized pointer, I don't believe setting it to nil will
make things worse here.
2016-03-07 10:34:40 -05:00
Patrice Levesque 5b71ed319a Fix warning: variable ‘uidnext’ set but not used [-Wunused-but-set-variable]
Remove uidnext declaration and calls that change its value.
2016-03-07 10:34:40 -05:00
Patrice Levesque ddade629fd Synchronize .h and .m method signatures. 2016-03-07 10:34:40 -05:00
Patrice Levesque 5e9d0ce95a Fix warning: ‘-textValue’ not found in protocol(s)
Confusingly, labelNode is a DOMElement, not a DOMNode, so textValue cannot
apply here; textContent which would be an appropriate replacement does not
exist AFAIK in this DOM Library.

So we manually get the text node via firstChild then get its text value
via nodeValue.
2016-03-07 10:34:40 -05:00
Patrice Levesque 10729b9a5f Merge branch 'master' of https://github.com/inverse-inc/sogo 2016-02-17 10:11:04 -05:00
Patrice Levesque 2de72e5070 Partly revert recent changes removing #imports and #includes, under OpenChange, as they cause more problems than they solve. 2016-02-17 10:09:18 -05:00
Patrice Levesque 6bb2065f46 Fix too aggressive #include and #import removal in ActiveSync directory - it broke master branch. 2016-02-16 18:39:58 -05:00
waptaff 1aab0595a1 Merge pull request #199 from inverse-inc/fix-some-warnings
Housekeeping: fix some warnings / remove dead code / remove pointless #includes and #imports
2016-02-16 14:34:37 -05:00
Patrice Levesque 9cb1b899b0 Merge branch 'master' into fix-some-warnings
Conflicts:
	UI/Scheduler/UIxAppointmentActions.m
2016-02-16 14:32:50 -05:00
Patrice Levesque a5cc2bb5d5 Merge branch 'master' into fix-some-warnings
Conflicts:
	SoObjects/Appointments/SOGoAppointmentObject.m
2016-02-15 11:23:27 -05:00
Patrice Levesque 9e83ff9f04 Fix compilation errors with OpenSSL 2016-02-15 11:14:06 -05:00
Patrice Levesque 5bd2f558bf Prevents 'make prod' from failing when auto-generated files do not change. 2016-02-15 10:18:34 -05:00
Patrice Levesque 520b1094be Remove now-useless preprocessor conditional block 2016-02-13 18:15:38 -05:00
Patrice Levesque bd56f4cf9f Remove pointless #include from .m and .h files
This was done with a brute-force approach, ensuring no additional
warnings from GCC 4.9 under x86_64.
2016-02-13 17:41:54 -05:00
Patrice Levesque 7c25b53fdf Remove pointless #imports from .m and .h files
This was done with a brute-force approach, ensuring no additional
warnings from GCC 4.9 under x86_64.
2016-02-13 16:11:52 -05:00
Patrice Levesque 31f0472db4 Cleanup unused variables 2016-02-10 15:17:19 -05:00
Patrice Levesque 93158f5121 Wrap common looping idiom inside double-parenthesis to shutup warning 2016-02-10 15:16:42 -05:00
Patrice Levesque 296d510572 Merge branch 'missing-prototypes' into fix-some-warnings
Avoid compilation errors when using GCC with -Werror=missing-declarations
and -Werror=missing-prototypes (those flags are wanted to track and fix
further warnings).
2016-02-10 14:58:28 -05:00
Patrice Levesque 51cbb980ad Add some missing preprocessing #import directives
Fixes most GCC warnings of form:
	warning: @interface of class ‘MyClass’ not found
2016-02-10 14:46:11 -05:00
Patrice Levesque d2695bab82 Better fix for *_stringForCharacterAtIndex's missing prototype 2016-02-10 11:29:43 -05:00
Patrice Levesque 5539b7a823 Add missing header prototypes
Fixes compiling errors with GCC using -Werror=missing-prototypes.
2016-02-08 16:14:33 -05:00
Patrice Levesque 1d868ff73c Remove 'git stash' commands from 'prod' recipe: it caused odd side-effects on pristine local repositories 2016-02-04 15:03:41 -05:00