fix(mail): Removed invalid HTML tags in mail body. Fixes #5755

SoObjects/SOGo/NSString+Utilities.h

@@ -92,6 +92,9 @@
 - (NSString *) encryptWithKey: (NSString *) theKey;
 - (NSString *) decryptWithKey: (NSString *) theKey;
 
+/* HTML */
+- (NSString *) cleanInvalidHTMLTags;
+
 @end
 
 #endif /* NSSTRING_URL_H */

SoObjects/SOGo/NSString+Utilities.m

@@ -1001,4 +1001,15 @@ static int cssEscapingCount;
   return result;
 }
 
+- (NSString *) cleanInvalidHTMLTags {
+  // Clean HTML invalid tags as reported in https://bugs.sogo.nu/view.php?id=5755
+  NSString *s;
+  
+  s = [NSString stringWithString: self];
+  s = [s stringByReplacingOccurrencesOfString:@"<!-->" withString:@""];
+  s = [s stringByReplacingOccurrencesOfString:@"<!--<!" withString:@"<!--"];
+
+  return s;
+}
+
 @end

Tests/Unit/TestNSString+Utilities.m

@@ -110,5 +110,11 @@
   testEquals([[NSString stringWithString:@"foobar <img onmouseover=foo bar"] stringWithoutHTMLInjection: NO], @"foobar <img onmouseo***=foo bar");
 }
 
+- (void) test_stringCleanInvalidHTMLTags
+{
+  testEquals([[NSString stringWithString:@"<div>Test<!--></div>"] cleanInvalidHTMLTags], @"<div>Test</div>");
+  testEquals([[NSString stringWithString:@"<div><!--[if !mso]><span>Test</span><!--<![endif]--></div>"] cleanInvalidHTMLTags], @"<div><!--[if !mso]><span>Test</span><!--[endif]--></div>");
+}
+
 
 @end

UI/MailPartViewers/UIxMailPartHTMLViewer.m

@@ -845,7 +845,7 @@ _xmlCharsetForCharset (NSString *charset)
       if (!s)
         s = [[NSString alloc] initWithData: preparsedContent  encoding: NSISOLatin1StringEncoding];
 
-      preparsedContent = [[s safeString] dataUsingEncoding: NSUTF8StringEncoding];
+      preparsedContent = [[[s cleanInvalidHTMLTags] safeString] dataUsingEncoding: NSUTF8StringEncoding];
       RELEASE(s);
     }