fix(pwd): use the proper url for reset password mail part3

.devcontainer/conf/sogo/sogo.conf

@@ -15,9 +15,9 @@
    *                                                                           *
    * **************************************************************************/
 
-  /* Database configuration (mysql://, postgresql:// or oracle://) */
   WOPort = "0.0.0.0:50000";
 
+  /* Database configuration (mysql://, postgresql:// or oracle://) */
 
   // MySQL
   SOGoProfileURL = "mysql://sogobuild:sogo123@mariadb:3306/sogo/sogo_user_profile";

Documentation/SOGoInstallationGuide.asciidoc

@@ -840,6 +840,16 @@ Obiously, if your users can connect without specifying a domain, let this parame
 |S |SOGoPasswordRecoveryEnabled
 |Boolean enable password recovery with secret question or secondary e-mail. Default value is `NO`.
 
+|S |SOGoPasswordRecoveryBaseURLs
+| *Since 5.12.11*. Whitlist of base URL for password reset link.
+
+`SOGoPasswordRecoveryBaseURLs = ("https://demo.sogo.nu");`
+`SOGoPasswordRecoveryBaseURLs = ("https://platform1.sogo.nu", "https://platform2.sogo.nu);`
+
+Do not end the URLs by '/'.
+
+No defaults, will trhow an error if empty or unset.
+
 |S |SOGoPasswordRecoveryDomains
 |List of domains where password recovery is enabled, for example `(example.org, example.net)`. If empty array `()`, disabled for all domains. If not set, enabled for all domains.
 
@@ -2886,6 +2896,11 @@ SOGoMailJunkSettings = {
 };
 ----
 
+|D |mailJunkIcon
+|Choose the Junk icon. For the thumb down `thumb_down`, for a shield `gpp_bad`.
+
+Defaults to `gppthumb_down_bad`.
+
 |D |SOGoMailKeepDraftsAfterSend
 |Parameter used to keep mails in the drafts folder once they have been
 sent by SOGo. Defaults to `NO` when unset.
@@ -4284,6 +4299,9 @@ current version of SOGo from the previous release.
 [cols="100a"]
 |=======================================================================
 
+h|5.12.11
+|If you enable Password Recovery, new mandatory settings `SOGoPasswordRecoveryBaseURLs`
+
 h|5.11
 |Parameters `SOGoGlobalAddressBookFirstEntries` and `SOGoGlobalAddressBookFirstEntriesCount` has been removed. Please use `listRequiresDot` and `globalAddressBookFirstEntriesCount` instead. Signature are now between a div tag to avoid CKEditor changing the content - set `SOGoForceRawHtmlSignature` to `NO` to leave signature (https://bugs.sogo.nu/view.php?id=5920).
 

Main/sogod.m

@@ -56,13 +56,6 @@ main (int argc, char **argv, char **env)
         NSLog (@"Sogo secret is not correctly set");
       }
 
-      //Check sogo base urls
-      if(!((baseUrls = [sd baseURLs]) && [baseUrls count] > 0))
-      {
-        rc = -1;
-        NSLog (@"SOGoBaseUrls is not set or empty");
-      }
-      
       if(rc == 0)
       {
         WOWatchDogApplicationMain (@"SOGo", argc, (void *) argv);

SoObjects/SOGo/SOGoSystemDefaults.h

@@ -57,7 +57,6 @@ static const NSString *kDisableSharingCalendar = @"Calendar";
 - (NSString *) sogoSecretValue;
 - (BOOL) useRelativeURLs;
 - (NSString *) sieveFolderEncoding;
-- (NSArray *) baseURLs;
 
 - (BOOL) isWebAccessEnabled;
 - (BOOL) isCalendarDAVAccessEnabled;
@@ -150,6 +149,7 @@ NSComparisonResult languageSort(id el1, id el2, void *context);
 - (BOOL) isEasUIDisabled;
 
 - (BOOL)isPasswordRecoveryEnabled;
+- (NSArray *) passwordRecoveryBaseURLs;
 - (NSArray *) passwordRecoveryDomains;
 - (NSString *) JWTSecret;
 

SoObjects/SOGo/SOGoSystemDefaults.m

@@ -724,12 +724,6 @@ NSComparisonResult languageSort(id el1, id el2, void *context)
   return [self stringForKey: @"SOGoLoginSuffix"];
 }
 
-- (NSArray *) baseURLs
-{
-  return [self stringArrayForKey: @"SOGoBaseUrls"];
-}
-
-
 - (NSString *) authenticationType
 {
   return [[self stringForKey: @"SOGoAuthenticationType"] lowercaseString];
@@ -1088,6 +1082,11 @@ NSComparisonResult languageSort(id el1, id el2, void *context)
   return [self boolForKey: @"SOGoPasswordRecoveryEnabled"];
 }
 
+- (NSArray *) passwordRecoveryBaseURLs
+{
+  return [self stringArrayForKey: @"SOGoPasswordRecoveryBaseURLs"];
+}
+
 - (NSArray *) passwordRecoveryDomains
 {
   static NSArray *passwordRecoveryDomains = nil;

UI/MainUI/SOGoRootPage.m

@@ -1374,14 +1374,23 @@ static const NSString *kJwtKey = @"jwt";
           mailer = [SOGoMailer mailerWithDomainDefaults: dd];
 
           //Get Allowed server URL and check if it's OK
-          baseUrls = [[SOGoSystemDefaults sharedSystemDefaults] baseURLs];
+          baseUrls = [[SOGoSystemDefaults sharedSystemDefaults] passwordRecoveryBaseURLs];
           serverUrl = [[request headers] objectForKey:@"origin"];
 
+          if(!(baseUrls && [baseUrls count] > 0))
+          {
+            [self logWithFormat: @"Password recovery exception for user %@: empty or unset SOGoPasswordRecoveryBaseURLs", uid];
+            response = [self responseWithStatus: 403
+                              andString: @"Password recovery email in error"];
+            return response;
+          }
+
           if(![baseUrls containsObject:serverUrl])
           {
             [self logWithFormat: @"Password recovery exception for user %@: invalid request header", uid];
             response = [self responseWithStatus: 403
                               andString: @"Password recovery email in error"];
+            return response;
           }
 
           url = [NSString stringWithFormat:@"%@%@?token=%@"