merge of '3df4271ffa54be2fdec6fa5cc5170ed38c1e01df'

and '407012b144380da01f4b13cfb23faba545da887a'

Monotone-Parent: 3df4271ffa54be2fdec6fa5cc5170ed38c1e01df
Monotone-Parent: 407012b144380da01f4b13cfb23faba545da887a
Monotone-Revision: f90d169fbc251326ea6c8a2f620e125a8a7b4168

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2012-04-19T19:04:07

ChangeLog

@@ -6,6 +6,10 @@
 
 2012-04-19  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
 
+	* SoObjects/SOGo/SOGoParentFolder.m (-appendSubscribedSources):
+	ensure the array set as values in the settings dicts are not nil
+	prior to setting them.
+
 	* SoObjects/Appointments/SOGoAppointmentFolder.m
 	(-fetchFields:from:to:title:component:additionalFilters:includeProtectedInformation:):
 	fix the date condition for cycle record, by using c_cycleenddate

SoObjects/SOGo/SOGoParentFolder.m

@@ -293,11 +293,10 @@ static SoSecurityManager *sm = nil;
   subscribedReferences = [NSMutableArray arrayWithArray: [[settings objectForKey: nameInContainer]
 							   objectForKey: @"SubscribedFolders"]];
   o =  [[settings objectForKey: nameInContainer] objectForKey: @"FolderDisplayNames"];
-  folderDisplayNames = nil;
-
   if (o)
     folderDisplayNames = [NSMutableDictionary dictionaryWithDictionary: o];
- 
+  else
+    folderDisplayNames = nil;
 
   allKeys = [subscribedReferences objectEnumerator];
   while ((currentKey = [allKeys nextObject]))
@@ -315,12 +314,12 @@ static SoSecurityManager *sm = nil;
   // If we changed the folder subscribtion list, we must sync it
   if (dirty)
     {
-      id o;
-
-      [[settings objectForKey: nameInContainer] setObject: subscribedReferences
-						   forKey: @"SubscribedFolders"];
-      [[settings objectForKey: nameInContainer] setObject: folderDisplayNames
-						   forKey: @"FolderDisplayNames"];
+      if (subscribedReferences)
+        [[settings objectForKey: nameInContainer] setObject: subscribedReferences
+                                                     forKey: @"SubscribedFolders"];
+      if (folderDisplayNames)
+        [[settings objectForKey: nameInContainer] setObject: folderDisplayNames
+                                                     forKey: @"FolderDisplayNames"];
     }
 	    
   return error;