amorfo77/sogo
1
0
Fork 0
mirror of https://github.com/inverse-inc/sogo.git synced 2026-02-17 07:33:57 +00:00
Code Issues Projects Releases Wiki Activity

fix(login): Only remember the login if the auth was successful

Browse Source
This commit is contained in:
Hivert Quentin
2025-10-02 13:37:56 +02:00
parent 981748754a
commit 9e20190fad
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
UI/MainUI/SOGoRootPage.m
View File

@@ -274,7 +274,7 @@ static const NSString *kJwtKey = @"jwt";
SOGoPasswordPolicyError err;
int expire, grace;
BOOL rememberLogin, b;
BOOL rememberLogin, b, loginSuccess;
err = PolicyNoError;
expire = grace = -1;
@@ -296,12 +296,14 @@ static const NSString *kJwtKey = @"jwt";
perr: &err expire: &expire grace: &grace additionalInfo: &additionalLoginInformations useCache: NO];
[self translateAdditionalLoginInformations: &additionalLoginInformations];
if (b
loginSuccess = b
&& (err == PolicyNoError)
// no password policy
&& ((expire < 0 && grace < 0) // no password policy or everything is alright
|| (expire < 0 && grace > 0) // password expired, grace still permits login
|| (expire >= 0 && grace == -1))) // password about to expire OR ppolicy activated and passwd never changed
|| (expire >= 0 && grace == -1)); // password about to expire OR ppolicy activated and passwd never changed
if (loginSuccess)
{
NSMutableDictionary *json = [NSMutableDictionary dictionary];
@@ -442,7 +444,8 @@ static const NSString *kJwtKey = @"jwt";
response = [self _responseWithLDAPPolicyError: err additionalInfos: additionalLoginInformations];
}
if (rememberLogin)
//Only remember login If the auth was succesful...
if (rememberLogin && loginSuccess)
[response addCookie: [self _cookieWithUsername: [params objectForKey: @"userName"]]];
else
[response addCookie: [self _cookieWithUsername: nil]];