(js) Fix validation in Sieve filter editor

Fixes #4200
2026-07-09 10:25:08 +00:00 · 2017-06-16 16:35:20 -04:00
parent ca43e7d9ca
commit 6c654e0f90
1 changed files with 7 additions and 2 deletions
@@ -92,8 +92,13 @@
    }

    function hasRulesAndActions() {
-      return vm.filter.rules && vm.filter.rules.length > 0 &&
-        vm.filter.actions && vm.filter.actions.length > 0;
+      var requirements = [ vm.filter.actions ];
+      if (vm.filter.match != 'allmessages')
+        // When matching all messages, no rules are required
+        requirements.push(vm.filter.rules);
+      return _.every(requirements, function(a) {
+        return a && a.length > 0;
+      });
    }
    
    function save(form) {