amorfo77/sogo
1
0
Fork 0
mirror of https://github.com/inverse-inc/sogo.git synced 2026-05-21 11:25:24 +00:00
Code Issues Projects Releases Wiki Activity

perf(mail): Improve IMAP fetch sorting using NSDictionary keys instead of indexOfObject

Browse Source
This commit is contained in:
smizrahi
2022-11-16 21:08:48 +01:00
parent 714acfc838
commit 40b5c0918a
1 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SoObjects/Mailer/SOGoMailFolder.m
+25 -2
View File
@@ -120,6 +120,22 @@ static NSInteger _compareFetchResultsByUID (id entry1, id entry2, NSArray *uids)
return NSOrderedAscending;
}
static NSInteger _compareFetchResultsByUIDDict (id entry1, id entry2, NSDictionary *uids)
{
NSString *uid1, *uid2;
NSUInteger pos1, pos2;
uid1 = [entry1 objectForKey: @"uid"];
uid2 = [entry2 objectForKey: @"uid"];
pos1 = [[uids objectForKey: [NSString stringWithFormat: @"%@", uid1]] intValue];
pos2 = [[uids objectForKey: [NSString stringWithFormat: @"%@", uid2]] intValue];
if (pos1 > pos2)
return NSOrderedDescending;
else
return NSOrderedAscending;
}
@interface NGImap4Connection (PrivateMethods)
- (NSString *) imap4FolderNameForURL: (NSURL *) url;
@@ -2348,6 +2364,8 @@ static NSInteger _compareFetchResultsByUID (id entry1, id entry2, NSArray *uids)
NSArray *a, *uids;
NSDictionary *d;
id fetchResults, sortedResults;
NSUInteger i;
NSMutableDictionary *uidsDict;
int i;
uint64_t highestmodseq = 0;
@@ -2415,8 +2433,13 @@ static NSInteger _compareFetchResultsByUID (id entry1, id entry2, NSArray *uids)
}
else
{
sortedResults = [fetchResults sortedArrayUsingFunction: _compareFetchResultsByUID
context: uids];
uidsDict = [[NSMutableDictionary alloc] init];
for (i = 0 ; i < [uids length] ; i++) {
[uidsDict setObject:[NSNumber numberWithInt: i] forKey: [NSString stringWithFormat:@"%d", [[uids objectAtIndex: i] intValue]]];
}
sortedResults = [fetchResults sortedArrayUsingFunction: _compareFetchResultsByUIDDict
context: uidsDict];
[uidsDict release];
}
for (i = 0; i < [sortedResults count]; i++)