Add regression test for converting json to std::variant<json> (#5066)

With 3.10.5, get<std::variant<json>>() was well-formed through the string
from_json overload, so the implicit conversion operator was a candidate
when converting json to std::variant<json>, and MSVC picked it over the
variant's converting constructor. The tightened constraints from #3427 and
#3604 (3.11.0) removed that path; this test guards against regressions.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

.github/labeler.yml

@@ -37,13 +37,13 @@ labels:
   files:
     - "include/nlohmann/detail/input/binary_reader\\.hpp"
     - "include/nlohmann/detail/output/binary_writer\\.hpp"
-    - "tests/src/unit-(bson|cbor|msgpack|ubjson|bjdata|bon8|binary_formats)"
-    - "tests/src/fuzzer-parse_(bson|cbor|msgpack|ubjson|bjdata|bon8)"
+    - "tests/src/unit-(bson|cbor|msgpack|ubjson|bjdata|binary_formats)"
+    - "tests/src/fuzzer-parse_(bson|cbor|msgpack|ubjson|bjdata)"
     - "docs/mkdocs/docs/features/binary_formats/"
-    - "docs/mkdocs/docs/(api/basic_json|examples)/(to|from)_(bson|cbor|msgpack|ubjson|bjdata|bon8)"
+    - "docs/mkdocs/docs/(api/basic_json|examples)/(to|from)_(bson|cbor|msgpack|ubjson|bjdata)"
 
 - label: "aspect: binary formats"
-  title: "(?i)(bson|cbor|msgpack|messagepack|ubjson|bjdata|bon8|binary format)"
+  title: "(?i)(bson|cbor|msgpack|messagepack|ubjson|bjdata|binary format)"
 
 - label: "python"
   files:

Makefile

@@ -36,7 +36,6 @@ all:
 	@echo "clean - remove built files"
 	@echo "doctest - compile example files and check their output"
 	@echo "fuzz_testing - prepare fuzz testing of the JSON parser"
-	@echo "fuzz_testing_bon8 - prepare fuzz testing of the BON8 parser"
 	@echo "fuzz_testing_bson - prepare fuzz testing of the BSON parser"
 	@echo "fuzz_testing_cbor - prepare fuzz testing of the CBOR parser"
 	@echo "fuzz_testing_msgpack - prepare fuzz testing of the MessagePack parser"
@@ -72,14 +71,6 @@ fuzz_testing:
 	find tests/data/json_tests -size -5k -name *json | xargs -I{} cp "{}" fuzz-testing/testcases
 	@echo "Execute: afl-fuzz -i fuzz-testing/testcases -o fuzz-testing/out fuzz-testing/fuzzer"
 
-fuzz_testing_bon8:
-	rm -fr fuzz-testing
-	mkdir -p fuzz-testing fuzz-testing/testcases fuzz-testing/out
-	$(MAKE) parse_bon8_fuzzer -C tests CXX=afl-clang++
-	mv tests/parse_bon8_fuzzer fuzz-testing/fuzzer
-	find tests/data -size -5k -name *.bon8 | xargs -I{} cp "{}" fuzz-testing/testcases
-	@echo "Execute: afl-fuzz -i fuzz-testing/testcases -o fuzz-testing/out fuzz-testing/fuzzer"
-
 fuzz_testing_bson:
 	rm -fr fuzz-testing
 	mkdir -p fuzz-testing fuzz-testing/testcases fuzz-testing/out

README.md

@@ -40,7 +40,7 @@
   - [Implicit conversions](#implicit-conversions)
   - [Conversions to/from arbitrary types](#arbitrary-types-conversions)
   - [Specializing enum conversion](#specializing-enum-conversion)
-  - [Binary formats (BSON, CBOR, MessagePack, UBJSON, BJData, and BON8)](#binary-formats-bson-cbor-messagepack-ubjson-bjdata-and-bon8)
+  - [Binary formats (BSON, CBOR, MessagePack, UBJSON, and BJData)](#binary-formats-bson-cbor-messagepack-ubjson-and-bjdata)
 - [Customers](#customers)
 - [Ecosystem](#ecosystem)
 - [Supported compilers](#supported-compilers)
@@ -128,7 +128,7 @@ There is also a [**docset**](https://github.com/Kapeli/Dash-User-Contributions/t
 - **JSON Pointer functions**: [flatten](https://json.nlohmann.me/api/basic_json/flatten), [unflatten](https://json.nlohmann.me/api/basic_json/unflatten)
 - **JSON Patch functions**: [patch](https://json.nlohmann.me/api/basic_json/patch), [patch_inplace](https://json.nlohmann.me/api/basic_json/patch_inplace), [diff](https://json.nlohmann.me/api/basic_json/diff), [merge_patch](https://json.nlohmann.me/api/basic_json/merge_patch)
 - **Static functions**: [meta](https://json.nlohmann.me/api/basic_json/meta), [get_allocator](https://json.nlohmann.me/api/basic_json/get_allocator)
-- **Binary formats**: [from_bjdata](https://json.nlohmann.me/api/basic_json/from_bjdata), [from_bon8](https://json.nlohmann.me/api/basic_json/from_bon8), [from_bson](https://json.nlohmann.me/api/basic_json/from_bson), [from_cbor](https://json.nlohmann.me/api/basic_json/from_cbor), [from_msgpack](https://json.nlohmann.me/api/basic_json/from_msgpack), [from_ubjson](https://json.nlohmann.me/api/basic_json/from_ubjson), [to_bjdata](https://json.nlohmann.me/api/basic_json/to_bjdata), [to_bon8](https://json.nlohmann.me/api/basic_json/to_bon8), [to_bson](https://json.nlohmann.me/api/basic_json/to_bson), [to_cbor](https://json.nlohmann.me/api/basic_json/to_cbor), [to_msgpack](https://json.nlohmann.me/api/basic_json/to_msgpack), [to_ubjson](https://json.nlohmann.me/api/basic_json/to_ubjson)
+- **Binary formats**: [from_bjdata](https://json.nlohmann.me/api/basic_json/from_bjdata), [from_bson](https://json.nlohmann.me/api/basic_json/from_bson), [from_cbor](https://json.nlohmann.me/api/basic_json/from_cbor), [from_msgpack](https://json.nlohmann.me/api/basic_json/from_msgpack), [from_ubjson](https://json.nlohmann.me/api/basic_json/from_ubjson), [to_bjdata](https://json.nlohmann.me/api/basic_json/to_bjdata), [to_bson](https://json.nlohmann.me/api/basic_json/to_bson), [to_cbor](https://json.nlohmann.me/api/basic_json/to_cbor), [to_msgpack](https://json.nlohmann.me/api/basic_json/to_msgpack), [to_ubjson](https://json.nlohmann.me/api/basic_json/to_ubjson)
 - **Non-member functions**: [operator<<](https://json.nlohmann.me/api/operator_ltlt/), [operator>>](https://json.nlohmann.me/api/operator_gtgt/), [to_string](https://json.nlohmann.me/api/basic_json/to_string)
 - **Literals**: [operator""_json](https://json.nlohmann.me/api/operator_literal_json)
 - **Helper classes**: [std::hash&lt;basic_json&gt;](https://json.nlohmann.me/api/basic_json/std_hash), [std::swap&lt;basic_json&gt;](https://json.nlohmann.me/api/basic_json/std_swap)
@@ -1110,9 +1110,9 @@ Other Important points:
 - When using `get<ENUM_TYPE>()`, undefined JSON values will default to the first pair specified in your map. Select this default pair carefully. If you desire an exception in this circumstance use `NLOHMANN_JSON_SERIALIZE_ENUM_STRICT()` which behaves identically except for throwing an exception on unrecognized values.
 - If an enum or JSON value is specified more than once in your map, the first matching occurrence from the top of the map will be returned when converting to or from JSON.
 
-### Binary formats (BSON, CBOR, MessagePack, UBJSON, BJData, and BON8)
+### Binary formats (BSON, CBOR, MessagePack, UBJSON, and BJData)
 
-Though JSON is a ubiquitous data format, it is not a very compact format suitable for data exchange, for instance over a network. Hence, the library supports [BSON](https://bsonspec.org) (Binary JSON), [CBOR](https://cbor.io) (Concise Binary Object Representation), [MessagePack](https://msgpack.org), [UBJSON](https://ubjson.org) (Universal Binary JSON Specification), [BJData](https://neurojson.org/bjdata) (Binary JData), and [BON8](https://github.com/hikoworks/hikogui/blob/main/docs/BON8.md) (Binary Object Notation 8) to efficiently encode JSON values to byte vectors and to decode such vectors.
+Though JSON is a ubiquitous data format, it is not a very compact format suitable for data exchange, for instance over a network. Hence, the library supports [BSON](https://bsonspec.org) (Binary JSON), [CBOR](https://cbor.io) (Concise Binary Object Representation), [MessagePack](https://msgpack.org), [UBJSON](https://ubjson.org) (Universal Binary JSON Specification) and [BJData](https://neurojson.org/bjdata) (Binary JData) to efficiently encode JSON values to byte vectors and to decode such vectors.
 
 ```cpp
 // create a JSON value
@@ -1149,14 +1149,6 @@ std::vector<std::uint8_t> v_ubjson = json::to_ubjson(j);
 
 // roundtrip
 json j_from_ubjson = json::from_ubjson(v_ubjson);
-
-// serialize to BON8
-std::vector<std::uint8_t> v_bon8 = json::to_bon8(j);
-
-// 0x88, 0x63, 0x6F, 0x6D, 0x70, 0x61, 0x63, 0x74, 0xF9, 0x73, 0x63, 0x68, 0x65, 0x6D, 0x61, 0x90
-
-// roundtrip
-json j_from_bon8 = json::from_bon8(v_bon8);
 ```
 
 The library also supports binary types from BSON, CBOR (byte strings), and MessagePack (bin, ext, fixext). They are stored by default as `std::vector<std::uint8_t>` to be processed outside the library.

cmake/ci.cmake

@@ -542,7 +542,7 @@ add_custom_target(ci_infer
 
 add_custom_target(ci_offline_testdata
     COMMAND mkdir -p ${PROJECT_BINARY_DIR}/build_offline_testdata/test_data
-    COMMAND cd ${PROJECT_BINARY_DIR}/build_offline_testdata/test_data && ${GIT_TOOL} clone -c advice.detachedHead=false --branch v3.2.0 https://github.com/nlohmann/json_test_data.git --quiet --depth 1
+    COMMAND cd ${PROJECT_BINARY_DIR}/build_offline_testdata/test_data && ${GIT_TOOL} clone -c advice.detachedHead=false --branch v3.1.0 https://github.com/nlohmann/json_test_data.git --quiet --depth 1
     COMMAND ${CMAKE_COMMAND}
         -DCMAKE_BUILD_TYPE=Debug -GNinja
         -DJSON_BuildTests=ON -DJSON_FastTests=ON -DJSON_TestDataDirectory=${PROJECT_BINARY_DIR}/build_offline_testdata/test_data/json_test_data

cmake/download_test_data.cmake

@@ -1,5 +1,5 @@
 set(JSON_TEST_DATA_URL     https://github.com/nlohmann/json_test_data)
-set(JSON_TEST_DATA_VERSION 3.2.0)
+set(JSON_TEST_DATA_VERSION 3.1.0)
 
 include(ExternalProject)
 

docs/docset/docSet.sql

@@ -48,7 +48,6 @@ INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::from_bjdata', 'Fu
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::from_bson', 'Function', 'api/basic_json/from_bson/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::from_cbor', 'Function', 'api/basic_json/from_cbor/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::from_msgpack', 'Function', 'api/basic_json/from_msgpack/index.html');
-INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::from_bon8', 'Function', 'api/basic_json/from_bon8/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::from_ubjson', 'Function', 'api/basic_json/from_ubjson/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::front', 'Method', 'api/basic_json/front/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::get', 'Method', 'api/basic_json/get/index.html');
@@ -122,7 +121,6 @@ INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::to_bjdata', 'Func
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::to_bson', 'Function', 'api/basic_json/to_bson/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::to_cbor', 'Function', 'api/basic_json/to_cbor/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::to_msgpack', 'Function', 'api/basic_json/to_msgpack/index.html');
-INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::to_bon8', 'Function', 'api/basic_json/to_bon8/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::to_string', 'Method', 'api/basic_json/to_string/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::to_ubjson', 'Function', 'api/basic_json/to_ubjson/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('basic_json::value', 'Method', 'api/basic_json/value/index.html');
@@ -173,7 +171,6 @@ INSERT INTO searchIndex(name, type, path) VALUES ('Binary Formats: BJData', 'Gui
 INSERT INTO searchIndex(name, type, path) VALUES ('Binary Formats: BSON', 'Guide', 'features/binary_formats/bson/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('Binary Formats: CBOR', 'Guide', 'features/binary_formats/cbor/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('Binary Formats: MessagePack', 'Guide', 'features/binary_formats/messagepack/index.html');
-INSERT INTO searchIndex(name, type, path) VALUES ('Binary Formats: BON8', 'Guide', 'features/binary_formats/bon8/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('Binary Formats: UBJSON', 'Guide', 'features/binary_formats/ubjson/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('Binary Values', 'Guide', 'features/binary_values/index.html');
 INSERT INTO searchIndex(name, type, path) VALUES ('Comments', 'Guide', 'features/comments/index.html');

docs/mkdocs/docs/api/basic_json/from_bjdata.md

@@ -104,7 +104,6 @@ Linear in the size of the input.
 - [from_msgpack](from_msgpack.md) create a JSON value from an input in MessagePack format
 - [from_bson](from_bson.md) create a JSON value from an input in BSON format
 - [from_ubjson](from_ubjson.md) create a JSON value from an input in UBJSON format
-- [from_bon8](from_bon8.md) create a JSON value from an input in BON8 format
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/from_bon8.md

@@ -1,108 +0,0 @@
-# <small>nlohmann::basic_json::</small>from_bon8
-
-```cpp
-// (1)
-template<typename InputType>
-static basic_json from_bon8(InputType&& i,
-                            const bool strict = true,
-                            const bool allow_exceptions = true);
-// (2)
-template<typename IteratorType, typename SentinelType = IteratorType>
-static basic_json from_bon8(IteratorType first, SentinelType last,
-                            const bool strict = true,
-                            const bool allow_exceptions = true);
-```
-
-Deserializes a given input to a JSON value using the BON8 (Binary Object Notation 8) serialization format.
-
-1. Reads from a compatible input.
-2. Reads from an iterator range, or an iterator and a sentinel of a different type (C++20 ranges support).
-
-The exact mapping and its limitations are described on a [dedicated page](../../features/binary_formats/bon8.md).
-
-## Template parameters
-
-`InputType`
-:   A compatible input, for instance:
-
-    - an `std::istream` object
-    - a `FILE` pointer
-    - a C-style array of characters
-    - a pointer to a null-terminated string of single byte characters
-    - a container `obj` for which `begin(obj)` and `end(obj)` produce a valid pair of iterators
-      (as found via ADL or member functions, with semantics compatible to `std::begin` and `std::end`)
-
-`IteratorType`
-:   a compatible iterator type
-
-`SentinelType`
-:   defaults to `IteratorType`; may be a different type comparable to `IteratorType` via `operator!=`, for instance.
-
-    - a custom sentinel type for C++20 ranges
-    - `std::default_sentinel_t`, when `IteratorType` is `std::counted_iterator`
-
-## Parameters
-
-`i` (in)
-:   an input in BON8 format convertible to an input adapter
-
-`first` (in)
-:   iterator to the start of the input
-
-`last` (in)
-:   iterator to the end of the input, or a sentinel value that compares equal to the end iterator with `operator!=`
-
-`strict` (in)
-:   whether to expect the input to be consumed until EOF (`#!cpp true` by default)
-
-`allow_exceptions` (in)
-:   whether to throw exceptions in case of a parse error (optional, `#!cpp true` by default)
-
-## Return value
-
-deserialized JSON value; in case of a parse error and `allow_exceptions` set to `#!cpp false`, the return value will be
-`value_t::discarded`. The latter can be checked with [`is_discarded`](is_discarded.md).
-
-## Exception safety
-
-Strong guarantee: if an exception is thrown, there are no changes in the JSON value.
-
-## Exceptions
-
-- Throws [parse_error.110](../../home/exceptions.md#jsonexceptionparse_error110) if the given input ends prematurely or
-  the end of the file was not reached when `strict` was set to true
-- Throws [parse_error.112](../../home/exceptions.md#jsonexceptionparse_error112) if a parse error occurs, for instance
-  an invalid byte, a string that is not valid UTF-8, or an object key that is not a string
-
-## Complexity
-
-Linear in the size of the input.
-
-## Examples
-
-??? example
-
-    The example shows the deserialization of a byte vector in BON8 format to a JSON value.
-     
-    ```cpp
-    --8<-- "examples/from_bon8.cpp"
-    ```
-    
-    Output:
-    
-    ```json
-    --8<-- "examples/from_bon8.output"
-    ```
-
-## See also
-
-- [to_bon8](to_bon8.md) create a BON8 serialization of a JSON value
-- [from_cbor](from_cbor.md) create a JSON value from an input in CBOR format
-- [from_msgpack](from_msgpack.md) create a JSON value from an input in MessagePack format
-- [from_bson](from_bson.md) create a JSON value from an input in BSON format
-- [from_ubjson](from_ubjson.md) create a JSON value from an input in UBJSON format
-- [from_bjdata](from_bjdata.md) create a JSON value from an input in BJData format
-
-## Version history
-
-- Added in version 3.13.0.

docs/mkdocs/docs/api/basic_json/from_bson.md

@@ -104,7 +104,6 @@ Linear in the size of the input.
 - [from_msgpack](from_msgpack.md) for the related MessagePack format
 - [from_ubjson](from_ubjson.md) for the related UBJSON format
 - [from_bjdata](from_bjdata.md) for the related BJData format
-- [from_bon8](from_bon8.md) for the related BON8 format
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/from_cbor.md

@@ -110,7 +110,6 @@ Linear in the size of the input.
 - [from_bson](from_bson.md) create a JSON value from an input in BSON format
 - [from_ubjson](from_ubjson.md) create a JSON value from an input in UBJSON format
 - [from_bjdata](from_bjdata.md) create a JSON value from an input in BJData format
-- [from_bon8](from_bon8.md) create a JSON value from an input in BON8 format
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/from_msgpack.md

@@ -103,7 +103,6 @@ Linear in the size of the input.
 - [from_bson](from_bson.md) create a JSON value from an input in BSON format
 - [from_ubjson](from_ubjson.md) create a JSON value from an input in UBJSON format
 - [from_bjdata](from_bjdata.md) create a JSON value from an input in BJData format
-- [from_bon8](from_bon8.md) create a JSON value from an input in BON8 format
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/from_ubjson.md

@@ -104,7 +104,6 @@ Linear in the size of the input.
 - [from_msgpack](from_msgpack.md) create a JSON value from an input in MessagePack format
 - [from_bson](from_bson.md) create a JSON value from an input in BSON format
 - [from_bjdata](from_bjdata.md) create a JSON value from an input in BJData format
-- [from_bon8](from_bon8.md) create a JSON value from an input in BON8 format
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/index.md

@@ -290,13 +290,11 @@ Access to the JSON value
 ### Binary formats
 
 - [**from_bjdata**](from_bjdata.md) (_static_) - create a JSON value from an input in BJData format
-- [**from_bon8**](from_bon8.md) (_static_) - create a JSON value from an input in BON8 format
 - [**from_bson**](from_bson.md) (_static_) - create a JSON value from an input in BSON format
 - [**from_cbor**](from_cbor.md) (_static_) - create a JSON value from an input in CBOR format
 - [**from_msgpack**](from_msgpack.md) (_static_) - create a JSON value from an input in MessagePack format
 - [**from_ubjson**](from_ubjson.md) (_static_) - create a JSON value from an input in UBJSON format
 - [**to_bjdata**](to_bjdata.md) (_static_) - create a BJData serialization of a given JSON value
-- [**to_bon8**](to_bon8.md) (_static_) - create a BON8 serialization of a given JSON value
 - [**to_bson**](to_bson.md) (_static_) - create a BSON serialization of a given JSON value
 - [**to_cbor**](to_cbor.md) (_static_) - create a CBOR serialization of a given JSON value
 - [**to_msgpack**](to_msgpack.md) (_static_) - create a MessagePack serialization of a given JSON value

docs/mkdocs/docs/api/basic_json/input_format_t.md

@@ -7,8 +7,7 @@ enum class input_format_t {
     msgpack,
     ubjson,
     bson,
-    bjdata,
-    bon8
+    bjdata
 };
 ```
 
@@ -32,9 +31,6 @@ bson
 bjdata
 :   BJData (Binary JData)
 
-bon8
-:   BON8 (Binary Object Notation 8)
-
 ## Examples
 
 ??? example

docs/mkdocs/docs/api/basic_json/parse_error.md

@@ -5,7 +5,7 @@ class parse_error : public exception;
 ```
 
 The library throws this exception when a parse error occurs. Parse errors can occur during the deserialization of
-JSON text, BJData, BON8, BSON, CBOR, MessagePack, UBJSON, as well as when using JSON Patch.
+JSON text, BSON, CBOR, MessagePack, UBJSON, as well as when using JSON Patch.
 
 Member `byte` holds the byte index of the last read character in the input file (see note below).
 

docs/mkdocs/docs/api/basic_json/sax_parse.md

@@ -65,8 +65,7 @@ The SAX event lister must follow the interface of [`json_sax`](../json_sax/index
 :   SAX event listener (must not be null)
 
 `format` (in)
-:    the format to parse (JSON, BJData, BON8, BSON, CBOR, MessagePack, or UBJSON) (optional, `input_format_t::json` by
-     default), see
+:    the format to parse (JSON, CBOR, MessagePack, or UBJSON) (optional, `input_format_t::json` by default), see
      [`input_format_t`](input_format_t.md) for more information
 
 `strict` (in)

docs/mkdocs/docs/api/basic_json/to_bjdata.md

@@ -84,7 +84,6 @@ Linear in the size of the JSON value `j`.
 - [to_msgpack](to_msgpack.md) create a MessagePack serialization of a JSON value
 - [to_bson](to_bson.md) create a BSON serialization of a JSON value
 - [to_ubjson](to_ubjson.md) create a UBJSON serialization of a JSON value
-- [to_bon8](to_bon8.md) create a BON8 serialization of a JSON value
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/to_bon8.md

@@ -1,76 +0,0 @@
-# <small>nlohmann::basic_json::</small>to_bon8
-
-```cpp
-// (1)
-static std::vector<std::uint8_t> to_bon8(const basic_json& j);
-
-// (2)
-static void to_bon8(const basic_json& j, detail::output_adapter<std::uint8_t> o);
-static void to_bon8(const basic_json& j, detail::output_adapter<char> o);
-```
-
-Serializes a given JSON value `j` to a byte vector using the BON8 (Binary Object Notation 8) serialization format. BON8
-is a compact binary serialization format that stores strings as UTF-8 without a length prefix.
-
-1. Returns a byte vector containing the BON8 serialization.
-2. Writes the BON8 serialization to an output adapter.
-
-The exact mapping and its limitations are described on a [dedicated page](../../features/binary_formats/bon8.md).
-
-## Parameters
-
-`j` (in)
-:   JSON value to serialize
-
-`o` (in)
-:   output adapter to write serialization to
-
-## Return value
-
-1. BON8 serialization as a byte vector
-2. (none)
-
-## Exception safety
-
-Strong guarantee: if an exception is thrown, there are no changes in the JSON value `j`, which is never modified.
-With (2), the bytes written before the exception remain in the output adapter.
-
-## Exceptions
-
-- Throws [out_of_range.407](../../home/exceptions.md#jsonexceptionout_of_range407) if `j` contains an unsigned integer
-  above 9223372036854775807, which BON8 cannot represent
-- Throws [type_error.316](../../home/exceptions.md#jsonexceptiontype_error316) if `j` contains a string that is not
-  valid UTF-8
-
-## Complexity
-
-Linear in the size of the JSON value `j`.
-
-## Examples
-
-??? example
-
-    The example shows the serialization of a JSON value to a byte vector in BON8 format.
-     
-    ```cpp
-    --8<-- "examples/to_bon8.cpp"
-    ```
-    
-    Output:
-    
-    ```json
-    --8<-- "examples/to_bon8.output"
-    ```
-
-## See also
-
-- [from_bon8](from_bon8.md) create a JSON value from an input in BON8 format
-- [to_cbor](to_cbor.md) create a CBOR serialization of a JSON value
-- [to_msgpack](to_msgpack.md) create a MessagePack serialization of a JSON value
-- [to_bson](to_bson.md) create a BSON serialization of a JSON value
-- [to_ubjson](to_ubjson.md) create a UBJSON serialization of a JSON value
-- [to_bjdata](to_bjdata.md) create a BJData serialization of a JSON value
-
-## Version history
-
-- Added in version 3.13.0.

docs/mkdocs/docs/api/basic_json/to_bson.md

@@ -72,7 +72,6 @@ pass before anything is written.
 - [to_msgpack](to_msgpack.md) create a MessagePack serialization of a JSON value
 - [to_ubjson](to_ubjson.md) create a UBJSON serialization of a JSON value
 - [to_bjdata](to_bjdata.md) create a BJData serialization of a JSON value
-- [to_bon8](to_bon8.md) create a BON8 serialization of a JSON value
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/to_cbor.md

@@ -62,7 +62,6 @@ Linear in the size of the JSON value `j`.
 - [to_bson](to_bson.md) create a BSON serialization of a JSON value
 - [to_ubjson](to_ubjson.md) create a UBJSON serialization of a JSON value
 - [to_bjdata](to_bjdata.md) create a BJData serialization of a JSON value
-- [to_bon8](to_bon8.md) create a BON8 serialization of a JSON value
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/to_msgpack.md

@@ -70,7 +70,6 @@ Linear in the size of the JSON value `j`.
 - [to_bson](to_bson.md) create a BSON serialization of a JSON value
 - [to_ubjson](to_ubjson.md) create a UBJSON serialization of a JSON value
 - [to_bjdata](to_bjdata.md) create a BJData serialization of a JSON value
-- [to_bon8](to_bon8.md) create a BON8 serialization of a JSON value
 
 ## Version history
 

docs/mkdocs/docs/api/basic_json/to_ubjson.md

@@ -77,7 +77,6 @@ Linear in the size of the JSON value `j`.
 - [to_msgpack](to_msgpack.md) create a MessagePack serialization of a JSON value
 - [to_bson](to_bson.md) create a BSON serialization of a JSON value
 - [to_bjdata](to_bjdata.md) create a BJData serialization of a JSON value
-- [to_bon8](to_bon8.md) create a BON8 serialization of a JSON value
 
 ## Version history
 

docs/mkdocs/docs/api/macros/json_strict_nul_handling.md

@@ -11,9 +11,9 @@ The macro only affects the JSON text parser ([`parse`](../basic_json/parse.md),
 [`sax_parse`](../basic_json/sax_parse.md), and [`operator>>`](../operator_gtgt.md)). There are three cases where a NUL
 byte is still not rejected:
 
-- The binary formats ([`from_bjdata`](../basic_json/from_bjdata.md), [`from_bon8`](../basic_json/from_bon8.md),
-  [`from_bson`](../basic_json/from_bson.md), [`from_cbor`](../basic_json/from_cbor.md),
-  [`from_msgpack`](../basic_json/from_msgpack.md), [`from_ubjson`](../basic_json/from_ubjson.md)) are never affected: there, `0x00` is ordinary data.
+- The binary formats ([`from_bjdata`](../basic_json/from_bjdata.md), [`from_bson`](../basic_json/from_bson.md),
+  [`from_cbor`](../basic_json/from_cbor.md), [`from_msgpack`](../basic_json/from_msgpack.md),
+  [`from_ubjson`](../basic_json/from_ubjson.md)) are never affected: there, `0x00` is ordinary data.
 - A bare `const char*` pointer has no length of its own, so its length is still determined with `strlen()`. The first
   NUL byte therefore still marks the end of the input, and nothing after it is read.
 - One trailing `'\0'` at the end of a `char` array (e.g., a string literal) is trimmed; see the warning below.

docs/mkdocs/docs/examples/from_bon8.cpp

@@ -1,21 +0,0 @@
-#include <iostream>
-#include <iomanip>
-#include <nlohmann/json.hpp>
-
-using json = nlohmann::json;
-
-int main()
-{
-    // create byte vector
-    std::vector<std::uint8_t> v = {0x89, 0x63, 0x6f, 0x6d, 0x70, 0x61, 0x63, 0x74,
-                                   0xf9, 0x66, 0x6f, 0x72, 0x6d, 0x61, 0x74, 0xff,
-                                   0x42, 0x4f, 0x4e, 0x38, 0xff, 0x73, 0x63, 0x68,
-                                   0x65, 0x6d, 0x61, 0x90
-                                  };
-
-    // deserialize it with BON8
-    json j = json::from_bon8(v);
-
-    // print the deserialized JSON value
-    std::cout << std::setw(2) << j << std::endl;
-}

docs/mkdocs/docs/examples/from_bon8.output

@@ -1,5 +0,0 @@
-{
-  "compact": true,
-  "format": "BON8",
-  "schema": 0
-}

docs/mkdocs/docs/examples/to_bon8.cpp

@@ -1,22 +0,0 @@
-#include <iostream>
-#include <iomanip>
-#include <nlohmann/json.hpp>
-
-using json = nlohmann::json;
-using namespace nlohmann::literals;
-
-int main()
-{
-    // create a JSON value
-    json j = R"({"compact": true, "format": "BON8", "schema": 0})"_json;
-
-    // serialize it to BON8
-    std::vector<std::uint8_t> v = json::to_bon8(j);
-
-    // print the vector content
-    for (auto& byte : v)
-    {
-        std::cout << "0x" << std::hex << std::setw(2) << std::setfill('0') << (int)byte << " ";
-    }
-    std::cout << std::endl;
-}

docs/mkdocs/docs/examples/to_bon8.output

@@ -1 +0,0 @@
-0x89 0x63 0x6f 0x6d 0x70 0x61 0x63 0x74 0xf9 0x66 0x6f 0x72 0x6d 0x61 0x74 0xff 0x42 0x4f 0x4e 0x38 0xff 0x73 0x63 0x68 0x65 0x6d 0x61 0x90 

docs/mkdocs/docs/features/binary_formats/bon8.md

@@ -1,159 +0,0 @@
-# BON8
-
-BON8 (Binary Object Notation 8) is a compact binary serialization format for JSON values. It uses the byte values that
-cannot begin a UTF-8 character as type markers, so strings are stored as plain UTF-8 without a length prefix: a string
-ends at the first byte that cannot continue it. Integers from -10 to 39, `true`, `false`, `null`, and the floating-point
-values -1.0, 0.0, and 1.0 take a single byte, and arrays and objects with up to four elements need no terminator.
-
-!!! abstract "References"
-
-    - [BON8 specification](https://github.com/hikoworks/hikogui/blob/main/docs/BON8.md)
-    - [Reference implementation](https://github.com/hikoworks/hikogui/blob/main/src/hikogui/codec/BON8.hpp) in HikoGUI
-
-## Serialization
-
-The library uses the following mapping from JSON values types to BON8 types according to the BON8 specification:
-
-| JSON value type | value/range                                  | BON8 type                     | first byte |
-|-----------------|----------------------------------------------|-------------------------------|------------|
-| null            | `null`                                       | null                          | 0xFA       |
-| boolean         | `true`                                       | true                          | 0xF9       |
-| boolean         | `false`                                      | false                         | 0xF8       |
-| number_integer  | -9223372036854775808..-2147483649            | int64                         | 0x8D       |
-| number_integer  | -2147483648..-33818507                       | int32                         | 0x8C       |
-| number_integer  | -33818506..-264075                           | 4-byte negative integer       | 0xF0..0xF7 |
-| number_integer  | -264074..-1931                               | 3-byte negative integer       | 0xE0..0xEF |
-| number_integer  | -1930..-11                                   | 2-byte negative integer       | 0xC2..0xDF |
-| number_integer  | -10..-1                                      | 1-byte negative integer       | 0xB8..0xC1 |
-| number_integer  | 0..39                                        | 1-byte positive integer       | 0x90..0xB7 |
-| number_integer  | 40..3879                                     | 2-byte positive integer       | 0xC2..0xDF |
-| number_integer  | 3880..528167                                 | 3-byte positive integer       | 0xE0..0xEF |
-| number_integer  | 528168..67637031                             | 4-byte positive integer       | 0xF0..0xF7 |
-| number_integer  | 67637032..2147483647                         | int32                         | 0x8C       |
-| number_integer  | 2147483648..9223372036854775807              | int64                         | 0x8D       |
-| number_unsigned | 0..39                                        | 1-byte positive integer       | 0x90..0xB7 |
-| number_unsigned | 40..3879                                     | 2-byte positive integer       | 0xC2..0xDF |
-| number_unsigned | 3880..528167                                 | 3-byte positive integer       | 0xE0..0xEF |
-| number_unsigned | 528168..67637031                             | 4-byte positive integer       | 0xF0..0xF7 |
-| number_unsigned | 67637032..2147483647                         | int32                         | 0x8C       |
-| number_unsigned | 2147483648..9223372036854775807              | int64                         | 0x8D       |
-| number_float    | `-1.0`                                       | -1.0                          | 0xFB       |
-| number_float    | `0.0`                                        | 0.0                           | 0xFC       |
-| number_float    | `1.0`                                        | 1.0                           | 0xFD       |
-| number_float    | *any other value representable by a float*   | binary32                      | 0x8E       |
-| number_float    | *any value NOT representable by a float*     | binary64                      | 0x8F       |
-| string          | *empty*                                      | end of string                 | 0xFF       |
-| string          | *non-empty*                                  | UTF-8 string                  | 0x00..0x7F, 0xC2..0xF4 |
-| array           | *size*: 0..4                                 | array with count              | 0x80..0x84 |
-| array           | *size*: 5 or more                            | array (terminated by 0xFE)    | 0x85       |
-| object          | *size*: 0..4                                 | object with count             | 0x86..0x8A |
-| object          | *size*: 5 or more                            | object (terminated by 0xFE)   | 0x8B       |
-| binary          | *size*: 0..4                                 | array with count              | 0x80..0x84 |
-| binary          | *size*: 5 or more                            | array (terminated by 0xFE)    | 0x85       |
-
-An integer that takes 2 to 4 bytes starts with a UTF-8 lead byte (0xC2..0xF7) that is followed by a byte that cannot
-continue a UTF-8 character: 0x00..0x7F for positive and 0xC0..0xFF for negative integers. A string is terminated by
-0xFF only if it is empty, if another string follows it, or if it is the last value of the message; otherwise, the first
-byte of the next value ends it.
-
-!!! success "Complete mapping"
-
-    Except for the values listed below, any JSON value can be converted to a BON8 value.
-
-    Any BON8 output created by `to_bon8` can be successfully parsed by `from_bon8`.
-
-!!! warning "Unsupported values"
-
-    The following values can **not** be converted to a BON8 value:
-
-      - unsigned integers above 9223372036854775807, because BON8 has no unsigned 64-bit integer type
-        ([out_of_range.407](../../home/exceptions.md#jsonexceptionout_of_range407))
-      - strings that are not valid UTF-8, because the end of a string is determined from its encoding
-        ([type_error.316](../../home/exceptions.md#jsonexceptiontype_error316))
-
-!!! info "NaN/infinity handling"
-
-    `-0.0`, `Infinity`, and `-Infinity` are serialized as binary32 (type 0x8E, 5 bytes total). `NaN` is serialized as
-    the binary32 value 0x7F800001 that the specification recommends. This is in contrast to the
-    [dump](../../api/basic_json/dump.md) function which serializes NaN or Infinity to `null`.
-
-!!! warning "Binary values"
-
-    BON8 has no binary type. Binary values are serialized as arrays of integers (0..255), so they are read back as
-    arrays. The subtype is not serialized.
-
-!!! info "Canonical representation"
-
-    The output follows the specification's canonical representation rules: every value uses the shortest encoding,
-    floating-point numbers use binary32 whenever that loses no precision, and object keys are sorted by their UTF-8
-    code units. There are two exceptions:
-
-    - Strings are not normalized to Unicode Normalization Form C (NFC).
-    - Object keys are written in the order of the object type, which is sorted for `json`, but not for
-      [`ordered_json`](../../api/ordered_json.md).
-
-??? example
-
-    ```cpp
-    --8<-- "examples/to_bon8.cpp"
-    ```
-
-    Output:
-
-    ```c
-    --8<-- "examples/to_bon8.output"
-    ```
-
-## Deserialization
-
-The library maps BON8 types to JSON value types as follows:
-
-| BON8 type                     | JSON value type | first byte             |
-|-------------------------------|-----------------|------------------------|
-| UTF-8 string                  | string          | 0x00..0x7F             |
-| array with count              | array           | 0x80..0x84             |
-| array (terminated by 0xFE)    | array           | 0x85                   |
-| object with count             | object          | 0x86..0x8A             |
-| object (terminated by 0xFE)   | object          | 0x8B                   |
-| int32                         | number_unsigned or number_integer | 0x8C |
-| int64                         | number_unsigned or number_integer | 0x8D |
-| binary32                      | number_float    | 0x8E                   |
-| binary64                      | number_float    | 0x8F                   |
-| 1-byte positive integer       | number_unsigned | 0x90..0xB7             |
-| 1-byte negative integer       | number_integer  | 0xB8..0xC1             |
-| UTF-8 string                  | string          | 0xC2..0xF4, followed by 0x80..0xBF |
-| 2- to 4-byte positive integer | number_unsigned | 0xC2..0xF7, followed by 0x00..0x7F |
-| 2- to 4-byte negative integer | number_integer  | 0xC2..0xF7, followed by 0xC0..0xFF |
-| false                         | `false`         | 0xF8                   |
-| true                          | `true`          | 0xF9                   |
-| null                          | `null`          | 0xFA                   |
-| -1.0                          | number_float    | 0xFB                   |
-| 0.0                           | number_float    | 0xFC                   |
-| 1.0                           | number_float    | 0xFD                   |
-| empty string                  | string          | 0xFF                   |
-
-Non-negative integers are read as number_unsigned, negative integers as number_integer.
-
-!!! info
-
-    Values that do not use the canonical representation, such as integers with a longer encoding than necessary,
-    arrays and objects with up to four elements that are terminated by 0xFE, unsorted object keys, or a 0xFF after a
-    string that would also end without it, are accepted. A second 0xFF is not a terminator but an empty string.
-
-    Strings must be valid UTF-8, and the last string of a message must be terminated by 0xFF.
-
-!!! info
-
-    Any BON8 output created by `to_bon8` can be successfully parsed by `from_bon8`.
-
-??? example
-
-    ```cpp
-    --8<-- "examples/from_bon8.cpp"
-    ```
-
-    Output:
-
-    ```json
-    --8<-- "examples/from_bon8.output"
-    ```

docs/mkdocs/docs/features/binary_formats/index.md

@@ -4,7 +4,6 @@ Though JSON is a ubiquitous data format, it is not a very compact format suitabl
 a network. Hence, the library supports
 
 - [BJData](bjdata.md) (Binary JData),
-- [BON8](bon8.md) (Binary Object Notation 8),
 - [BSON](bson.md) (Binary JSON),
 - [CBOR](cbor.md) (Concise Binary Object Representation),
 - [MessagePack](messagepack.md), and
@@ -19,7 +18,6 @@ to efficiently encode JSON values to byte vectors and to decode such vectors.
 | Format      | Serialization                                 | Deserialization                              |
 |-------------|-----------------------------------------------|----------------------------------------------|
 | BJData      | complete                                      | complete                                     |
-| BON8        | incomplete: no unsigned integers above int64  | complete                                     |
 | BSON        | incomplete: top-level value must be an object | incomplete, but all JSON types are supported |
 | CBOR        | complete                                      | incomplete, but all JSON types are supported |
 | MessagePack | complete                                      | complete                                     |
@@ -30,7 +28,6 @@ to efficiently encode JSON values to byte vectors and to decode such vectors.
 | Format      | Binary values | Binary subtypes |
 |-------------|---------------|-----------------|
 | BJData      | not supported | not supported   |
-| BON8        | not supported | not supported   |
 | BSON        | supported     | supported       |
 | CBOR        | supported     | supported       |
 | MessagePack | supported     | supported       |
@@ -45,7 +42,6 @@ See [binary values](../binary_values.md) for more information.
 | BJData             | 53.2 %      | 91.1 %       | 78.1 %            | 96.6 %        |
 | BJData (size)      | 58.6 %      | 92.1 %       | 86.7 %            | 97.4 %        |
 | BJData (size+type) | 58.6 %      | 92.1 %       | 86.5 %            | 97.4 %        |
-| BON8               | 50.5 %      | 83.8 %       | 63.5 %            | 87.5 %        |
 | BSON               | 85.8 %      | 95.2 %       | 95.8 %            | 106.7 %       |
 | CBOR               | 50.5 %      | 86.3 %       | 68.4 %            | 88.0 %        |
 | MessagePack        | 50.5 %      | 86.0 %       | 68.5 %            | 87.9 %        |

docs/mkdocs/docs/features/binary_values.md

@@ -187,41 +187,6 @@ as an array of uint8 values. The library implements this translation.
     }
     ```
 
-### BON8
-
-[BON8](binary_formats/bon8.md) neither supports binary values nor subtypes. The library serializes binary values as an
-array of integers.
-
-??? example
-
-    Code:
-
-    ```cpp
-    // create a binary value of subtype 42 (will be ignored in BON8)
-    json j;
-    j["binary"] = json::binary({0xCA, 0xFE, 0xBA, 0xBE}, 42);
-
-    // convert to BON8
-    auto v = json::to_bon8(j);
-    ```
-
-    `v` is a `std::vector<std::uint8_t>` with the following 16 elements:
-
-    ```c
-    0x87                                     // object with 1 member
-        0x62 0x69 0x6E 0x61 0x72 0x79        // "binary"
-        0x84                                 // array with 4 elements
-            0xC3 0x22 0xC3 0x56 0xC3 0x12 0xC3 0x16  // content (each byte as a 2-byte integer)
-    ```
-
-    Note that the subtype is lost, and deserializing `v` would yield the following value:
-
-    ```json
-    {
-      "binary": [202, 254, 186, 190]
-    }
-    ```
-
 ### BSON
 
 [BSON](binary_formats/bson.md) supports binary values and subtypes. If a subtype is given, it is used and added as an

docs/mkdocs/docs/features/index.md

@@ -35,8 +35,8 @@ C++ types, and finally serialize it again.
 - [Serialization](serialization.md) — turn a value back into JSON text with [`dump`](../api/basic_json/dump.md),
   including pretty-printing and handling of non-ASCII and invalid UTF-8.
 - [Binary formats](binary_formats/index.md) — encode values more compactly as
-  [BJData](binary_formats/bjdata.md), [BON8](binary_formats/bon8.md), [BSON](binary_formats/bson.md),
-  [CBOR](binary_formats/cbor.md), [MessagePack](binary_formats/messagepack.md), or [UBJSON](binary_formats/ubjson.md).
+  [BJData](binary_formats/bjdata.md), [BSON](binary_formats/bson.md), [CBOR](binary_formats/cbor.md),
+  [MessagePack](binary_formats/messagepack.md), or [UBJSON](binary_formats/ubjson.md).
 - [Binary values](binary_values.md) — store and exchange raw byte sequences.
 
 ## How values are stored and configured

docs/mkdocs/docs/features/serialization.md

@@ -117,7 +117,7 @@ For the [{fmt}](https://github.com/fmtlib/fmt) library, the library ships a
 ## Serializing to other formats
 
 Besides JSON text, a value can also be serialized to the more compact [binary formats](binary_formats/index.md)
-(BJData, BON8, BSON, CBOR, MessagePack, UBJSON).
+(BJData, BSON, CBOR, MessagePack, UBJSON).
 
 ## See also
 

docs/mkdocs/docs/features/types/template_parameters.md

@@ -547,7 +547,7 @@ Grisu2 algorithm, which produces the shortest representation that round-trips. O
 ### Required for the binary formats
 
 `NumberFloatType` must be `#!cpp float` or `#!cpp double`. The writers for
-[CBOR, MessagePack, UBJSON, BJData, BON8, and BSON](../binary_formats/index.md) map a floating-point value onto an IEEE 754
+[CBOR, MessagePack, UBJSON, BJData, and BSON](../binary_formats/index.md) map a floating-point value onto an IEEE 754
 binary32 or binary64 field and have no encoding for `#!cpp long double`.
 
 ### Compatible types

docs/mkdocs/includes/glossary.md

@@ -5,7 +5,6 @@
 *[ASCII]: American Standard Code for Information Interchange
 *[BDFL]: Benevolent Dictator for Life
 *[BJData]: Binary JData
-*[BON8]: Binary Object Notation 8
 *[BSON]: Binary JSON
 *[CBOR]: Concise Binary Object Representation
 *[CC0]: Creative Commons Zero

docs/mkdocs/mkdocs.yml

@@ -63,7 +63,6 @@ nav:
       - Binary Formats:
           - features/binary_formats/index.md
           - features/binary_formats/bjdata.md
-          - features/binary_formats/bon8.md
           - features/binary_formats/bson.md
           - features/binary_formats/cbor.md
           - features/binary_formats/messagepack.md
@@ -143,7 +142,6 @@ nav:
           - 'flatten': api/basic_json/flatten.md
           - 'format_as': api/basic_json/format_as.md
           - 'from_bjdata': api/basic_json/from_bjdata.md
-          - 'from_bon8': api/basic_json/from_bon8.md
           - 'from_bson': api/basic_json/from_bson.md
           - 'from_cbor': api/basic_json/from_cbor.md
           - 'from_msgpack': api/basic_json/from_msgpack.md
@@ -215,7 +213,6 @@ nav:
           - 'swap': api/basic_json/swap.md
           - 'std::swap<basic_json>': api/basic_json/std_swap.md
           - 'to_bjdata': api/basic_json/to_bjdata.md
-          - 'to_bon8': api/basic_json/to_bon8.md
           - 'to_bson': api/basic_json/to_bson.md
           - 'to_cbor': api/basic_json/to_cbor.md
           - 'to_msgpack': api/basic_json/to_msgpack.md
@@ -415,7 +412,7 @@ plugins:
       markdown_description: >
         JSON for Modern C++ is a C++11 header-only library implementing a JSON
         value type with an STL-like API, JSON Pointer/Patch, CBOR/MessagePack/
-        BSON/UBJSON/BJData/BON8 binary format support, and a SAX-style parser interface.
+        BSON/UBJSON/BJData binary format support, and a SAX-style parser interface.
       sections:
         Home:
           - index.md

include/nlohmann/detail/input/binary_reader.hpp

@@ -28,7 +28,6 @@
 #include <nlohmann/detail/input/input_adapters.hpp>
 #include <nlohmann/detail/input/json_sax.hpp>
 #include <nlohmann/detail/input/lexer.hpp>
-#include <nlohmann/detail/input/string_scan.hpp>
 #include <nlohmann/detail/macro_scope.hpp>
 #include <nlohmann/detail/meta/is_sax.hpp>
 #include <nlohmann/detail/meta/type_traits.hpp>
@@ -85,7 +84,7 @@ JSON_INLINE_VARIABLE constexpr std::size_t max_valueless_container_size = 1 << 2
 ///////////////////
 
 /*!
-@brief deserialization of BJData, BON8, BSON, CBOR, MessagePack, and UBJSON values
+@brief deserialization of CBOR, MessagePack, and UBJSON values
 */
 template<typename BasicJsonType, typename InputAdapterType, typename SAX = json_sax_dom_parser<BasicJsonType, InputAdapterType>>
 class binary_reader
@@ -99,11 +98,6 @@ class binary_reader
     using char_type = typename InputAdapterType::char_type;
     using char_int_type = typename char_traits<char_type>::int_type;
 
-    /// whether the input is a contiguous block of bytes that can be inspected
-    /// and consumed in bulk (as in the lexer); used by @ref get_bon8_string_bulk
-    static constexpr bool bulk_scan =
-        input_adapter_supports_bulk_scan<InputAdapterType>(is_detected<detect_supports_bulk_scan, InputAdapterType> {});
-
   public:
     /*!
     @brief create a binary reader
@@ -138,7 +132,6 @@ class binary_reader
     {
         sax = sax_;
         container_stack.clear();
-        bon8_pushback_size = 0;
         bool result = false;
 
         switch (format)
@@ -160,10 +153,6 @@ class binary_reader
                 result = parse_ubjson_internal();
                 break;
 
-            case input_format_t::bon8:
-                result = parse_bon8_internal();
-                break;
-
             case input_format_t::json: // LCOV_EXCL_LINE
             default:            // LCOV_EXCL_LINE
                 JSON_ASSERT(false); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert) LCOV_EXCL_LINE
@@ -176,11 +165,6 @@ class binary_reader
             {
                 get_ignore_noop();
             }
-            else if (input_format == input_format_t::bon8)
-            {
-                // a string that ends a container hands back the byte after it
-                get_bon8();
-            }
             else
             {
                 get();
@@ -412,11 +396,6 @@ class binary_reader
     */
     bool get_bson_cstr(string_t& result)
     {
-        if (get_bson_cstr_bulk(result, std::integral_constant<bool, bulk_scan> {}))
-        {
-            return true;
-        }
-
         auto out = std::back_inserter(result);
         while (true)
         {
@@ -433,46 +412,6 @@ class binary_reader
         }
     }
 
-    /*!
-    @brief read a C-style string from contiguous input in one step
-
-    @param[in,out] result  the string to append to
-    @return whether the string was read; if the input has no \x00-byte, nothing
-            is read, and @ref get_bson_cstr reports the end of the input
-    */
-    bool get_bson_cstr_bulk(string_t& result, std::true_type /*bulk*/)
-    {
-        const std::size_t remaining = ia.bulk_remaining();
-        if (remaining == 0)
-        {
-            return false;
-        }
-        const auto* const data = reinterpret_cast<const unsigned char*>(ia.bulk_data());
-        // a plain loop rather than std::memchr: most keys are short (array
-        // indices are keys, too), and the call would cost more than it saves
-        std::size_t length = 0;
-        while (length < remaining && data[length] != 0x00)
-        {
-            ++length;
-        }
-        if (length == remaining)
-        {
-            return false;
-        }
-        result.append(reinterpret_cast<const typename string_t::value_type*>(data), length);
-        // consume the string and its \x00-byte, as the byte-wise path does
-        ia.bulk_skip(length + 1);
-        chars_read += length + 1;
-        current = 0x00;
-        return true;
-    }
-
-    /// input that is not contiguous: C-style strings are read byte by byte
-    bool get_bson_cstr_bulk(string_t& /*result*/, std::false_type /*bulk*/) const noexcept
-    {
-        return false;
-    }
-
     /*!
     @brief Parses a zero-terminated string of length @a len from the BSON
            input.
@@ -3260,549 +3199,6 @@ class binary_reader
         }
     }
 
-    //////////
-    // BON8 //
-    //////////
-
-    /*!
-    @brief get the next byte of a BON8 value
-
-    A BON8 string has no length prefix and no mandatory terminator: it ends at
-    the first byte that cannot continue it, which is already the first byte (or,
-    for an integer that begins with a UTF-8 lead byte, the first two bytes) of
-    whatever follows. The string reader hands those bytes back with
-    @ref unget_bon8, and every BON8 read goes through this function so that
-    they are seen again.
-
-    @return character read from the input
-    */
-    char_int_type get_bon8()
-    {
-        if (bon8_pushback_size != 0)
-        {
-            ++chars_read;
-            return current = bon8_pushback[--bon8_pushback_size];
-        }
-        return get();
-    }
-
-    /*!
-    @brief hand a byte back so that the next @ref get_bon8 returns it again
-
-    @param[in] c  the byte to hand back; bytes handed back are returned in
-                  reverse order
-    */
-    void unget_bon8(const char_int_type c)
-    {
-        // At most two bytes are ever handed back: a byte is only handed back
-        // right after it was read with get_bon8(), and the only place that
-        // hands back two bytes (a lead byte and the byte after it) read both
-        // of them in a row, which emptied the buffer first. This is an
-        // invariant of the reader rather than a property of the input, so
-        // an assertion suffices (the fuzzers are built with assertions).
-        JSON_ASSERT(bon8_pushback_size < bon8_pushback.size());
-        bon8_pushback[bon8_pushback_size++] = c;
-        --chars_read;
-    }
-
-    /*!
-    @param[in] c  a byte
-    @return whether @a c is a UTF-8 continuation byte (0x80..0xBF)
-    */
-    static constexpr bool is_bon8_continuation(const char_int_type c) noexcept
-    {
-        return 0x80 <= c && c <= 0xBF;
-    }
-
-    /*!
-    @brief report a parse error at the last read byte
-
-    @param[in] detail   a detailed error message
-    @param[in] context  further context information
-    @return false
-    */
-    bool bon8_error(const std::string& detail, const char* context)
-    {
-        auto last_token = get_token_string();
-        return sax->parse_error(chars_read, last_token, parse_error::create(112, chars_read,
-                                exception_message(input_format_t::bon8, concat(detail, ": 0x", last_token), context), nullptr));
-    }
-
-    /*!
-    @brief read a BON8 value and everything nested inside it
-
-    Reads values until the one that was begun here is complete, resuming the
-    enclosing container after each element, so that the nesting depth of the
-    input costs heap rather than native stack (see #5104).
-
-    @return whether reading the value succeeded
-    */
-    bool parse_bon8_internal()
-    {
-        // the key currently being read; hoisted out of the loop so that its
-        // capacity is reused across elements and across nesting levels
-        string_t key;
-
-        while (true)
-        {
-            if (!container_stack.empty())
-            {
-                // a copy, not a reference: it must stay valid across the
-                // pop_back() below, which destroys the container_stack element
-                // it would otherwise alias
-                const container_frame top = container_stack.back();
-                bool at_end = false;
-
-                if (top.remaining != npos)
-                {
-                    // counted container (0x80..0x84, 0x86..0x8A): it ends once
-                    // its elements have been read
-                    at_end = (top.remaining == 0);
-                    if (!at_end)
-                    {
-                        // claim the element about to be read
-                        --container_stack.back().remaining;
-                    }
-                }
-                else
-                {
-                    // container 0x85 or 0x8B: it ends at an end-of-container
-                    // marker (0xFE); any other byte begins the next element
-                    at_end = (get_bon8() == 0xFE);
-                    if (!at_end)
-                    {
-                        unget_bon8(current);
-                    }
-                }
-
-                if (at_end)
-                {
-                    container_stack.pop_back();
-                    if (JSON_HEDLEY_UNLIKELY(top.is_object ? !sax->end_object() : !sax->end_array()))
-                    {
-                        return false;
-                    }
-                    // the value begun here is complete once its container is
-                    if (container_stack.empty())
-                    {
-                        return true;
-                    }
-                    continue;
-                }
-
-                if (top.is_object)
-                {
-                    key.clear();
-                    if (JSON_HEDLEY_UNLIKELY(!get_bon8_key(key) || !sax->key(key)))
-                    {
-                        return false;
-                    }
-                }
-            }
-
-            if (JSON_HEDLEY_UNLIKELY(!parse_bon8_value()))
-            {
-                return false;
-            }
-
-            // a value that opened a container left it on the stack; one that
-            // did not, and that was not inside a container, was the whole value
-            if (container_stack.empty())
-            {
-                return true;
-            }
-        }
-    }
-
-    /*!
-    @brief read one BON8 value
-
-    Reads a single value and passes it to the SAX parser. A value that begins
-    a container is not read to its end: the container is opened with
-    @ref enter_container and its elements are read by
-    @ref parse_bon8_internal, so that nesting does not consume native stack.
-
-    @return whether reading the value succeeded
-    */
-    bool parse_bon8_value()
-    {
-        const auto byte = get_bon8();
-
-        if (byte == char_traits<char_type>::eof())
-        {
-            return unexpect_eof(input_format_t::bon8, "value");
-        }
-
-        // string: ASCII character
-        if (byte <= 0x7F)
-        {
-            string_t s;
-            unget_bon8(byte);
-            return get_bon8_string(s) && sax->string(s);
-        }
-
-        // array with 0..4 elements
-        if (byte <= 0x84)
-        {
-            return enter_array(static_cast<std::size_t>(byte - 0x80));
-        }
-
-        // array terminated by 0xFE
-        if (byte == 0x85)
-        {
-            return enter_array(npos);
-        }
-
-        // object with 0..4 members
-        if (byte <= 0x8A)
-        {
-            return enter_object(static_cast<std::size_t>(byte - 0x86));
-        }
-
-        switch (byte)
-        {
-            case 0x8B: // object terminated by 0xFE
-                return enter_object(npos);
-
-            case 0x8C: // int32
-            {
-                std::int32_t number{};
-                return get_number(input_format_t::bon8, number) && emit_bon8_integer(number);
-            }
-
-            case 0x8D: // int64
-            {
-                std::int64_t number{};
-                return get_number(input_format_t::bon8, number) && emit_bon8_integer(number);
-            }
-
-            case 0x8E: // binary32
-            {
-                float number{};
-                return get_number(input_format_t::bon8, number) && sax->number_float(static_cast<number_float_t>(number), "");
-            }
-
-            case 0x8F: // binary64
-            {
-                double number{};
-                return get_number(input_format_t::bon8, number) && sax->number_float(static_cast<number_float_t>(number), "");
-            }
-
-            case 0xF8:
-                return sax->boolean(false);
-
-            case 0xF9:
-                return sax->boolean(true);
-
-            case 0xFA:
-                return sax->null();
-
-            case 0xFB:
-                return sax->number_float(static_cast<number_float_t>(-1.0), "");
-
-            case 0xFC:
-                return sax->number_float(static_cast<number_float_t>(0.0), "");
-
-            case 0xFD:
-                return sax->number_float(static_cast<number_float_t>(1.0), "");
-
-            case 0xFF: // empty string
-            {
-                string_t s;
-                return sax->string(s);
-            }
-
-            default:
-                break;
-        }
-
-        // integer 0..39
-        if (byte <= 0xB7)
-        {
-            return sax->number_unsigned(static_cast<number_unsigned_t>(byte - 0x90));
-        }
-
-        // integer -1..-10
-        if (byte <= 0xC1)
-        {
-            return sax->number_integer(-1 - static_cast<number_integer_t>(byte - 0xB8));
-        }
-
-        // 0xC2..0xF7: a UTF-8 lead byte begins a string if a continuation
-        // byte follows and an integer otherwise
-        if (byte <= 0xF7)
-        {
-            const auto second = get_bon8();
-            if (is_bon8_continuation(second))
-            {
-                string_t s;
-                unget_bon8(second);
-                unget_bon8(byte);
-                return get_bon8_string(s) && sax->string(s);
-            }
-            return get_bon8_integer(byte, second);
-        }
-
-        // 0xFE: end of container where a value is expected
-        return bon8_error("invalid byte", "value");
-    }
-
-    /*!
-    @brief pass an integer to the SAX parser
-
-    Non-negative integers are passed as unsigned, negative integers as signed
-    numbers, like the other binary formats do.
-
-    @param[in] number  the integer
-    @return whether the SAX parser accepted the value
-    */
-    bool emit_bon8_integer(const std::int64_t number)
-    {
-        if (number >= 0)
-        {
-            return sax->number_unsigned(static_cast<number_unsigned_t>(number));
-        }
-        return sax->number_integer(static_cast<number_integer_t>(number));
-    }
-
-    /*!
-    @brief read an integer encoded in 2..4 bytes
-
-    The first byte is a UTF-8 lead byte (0xC2..0xF7) that is followed by a
-    byte that is not a continuation byte: 0x00..0x7F for positive and
-    0xC0..0xFF for negative integers. The lead byte's low bits and the second
-    byte's low 7 (positive) or 6 (negative) bits are the most significant bits
-    of the value; 3- and 4-byte integers add one or two full bytes. Each range
-    starts where the shorter one ends, so no value has two encodings of the
-    same length.
-
-    @param[in] lead    the first byte (0xC2..0xF7)
-    @param[in] second  the second byte
-    @return whether reading the integer succeeded
-    */
-    bool get_bon8_integer(const char_int_type lead, const char_int_type second)
-    {
-        if (JSON_HEDLEY_UNLIKELY(!unexpect_eof(input_format_t::bon8, "number")))
-        {
-            return false;
-        }
-
-        const bool negative = second >= 0xC0;
-        auto value = static_cast<std::int64_t>(negative ? (second & 0x3F) : second);
-        std::int64_t offset = 0;
-        int extra_bytes = 0;
-
-        if (lead <= 0xDF)
-        {
-            value |= static_cast<std::int64_t>(lead - 0xC2) << (negative ? 6 : 7);
-            offset = negative ? 11 : 40;
-        }
-        else if (lead <= 0xEF)
-        {
-            value |= static_cast<std::int64_t>(lead & 0x0F) << (negative ? 6 : 7);
-            offset = negative ? 1931 : 3880;
-            extra_bytes = 1;
-        }
-        else
-        {
-            value |= static_cast<std::int64_t>(lead & 0x07) << (negative ? 6 : 7);
-            offset = negative ? 264075 : 528168;
-            extra_bytes = 2;
-        }
-
-        for (int i = 0; i < extra_bytes; ++i)
-        {
-            if (JSON_HEDLEY_UNLIKELY(get_bon8() == char_traits<char_type>::eof()))
-            {
-                return unexpect_eof(input_format_t::bon8, "number");
-            }
-            value = (value << 8) | static_cast<std::int64_t>(current);
-        }
-
-        return negative ? sax->number_integer(static_cast<number_integer_t>(-(value + offset)))
-               : sax->number_unsigned(static_cast<number_unsigned_t>(value + offset));
-    }
-
-    /*!
-    @brief read an object key
-
-    A key must be a string, so its first byte must be an ASCII character, a
-    UTF-8 lead byte followed by a continuation byte, or 0xFF (empty string).
-
-    @param[out] result  the key
-    @return whether reading the key succeeded
-    */
-    bool get_bon8_key(string_t& result)
-    {
-        const auto byte = get_bon8();
-
-        if (byte == char_traits<char_type>::eof())
-        {
-            return unexpect_eof(input_format_t::bon8, "key");
-        }
-
-        if (byte == 0xFF)
-        {
-            return true;
-        }
-
-        if (byte <= 0x7F)
-        {
-            unget_bon8(byte);
-            return get_bon8_string(result);
-        }
-
-        if (0xC2 <= byte && byte <= 0xF7)
-        {
-            const auto second = get_bon8();
-            unget_bon8(second);
-            if (is_bon8_continuation(second))
-            {
-                unget_bon8(byte);
-                return get_bon8_string(result);
-            }
-            // an integer: report its first byte rather than the one after it
-            current = byte;
-        }
-
-        return bon8_error("expected a string; last byte", "key");
-    }
-
-    /*!
-    @brief append the run of valid UTF-8 at the read position to a string
-
-    For contiguous input, the ASCII characters and complete well-formed UTF-8
-    sequences at the read position are appended to @a result in one step. The
-    byte that stops the run (an end-of-string marker, the first byte of the
-    next value, or an ill-formed byte) is left for @ref get_bon8_string, so
-    that strings end and errors are reported exactly as without this step.
-
-    @param[in,out] result  the string to append to
-    */
-    void get_bon8_string_bulk(string_t& result, std::true_type /*bulk*/)
-    {
-        // bytes handed back must be read through get_bon8() first
-        if (bon8_pushback_size != 0)
-        {
-            return;
-        }
-        const std::size_t remaining = ia.bulk_remaining();
-        if (remaining == 0)
-        {
-            return;
-        }
-        const auto* const data = reinterpret_cast<const unsigned char*>(ia.bulk_data());
-        const std::size_t length = valid_utf8_prefix(data, remaining);
-        if (length != 0)
-        {
-            result.append(reinterpret_cast<const typename string_t::value_type*>(data), length);
-            ia.bulk_skip(length);
-            chars_read += length;
-        }
-    }
-
-    /// input that is not contiguous: strings are read byte by byte
-    void get_bon8_string_bulk(string_t& /*result*/, std::false_type /*bulk*/) const noexcept {}
-
-    /*!
-    @brief read a string
-
-    Reads UTF-8 characters until an end-of-string marker (0xFF), which is
-    consumed, or a byte that cannot continue the string, which is handed back
-    to be read as the start of the next value. The string must be valid UTF-8,
-    and it must not end at the end of the input: the last string of a message
-    is always terminated by 0xFF.
-
-    @param[out] result  the string
-    @return whether reading the string succeeded
-    */
-    bool get_bon8_string(string_t& result)
-    {
-        while (true)
-        {
-            get_bon8_string_bulk(result, std::integral_constant<bool, bulk_scan> {});
-
-            const auto byte = get_bon8();
-
-            if (byte == char_traits<char_type>::eof())
-            {
-                return unexpect_eof(input_format_t::bon8, "string");
-            }
-
-            // end of string
-            if (byte == 0xFF)
-            {
-                return true;
-            }
-
-            // ASCII character
-            if (byte <= 0x7F)
-            {
-                result.push_back(static_cast<typename string_t::value_type>(byte));
-                continue;
-            }
-
-            // a byte that cannot begin a character ends the string and begins
-            // the next value
-            if (byte < 0xC2 || byte > 0xF7)
-            {
-                unget_bon8(byte);
-                return true;
-            }
-
-            // a lead byte ends the string if no continuation byte follows: it
-            // is then the first byte of an integer
-            const auto second = get_bon8();
-            if (!is_bon8_continuation(second))
-            {
-                unget_bon8(second);
-                unget_bon8(byte);
-                return true;
-            }
-
-            // the valid range of the second byte excludes overlong forms,
-            // surrogates, and code points above U+10FFFF
-            // (RFC 3629, section 4)
-            int continuation_bytes = 0;
-            bool valid_second = true;
-            if (byte <= 0xDF)
-            {
-                continuation_bytes = 1;
-            }
-            else if (byte <= 0xEF)
-            {
-                continuation_bytes = 2;
-                valid_second = (byte != 0xE0 || second >= 0xA0) && (byte != 0xED || second <= 0x9F);
-            }
-            else
-            {
-                continuation_bytes = 3;
-                valid_second = byte <= 0xF4 && (byte != 0xF0 || second >= 0x90) && (byte != 0xF4 || second <= 0x8F);
-            }
-
-            if (JSON_HEDLEY_UNLIKELY(!valid_second))
-            {
-                return bon8_error("invalid UTF-8 byte", "string");
-            }
-
-            result.push_back(static_cast<typename string_t::value_type>(byte));
-            result.push_back(static_cast<typename string_t::value_type>(second));
-
-            for (int i = 1; i < continuation_bytes; ++i)
-            {
-                if (JSON_HEDLEY_UNLIKELY(get_bon8() == char_traits<char_type>::eof()))
-                {
-                    return unexpect_eof(input_format_t::bon8, "string");
-                }
-                if (JSON_HEDLEY_UNLIKELY(!is_bon8_continuation(current)))
-                {
-                    return bon8_error("invalid UTF-8 byte", "string");
-                }
-                result.push_back(static_cast<typename string_t::value_type>(current));
-            }
-        }
-    }
-
     ///////////////////////
     // Utility functions //
     ///////////////////////
@@ -4101,10 +3497,6 @@ class binary_reader
                 error_msg += "BJData";
                 break;
 
-            case input_format_t::bon8:
-                error_msg += "BON8";
-                break;
-
             case input_format_t::json: // LCOV_EXCL_LINE
             default:            // LCOV_EXCL_LINE
                 JSON_ASSERT(false); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert) LCOV_EXCL_LINE
@@ -4137,11 +3529,6 @@ class binary_reader
     /// the containers that have been opened and not closed yet; see @ref container_frame
     std::vector<container_frame> container_stack{};
 
-    /// BON8: bytes read past the end of a string, returned again by @ref get_bon8
-    std::array<char_int_type, 2> bon8_pushback{{}};
-    /// BON8: number of bytes in @ref bon8_pushback
-    std::size_t bon8_pushback_size = 0;
-
     // excluded markers in bjdata optimized type
 #define JSON_BINARY_READER_MAKE_BJD_OPTIMIZED_TYPE_MARKERS_ \
     make_array<char_int_type>('F', 'H', 'N', 'S', 'T', 'Z', '[', '{')

include/nlohmann/detail/input/input_adapters.hpp

@@ -34,7 +34,7 @@ namespace detail
 {
 
 /// the supported input formats
-enum class input_format_t { json, cbor, msgpack, ubjson, bson, bjdata, bon8 };
+enum class input_format_t { json, cbor, msgpack, ubjson, bson, bjdata };
 
 ////////////////////
 // input adapters //

include/nlohmann/detail/input/lexer.hpp

@@ -206,6 +206,7 @@ class lexer : public lexer_base<BasicJsonType>
     explicit lexer(InputAdapterType&& adapter, bool ignore_comments_ = false, bool discard_number_values_ = false) noexcept
         : ia(std::move(adapter))
         , ignore_comments(ignore_comments_)
+        , decimal_point_char(static_cast<char_int_type>(get_decimal_point()))
         , discard_number_values(discard_number_values_)
     {}
 
@@ -221,7 +222,8 @@ class lexer : public lexer_base<BasicJsonType>
     // locales
     /////////////////////
 
-    /// return the decimal point of the current locale
+    /// return the locale-dependent decimal point
+    JSON_HEDLEY_PURE
     static char get_decimal_point() noexcept
     {
         const auto* loc = localeconv();
@@ -1090,10 +1092,9 @@ class lexer : public lexer_base<BasicJsonType>
             token_type::value_float if number could be successfully scanned,
             token_type::parse_error otherwise
 
-    @note The scanner is independent of the current locale: token_buffer
-          always holds `.`. Only the std::strtod fallback of convert_number()
-          depends on the locale, and it looks up the decimal point right
-          before converting (see convert_float_locale_aware()).
+    @note The scanner is independent of the current locale. Internally, the
+          locale's decimal point is used instead of `.` to work with the
+          locale-dependent converters.
     */
     token_type scan_number()  // lgtm [cpp/use-of-goto] `goto` is used in this function to implement the number-parsing state machine described above. By design, any finite input will eventually reach the "done" state or return token_type::parse_error. In each intermediate state, 1 byte of the input is appended to the token_buffer vector, and only the already initialized variables token_buffer, number_type, and error_message are manipulated.
     {
@@ -1182,7 +1183,7 @@ scan_number_zero:
         {
             case '.':
             {
-                add(current);
+                add(decimal_point_char);
                 decimal_point_position = token_buffer.size() - 1;
                 goto scan_number_decimal1;
             }
@@ -1219,7 +1220,7 @@ scan_number_any1:
 
             case '.':
             {
-                add(current);
+                add(decimal_point_char);
                 decimal_point_position = token_buffer.size() - 1;
                 goto scan_number_decimal1;
             }
@@ -1461,9 +1462,9 @@ scan_number_done:
 
         // Only a number below 1 can carry further insignificant zeros, and only
         // while the count stays at the limit does removing them change the
-        // answer - so this loop is skipped for all but a few tokens. The
-        // fraction is located through decimal_point_position rather than by
-        // searching '.'.
+        // answer - so this loop is skipped for all but a few tokens. Note
+        // token_buffer holds the locale's decimal point, so the fraction is
+        // located through decimal_point_position rather than by searching '.'.
         if (lead_zero != 0)
         {
             JSON_ASSERT(has_dot != 0); // an integer "0" cannot reach the limit
@@ -1481,8 +1482,8 @@ scan_number_done:
     @brief convert the number text in token_buffer to its value and token type
 
     The digit sequence in token_buffer has already been validated (by the
-    scan_number() state machine or by the contiguous fast path) and holds '.'
-    as decimal point, independent of the locale. Integers are parsed first and fall
+    scan_number() state machine or by the contiguous fast path) and holds the
+    locale decimal point in place of '.'. Integers are parsed first and fall
     back to floating point on overflow. This is shared so both scanners produce
     identical results.
 
@@ -1562,7 +1563,7 @@ scan_number_done:
         // integer conversion above overflowed. Prefer std::from_chars
         // (Eisel-Lemire, locale-independent, correctly rounded) when available;
         // otherwise the exact Clinger fast path (double only); otherwise the
-        // locale-aware strtof/strtod/strtold.
+        // locale-aware strtof/strtod.
         if (parse_float_from_chars(num_begin, num_end, value_float))
         {
             return token_type::value_float;
@@ -1571,75 +1572,26 @@ scan_number_done:
         // extra pass over the token's bytes, which otherwise shows up on
         // high-precision inputs such as canada.json
         if (mantissa_fits_clinger(mantissa_end)
-                && parse_float_fast(num_begin, num_end, value_float))
+                && parse_float_fast(num_begin, num_end, decimal_point_char, value_float))
         {
             return token_type::value_float;
         }
 
-        convert_float_locale_aware();
+        char* endptr = nullptr; // NOLINT(misc-const-correctness,cppcoreguidelines-pro-type-vararg,hicpp-vararg)
+        strtof(value_float, token_buffer.data(), &endptr);
+
+        // we checked the number format before
+        JSON_ASSERT(endptr == token_buffer.data() + token_buffer.size());
+
         return token_type::value_float;
     }
 
-    /*!
-    @brief convert the float in token_buffer with strtof/strtod/strtold
-
-    These functions expect the decimal point of the *current* locale, so it is
-    looked up right before the conversion instead of once when the lexer is
-    constructed: a locale change in between (by a parser callback, a SAX
-    handler, or another thread) must not truncate the value (#5198). The
-    token has been validated before, so if the conversion stops early and the
-    decimal point changed in the meantime, the locale changed between the
-    lookup and the call, and the conversion is repeated with the new decimal
-    point. If the decimal point did not change, a retry cannot succeed: the
-    locale's decimal point is not a single character (e.g., the two-byte
-    U+066B of ar_EG.UTF-8 or fa_IR.UTF-8) and cannot be substituted in place.
-    The value strtod parsed up to that point is kept, as before this change.
-
-    Note that changing the locale in another thread *while* strtod runs is
-    undefined behavior of the C library, which this function cannot prevent.
-    */
-    void convert_float_locale_aware()
-    {
-        const bool has_dot = decimal_point_position != std::string::npos;
-        char decimal_point = get_decimal_point();
-        for (;;)
-        {
-            const bool substitute = has_dot && decimal_point != '.';
-            if (substitute)
-            {
-                token_buffer[decimal_point_position] = static_cast<typename string_t::value_type>(decimal_point);
-            }
-
-            char* endptr = nullptr; // NOLINT(misc-const-correctness,cppcoreguidelines-pro-type-vararg,hicpp-vararg)
-            strtof(value_float, token_buffer.data(), &endptr);
-
-            if (substitute)
-            {
-                // get_string() hands the token to the SAX interface with '.'
-                token_buffer[decimal_point_position] = '.';
-            }
-
-            if (JSON_HEDLEY_LIKELY(endptr == token_buffer.data() + token_buffer.size()))
-            {
-                return;
-            }
-
-            // retry only if the locale changed; otherwise, this would loop forever
-            const char current_decimal_point = get_decimal_point();
-            if (current_decimal_point == decimal_point)
-            {
-                return;
-            }
-            decimal_point = current_decimal_point;
-        }
-    }
-
     /*!
     @brief contiguous fast path for scanning a number
 
     Parses the whole number token straight from the input buffer, avoiding the
     per-character get()/add() of scan_number(). On success it fills token_buffer
-    (as scan_number() does) and
+    (with the locale decimal point substituted, as scan_number() does) and
     returns the token type. On anything it does not fully recognize as a
     well-formed number it makes no state change and returns
     token_type::uninitialized, so the caller falls back to scan_number(), which
@@ -1755,11 +1707,16 @@ scan_number_done:
         }
 #endif
 
-        // materialize the token exactly as scan_number() would. reset() already
-        // cleared token_buffer, so append() fills it (assign() is avoided
-        // because custom string_t types need not provide it)
+        // materialize the token exactly as scan_number() would, substituting the
+        // locale decimal point so convert_number()'s strtof fallback stays valid.
+        // reset() already cleared token_buffer, so append() fills it (assign() is
+        // avoided because custom string_t types need not provide it)
         token_buffer.append(reinterpret_cast<const typename string_t::value_type*>(data), len);
-        decimal_point_position = dot_index;
+        if (dot_index != std::string::npos)
+        {
+            token_buffer[dot_index] = static_cast<typename string_t::value_type>(decimal_point_char);
+            decimal_point_position = dot_index;
+        }
 
         ia.bulk_skip(len - 1);
         position.chars_read_total += (len - 1);
@@ -2026,7 +1983,11 @@ scan_number_done:
     /// return current string value (implicitly resets the token; useful only once)
     string_t& get_string()
     {
-        // a number token holds '.' regardless of the locale (#4084)
+        // translate decimal points from locale back to '.' (#4084)
+        if (decimal_point_char != '.' && decimal_point_position != std::string::npos)
+        {
+            token_buffer[decimal_point_position] = '.';
+        }
         return token_buffer;
     }
 
@@ -2322,7 +2283,9 @@ scan_number_done:
     number_unsigned_t value_unsigned = 0;
     number_float_t value_float = 0;
 
-    /// the position of the decimal point in token_buffer
+    /// the decimal point
+    const char_int_type decimal_point_char = '.';
+    /// the position of the decimal point in the input
     std::size_t decimal_point_position = std::string::npos;
 
     /// whether the caller (e.g. accept()/json_sax_acceptor) only needs the

include/nlohmann/detail/input/number_parse.hpp

@@ -118,12 +118,14 @@ std::strtod. The parser only activates for number_float_t == double; float and
 long double keep the std::strtof/std::strtold paths (see the templated overload
 below).
 
-@param[in]  first  pointer to the first character of the number
-@param[in]  last   pointer past the last character
-@param[out] out    the parsed value on success
+@param[in]  first          pointer to the first character of the number
+@param[in]  last           pointer past the last character
+@param[in]  decimal_point  the (locale-dependent) decimal point character
+@param[out] out            the parsed value on success
 @return true if the value was parsed exactly; false to fall back to strtod
 */
-inline bool parse_float_fast(const char* first, const char* last, double& out) noexcept
+template<typename DecimalPointType>
+bool parse_float_fast(const char* first, const char* last, DecimalPointType decimal_point, double& out) noexcept
 {
 #if defined(FLT_EVAL_METHOD) && FLT_EVAL_METHOD != 0
     // Clinger's fast path is only exact when double operations are evaluated in
@@ -134,6 +136,7 @@ inline bool parse_float_fast(const char* first, const char* last, double& out) n
     // std::from_chars / std::strtod path.
     static_cast<void>(first);
     static_cast<void>(last);
+    static_cast<void>(decimal_point);
     static_cast<void>(out);
     return false;
 #else
@@ -172,7 +175,7 @@ inline bool parse_float_fast(const char* first, const char* last, double& out) n
             ++num_digits;
             fractional_digits += static_cast<int>(seen_dot);
         }
-        else if (c == '.')
+        else if (static_cast<DecimalPointType>(c) == decimal_point)
         {
             if (JSON_HEDLEY_UNLIKELY(seen_dot))
             {
@@ -257,8 +260,8 @@ inline bool parse_float_fast(const char* first, const char* last, double& out) n
 }
 
 /// fast float path is only exact for `double`; decline for float/long double
-template<typename FloatType>
-bool parse_float_fast(const char* /*first*/, const char* /*last*/, FloatType& /*out*/) noexcept
+template<typename DecimalPointType, typename FloatType>
+bool parse_float_fast(const char* /*first*/, const char* /*last*/, DecimalPointType /*decimal_point*/, FloatType& /*out*/) noexcept
 {
     return false;
 }
@@ -270,7 +273,9 @@ std::from_chars is locale-independent, correctly rounded, and - via the
 Eisel-Lemire algorithm in modern standard libraries - much faster than strtod
 over the whole value range (not just the Clinger subset). It is used only when
 __cpp_lib_to_chars indicates full floating-point support and only when it
-consumes the entire token ([first, last)). An under-/overflow (result_out_of_range) also declines, so
+consumes the entire token ([first, last)); a partial parse means the buffer
+uses a non-'.' locale decimal point, in which case the caller falls back to the
+locale-aware path. An under-/overflow (result_out_of_range) also declines, so
 the caller's strtod fallback supplies the well-defined ±inf/0 result the parser
 expects (side-stepping the P4168 divergence between implementations).
 

include/nlohmann/detail/input/string_scan.hpp

@@ -201,43 +201,6 @@ inline std::size_t validate_one_utf8(const unsigned char* data, std::size_t avai
     return 0; // invalid, incomplete, or must be diagnosed by the byte path
 }
 
-// Return the length of the longest prefix of [data, data+n) that consists of
-// ASCII characters and complete well-formed UTF-8 sequences; n if all of it is
-// valid UTF-8. Unlike scalar_string_bulk_run(), quotes, escapes, and control
-// characters are ordinary characters here. ASCII is skipped 8 bytes at a time.
-inline std::size_t valid_utf8_prefix(const unsigned char* data, std::size_t n) noexcept
-{
-    constexpr std::uint64_t high = 0x8080808080808080ull;
-    std::size_t pos = 0;
-    while (pos < n)
-    {
-        if (pos + 8 <= n)
-        {
-            std::uint64_t word = 0;
-            std::memcpy(&word, data + pos, sizeof(word));
-            if ((word & high) == 0)
-            {
-                pos += 8;
-                continue;
-            }
-        }
-
-        if (data[pos] < 0x80u)
-        {
-            ++pos;
-            continue;
-        }
-
-        const std::size_t seq = validate_one_utf8(data + pos, n - pos);
-        if (seq == 0)
-        {
-            break; // ill-formed or truncated
-        }
-        pos += seq;
-    }
-    return pos;
-}
-
 // Scalar (C++11) computation of the bulk run length: the number of leading
 // bytes in [data, data+n) that are ordinary ASCII or complete well-formed UTF-8
 // sequences, stopping before the first byte that needs individual handling (the

include/nlohmann/detail/output/binary_writer.hpp

@@ -25,7 +25,6 @@
 #endif
 
 #include <nlohmann/detail/input/binary_reader.hpp>
-#include <nlohmann/detail/input/string_scan.hpp>
 #include <nlohmann/detail/macro_scope.hpp>
 #include <nlohmann/detail/output/output_adapters.hpp>
 #include <nlohmann/detail/string_concat.hpp>
@@ -77,7 +76,7 @@ std::size_t binary_reserve_hint(const BasicJsonType& j)
 }
 
 /*!
-@brief serialization to BJData, BON8, BSON, CBOR, MessagePack, and UBJSON values
+@brief serialization to CBOR and MessagePack values
 */
 template<typename BasicJsonType, typename CharType, typename OutputSinkType = output_adapter_sink<CharType>>
 class binary_writer
@@ -874,21 +873,6 @@ class binary_writer
         }
     }
 
-    /*!
-    @param[in] j  JSON value to serialize
-    */
-    void write_bon8(const BasicJsonType& j)
-    {
-        bool string_open = false;
-        write_bon8_value(j, string_open);
-
-        // the last string of a message must be terminated
-        if (string_open)
-        {
-            oa.write_character(to_char_type(0xFF));
-        }
-    }
-
   private:
     //////////
     // BSON //
@@ -1447,28 +1431,6 @@ class binary_writer
         return to_char_type(0xCB);  // float 64
     }
 
-    /// @return the BON8 type marker for binary32 (float) or binary64 (double)
-    template<typename FloatType>
-    static constexpr CharType get_bon8_float_prefix()
-    {
-        return to_char_type(std::is_same<FloatType, float>::value ? 0x8E : 0x8F);
-    }
-
-    /// @return the type marker for a FloatType value in @a format (CBOR, MessagePack, or BON8)
-    template<typename FloatType>
-    static CharType get_compact_float_prefix(const detail::input_format_t format)
-    {
-        if (format == detail::input_format_t::cbor)
-        {
-            return get_cbor_float_prefix(FloatType{});
-        }
-        if (format == detail::input_format_t::bon8)
-        {
-            return get_bon8_float_prefix<FloatType>();
-        }
-        return get_msgpack_float_prefix(FloatType{});
-    }
-
     ////////////
     // UBJSON //
     ////////////
@@ -2088,322 +2050,6 @@ class binary_writer
         return false;
     }
 
-    //////////
-    // BON8 //
-    //////////
-
-    /*!
-    @brief write a BON8 value
-
-    A string is written without length or terminator: it ends at the first
-    byte that cannot continue it, which is the first byte of any non-string
-    value and of the end-of-container marker 0xFE. It only needs an explicit
-    end-of-string marker (0xFF) when it is empty, when another string follows,
-    or when it is the last thing in the message.
-
-    @param[in] j                JSON value to serialize
-    @param[in,out] string_open  whether the output ends with a non-empty
-                                string that has not been terminated with 0xFF
-    */
-    void write_bon8_value(const BasicJsonType& j, bool& string_open)
-    {
-        switch (j.type())
-        {
-            case value_t::null:
-            {
-                write_bon8_marker(0xFA, string_open);
-                break;
-            }
-
-            case value_t::boolean:
-            {
-                write_bon8_marker(j.m_data.m_value.boolean ? 0xF9 : 0xF8, string_open);
-                break;
-            }
-
-            case value_t::number_unsigned:
-            {
-                if (j.m_data.m_value.number_unsigned > static_cast<typename BasicJsonType::number_unsigned_t>((std::numeric_limits<std::int64_t>::max)()))
-                {
-                    JSON_THROW(out_of_range::create(407, concat("integer number ", std::to_string(j.m_data.m_value.number_unsigned), " cannot be represented by BON8 as it does not fit int64"), &j));
-                }
-                write_bon8_integer(static_cast<std::int64_t>(j.m_data.m_value.number_unsigned));
-                string_open = false;
-                break;
-            }
-
-            case value_t::number_integer:
-            {
-                write_bon8_integer(static_cast<std::int64_t>(j.m_data.m_value.number_integer));
-                string_open = false;
-                break;
-            }
-
-            case value_t::number_float:
-            {
-                write_bon8_float(j.m_data.m_value.number_float);
-                string_open = false;
-                break;
-            }
-
-            case value_t::string:
-            {
-                write_bon8_string(*j.m_data.m_value.string, string_open, j);
-                break;
-            }
-
-            case value_t::array:
-            {
-                const auto N = j.m_data.m_value.array->size();
-                // 0x80..0x84: array with 0..4 elements; 0x85: array ended by 0xFE
-                write_bon8_marker(static_cast<std::uint8_t>(N <= 4 ? 0x80 + N : 0x85), string_open);
-
-                for (const auto& el : *j.m_data.m_value.array)
-                {
-                    write_bon8_value(el, string_open);
-                }
-
-                if (N > 4)
-                {
-                    write_bon8_marker(0xFE, string_open);
-                }
-                break;
-            }
-
-            case value_t::object:
-            {
-                const auto N = j.m_data.m_value.object->size();
-                // 0x86..0x8A: object with 0..4 members; 0x8B: object ended by 0xFE
-                write_bon8_marker(static_cast<std::uint8_t>(N <= 4 ? 0x86 + N : 0x8B), string_open);
-
-                for (const auto& el : *j.m_data.m_value.object)
-                {
-                    write_bon8_string(el.first, string_open, j);
-                    write_bon8_value(el.second, string_open);
-                }
-
-                if (N > 4)
-                {
-                    write_bon8_marker(0xFE, string_open);
-                }
-                break;
-            }
-
-            case value_t::binary:
-            {
-                // BON8 has no binary type: write the bytes as an array of
-                // integers, like UBJSON and BJData do
-                const auto N = j.m_data.m_value.binary->size();
-                write_bon8_marker(static_cast<std::uint8_t>(N <= 4 ? 0x80 + N : 0x85), string_open);
-
-                for (std::size_t i = 0; i < N; ++i)
-                {
-                    // the cast is needed for binary types whose value type
-                    // is not an integer (e.g., std::byte)
-                    write_bon8_integer(static_cast<std::uint8_t>(j.m_data.m_value.binary->data()[i]));
-                }
-
-                if (N > 4)
-                {
-                    write_bon8_marker(0xFE, string_open);
-                }
-                break;
-            }
-
-            case value_t::discarded:
-            default:
-                break;
-        }
-    }
-
-    /*!
-    @brief write a single byte that is not part of a string
-
-    @param[in] marker        the byte to write
-    @param[out] string_open  set to false, because the output no longer ends
-                             with a string; see @ref write_bon8_value
-    */
-    void write_bon8_marker(const std::uint8_t marker, bool& string_open)
-    {
-        oa.write_character(to_char_type(marker));
-        string_open = false;
-    }
-
-    /*!
-    @brief write a string
-
-    @param[in] s                the string to write
-    @param[in,out] string_open  see @ref write_bon8_value
-    @param[in] context          the value the string belongs to (for diagnostics)
-
-    @throw type_error.316 if @a s is not valid UTF-8, because the end of a
-           string is determined from its encoding
-    */
-    void write_bon8_string(const string_t& s, bool& string_open, const BasicJsonType& context)
-    {
-        check_bon8_utf8(s, context);
-
-        // a string that follows another string terminates it
-        if (string_open)
-        {
-            oa.write_character(to_char_type(0xFF));
-        }
-
-        if (s.empty())
-        {
-            // the empty string is just the end-of-string marker
-            oa.write_character(to_char_type(0xFF));
-            string_open = false;
-        }
-        else
-        {
-            oa.write_characters(reinterpret_cast<const CharType*>(s.data()), s.size());
-            string_open = true;
-        }
-    }
-
-    /*!
-    @brief check that a string is valid UTF-8 (RFC 3629)
-
-    @param[in] s        the string to check
-    @param[in] context  the value the string belongs to (for diagnostics)
-
-    @throw type_error.316 if @a s is not valid UTF-8; the message names the
-           first byte of the first invalid or incomplete sequence
-    */
-    static void check_bon8_utf8(const string_t& s, const BasicJsonType& context)
-    {
-        static_cast<void>(context); // only used when exceptions are enabled
-        const auto* data = reinterpret_cast<const unsigned char*>(s.data());
-        const std::size_t valid = valid_utf8_prefix(data, s.size());
-        if (JSON_HEDLEY_UNLIKELY(valid != s.size()))
-        {
-            JSON_THROW(type_error::create(316, concat("invalid UTF-8 byte at index ", std::to_string(valid), ": 0x", hex_byte(data[valid])), &context));
-        }
-    }
-
-    /// @return a byte as two uppercase hexadecimal digits
-    static std::string hex_byte(const std::uint8_t byte)
-    {
-        std::string result = "00";
-        constexpr const char* nibble_to_hex = "0123456789ABCDEF";
-        result[0] = nibble_to_hex[byte / 16];
-        result[1] = nibble_to_hex[byte % 16];
-        return result;
-    }
-
-    /*!
-    @brief write an integer in the shortest encoding
-
-    Integers from -10 to 39 take one byte. Up to -33818506 and 67637031, an
-    integer takes 2 to 4 bytes that begin with a UTF-8 lead byte (0xC2..0xF7)
-    followed by a byte that is not a continuation byte: 0x00..0x7F for
-    positive and 0xC0..0xFF for negative integers. Each range starts where the
-    shorter one ends. Larger integers are written as int32 (0x8C) or int64
-    (0x8D) in big-endian byte order.
-
-    @param[in] value  the integer to write
-    */
-    void write_bon8_integer(std::int64_t value)
-    {
-        if (value < (std::numeric_limits<std::int32_t>::min)() || value > (std::numeric_limits<std::int32_t>::max)())
-        {
-            oa.write_character(to_char_type(0x8D));
-            write_number(value);
-        }
-        else if (value < -33818506 || value > 67637031)
-        {
-            oa.write_character(to_char_type(0x8C));
-            write_number(static_cast<std::int32_t>(value));
-        }
-        else if (value <= -264075)
-        {
-            value = -(value + 264075);
-            write_bon8_bytes(0xF0 + ((value >> 22) & 0x07), 0xC0 + ((value >> 16) & 0x3F), value >> 8, value);
-        }
-        else if (value <= -1931)
-        {
-            value = -(value + 1931);
-            write_bon8_bytes(0xE0 + ((value >> 14) & 0x0F), 0xC0 + ((value >> 8) & 0x3F), value);
-        }
-        else if (value <= -11)
-        {
-            value = -(value + 11);
-            write_bon8_bytes(0xC2 + ((value >> 6) & 0x1F), 0xC0 + (value & 0x3F));
-        }
-        else if (value <= -1)
-        {
-            write_bon8_bytes(0xB8 - (value + 1));
-        }
-        else if (value <= 39)
-        {
-            write_bon8_bytes(0x90 + value);
-        }
-        else if (value <= 3879)
-        {
-            value -= 40;
-            write_bon8_bytes(0xC2 + ((value >> 7) & 0x1F), value & 0x7F);
-        }
-        else if (value <= 528167)
-        {
-            value -= 3880;
-            write_bon8_bytes(0xE0 + ((value >> 15) & 0x0F), (value >> 8) & 0x7F, value);
-        }
-        else
-        {
-            value -= 528168;
-            write_bon8_bytes(0xF0 + ((value >> 23) & 0x07), (value >> 16) & 0x7F, value >> 8, value);
-        }
-    }
-
-    /// write the low byte of each argument
-    template<typename... Bytes>
-    void write_bon8_bytes(const Bytes... bytes)
-    {
-        const std::array<CharType, sizeof...(Bytes)> buffer{{to_char_type(static_cast<std::uint8_t>(bytes & 0xFF))...}};
-        oa.write_characters(buffer.data(), buffer.size());
-    }
-
-    /*!
-    @brief write a floating-point number
-
-    -1.0, +0.0, and 1.0 take one byte. Other numbers are written as binary32
-    (0x8E) if that loses no precision, and as binary64 (0x8F) otherwise; -0.0,
-    infinities, and NaN are always written as binary32, NaN as 0x7F800001.
-
-    @param[in] n  the number to write
-    */
-    void write_bon8_float(const number_float_t n)
-    {
-#ifdef __GNUC__
-        JSON_HEDLEY_DIAGNOSTIC_PUSH
-        JSON_HEDLEY_PRAGMA(GCC diagnostic ignored "-Wfloat-equal")
-#endif
-        if (n == static_cast<number_float_t>(-1))
-        {
-            oa.write_character(to_char_type(0xFB));
-        }
-        else if (n == static_cast<number_float_t>(0) && !std::signbit(n))
-        {
-            oa.write_character(to_char_type(0xFC));
-        }
-        else if (n == static_cast<number_float_t>(1))
-        {
-            oa.write_character(to_char_type(0xFD));
-        }
-        else if (std::isnan(n))
-        {
-            write_bon8_bytes(0x8E, 0x7F, 0x80, 0x00, 0x01);
-        }
-        else
-        {
-            write_compact_float(n, detail::input_format_t::bon8);
-        }
-#ifdef __GNUC__
-        JSON_HEDLEY_DIAGNOSTIC_POP
-#endif
-    }
-
     ///////////////////////
     // Utility functions //
     ///////////////////////
@@ -2538,12 +2184,16 @@ class binary_writer
                                    static_cast<double>(n) <= static_cast<double>((std::numeric_limits<float>::max)()) &&
                                    static_cast<double>(static_cast<float>(n)) == static_cast<double>(n))))
         {
-            oa.write_character(get_compact_float_prefix<float>(format));
+            oa.write_character(format == detail::input_format_t::cbor
+                               ? get_cbor_float_prefix(static_cast<float>(n))
+                               : get_msgpack_float_prefix(static_cast<float>(n)));
             write_number(static_cast<float>(n));
         }
         else
         {
-            oa.write_character(get_compact_float_prefix<number_float_t>(format));
+            oa.write_character(format == detail::input_format_t::cbor
+                               ? get_cbor_float_prefix(n)
+                               : get_msgpack_float_prefix(n));
             write_number(n);
         }
 #ifdef __GNUC__

include/nlohmann/json.hpp

@@ -5290,30 +5290,6 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec
         binary_writer<char>(o).write_bson(j);
     }
 
-    /// @brief create a BON8 serialization of a given JSON value
-    /// @sa https://json.nlohmann.me/api/basic_json/to_bon8/
-    static std::vector<std::uint8_t> to_bon8(const basic_json& j)
-    {
-        std::vector<std::uint8_t> result;
-        result.reserve(detail::binary_reserve_hint(j));
-        vector_writer(result).write_bon8(j);
-        return result;
-    }
-
-    /// @brief create a BON8 serialization of a given JSON value
-    /// @sa https://json.nlohmann.me/api/basic_json/to_bon8/
-    static void to_bon8(const basic_json& j, detail::output_adapter<std::uint8_t> o)
-    {
-        binary_writer<std::uint8_t>(o).write_bon8(j);
-    }
-
-    /// @brief create a BON8 serialization of a given JSON value
-    /// @sa https://json.nlohmann.me/api/basic_json/to_bon8/
-    static void to_bon8(const basic_json& j, detail::output_adapter<char> o)
-    {
-        binary_writer<char>(o).write_bon8(j);
-    }
-
     /// @brief create a JSON value from an input in CBOR format
     /// @sa https://json.nlohmann.me/api/basic_json/from_cbor/
     template<typename InputType>
@@ -5547,43 +5523,6 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec
         return result;
     }
 
-    /// @brief create a JSON value from an input in BON8 format
-    /// @sa https://json.nlohmann.me/api/basic_json/from_bon8/
-    template<typename InputType>
-    JSON_HEDLEY_WARN_UNUSED_RESULT
-    static basic_json from_bon8(InputType&& i,
-                                const bool strict = true,
-                                const bool allow_exceptions = true)
-    {
-        basic_json result;
-        auto ia = detail::input_adapter(std::forward<InputType>(i));
-        detail::json_sax_dom_parser<basic_json, decltype(ia)> sdp(result, allow_exceptions);
-        if (!binary_reader<decltype(ia)>(std::move(ia), input_format_t::bon8).sax_parse(input_format_t::bon8, &sdp, strict)) // cppcheck-suppress[accessMoved]
-        {
-            result = value_t::discarded;
-        }
-        return result;
-    }
-
-    /// @brief create a JSON value from an input in BON8 format (iterator pair, or iterator+sentinel pair for C++20 ranges support)
-    /// @sa https://json.nlohmann.me/api/basic_json/from_bon8/
-    template<typename IteratorType, typename SentinelType = IteratorType,
-             detail::enable_if_t<detail::can_compare_ne<IteratorType, SentinelType>::value, int> = 0>
-    JSON_HEDLEY_WARN_UNUSED_RESULT
-    static basic_json from_bon8(IteratorType first, SentinelType last,
-                                const bool strict = true,
-                                const bool allow_exceptions = true)
-    {
-        basic_json result;
-        auto ia = detail::input_adapter(std::move(first), std::move(last));
-        detail::json_sax_dom_parser<basic_json, decltype(ia)> sdp(result, allow_exceptions);
-        if (!binary_reader<decltype(ia)>(std::move(ia), input_format_t::bon8).sax_parse(input_format_t::bon8, &sdp, strict)) // cppcheck-suppress[accessMoved]
-        {
-            result = value_t::discarded;
-        }
-        return result;
-    }
-
     /// @brief create a JSON value from an input in BSON format
     /// @sa https://json.nlohmann.me/api/basic_json/from_bson/
     template<typename InputType>

tests/CMakeLists.txt

@@ -112,7 +112,7 @@ endif()
 
 if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
     # avoid stack overflow, see https://github.com/nlohmann/json/issues/2955
-    json_test_set_test_options("test-bon8;test-cbor;test-msgpack;test-ubjson;test-bjdata;test-binary_formats" LINK_OPTIONS /STACK:4000000)
+    json_test_set_test_options("test-cbor;test-msgpack;test-ubjson;test-bjdata;test-binary_formats" LINK_OPTIONS /STACK:4000000)
 endif()
 
 # disable exceptions for test-disabled_exceptions

tests/Makefile

@@ -10,7 +10,7 @@ CXXFLAGS += -std=c++11
 CPPFLAGS += -I ../single_include
 
 FUZZER_ENGINE = src/fuzzer-driver_afl.cpp
-FUZZERS = parse_afl_fuzzer parse_bson_fuzzer parse_cbor_fuzzer parse_msgpack_fuzzer parse_ubjson_fuzzer parse_bjdata_fuzzer parse_bon8_fuzzer
+FUZZERS = parse_afl_fuzzer parse_bson_fuzzer parse_cbor_fuzzer parse_msgpack_fuzzer parse_ubjson_fuzzer parse_bjdata_fuzzer
 fuzzers: $(FUZZERS)
 
 parse_afl_fuzzer:
@@ -30,6 +30,3 @@ parse_ubjson_fuzzer:
 
 parse_bjdata_fuzzer:
 	$(CXX) $(CXXFLAGS) $(CPPFLAGS) $(FUZZER_ENGINE) src/fuzzer-parse_bjdata.cpp -o $@
-
-parse_bon8_fuzzer:
-	$(CXX) $(CXXFLAGS) $(CPPFLAGS) $(FUZZER_ENGINE) src/fuzzer-parse_bon8.cpp -o $@

tests/benchmarks/src/benchmarks.cpp

@@ -274,8 +274,7 @@ enum class binary_format
     ubjson_optimized,
     bjdata,
     bjdata_optimized,
-    bson,
-    bon8
+    bson
 };
 
 static std::vector<std::uint8_t> to_binary(const json& j, const binary_format format)
@@ -294,8 +293,6 @@ static std::vector<std::uint8_t> to_binary(const json& j, const binary_format fo
             return json::to_bjdata(j);
         case binary_format::bjdata_optimized:
             return json::to_bjdata(j, true, true);
-        case binary_format::bon8:
-            return json::to_bon8(j);
         case binary_format::bson:
         default:
             return json::to_bson(j);
@@ -316,8 +313,6 @@ static json from_binary(const std::vector<std::uint8_t>& bytes, const binary_for
         case binary_format::bjdata:
         case binary_format::bjdata_optimized:
             return json::from_bjdata(bytes);
-        case binary_format::bon8:
-            return json::from_bon8(bytes);
         case binary_format::bson:
         default:
             return json::from_bson(bytes);
@@ -338,8 +333,6 @@ static json from_binary(std::FILE* file, const binary_format format)
         case binary_format::bjdata:
         case binary_format::bjdata_optimized:
             return json::from_bjdata(file);
-        case binary_format::bon8:
-            return json::from_bon8(file);
         case binary_format::bson:
         default:
             return json::from_bson(file);
@@ -414,10 +407,6 @@ BENCHMARK_CAPTURE(FromBinaryBuffer, bjdata / canada, TEST_DATA_DIRECTORY "/nativ
 BENCHMARK_CAPTURE(FromBinaryBuffer, bjdata / twitter, TEST_DATA_DIRECTORY "/nativejson-benchmark/twitter.json", binary_format::bjdata);
 BENCHMARK_CAPTURE(FromBinaryBuffer, bjdata_optimized / canada, TEST_DATA_DIRECTORY "/nativejson-benchmark/canada.json", binary_format::bjdata_optimized);
 BENCHMARK_CAPTURE(FromBinaryBuffer, bjdata_optimized / twitter, TEST_DATA_DIRECTORY "/nativejson-benchmark/twitter.json", binary_format::bjdata_optimized);
-BENCHMARK_CAPTURE(FromBinaryBuffer, bon8 / jeopardy, TEST_DATA_DIRECTORY "/jeopardy/jeopardy.json", binary_format::bon8);
-BENCHMARK_CAPTURE(FromBinaryBuffer, bon8 / canada, TEST_DATA_DIRECTORY "/nativejson-benchmark/canada.json", binary_format::bon8);
-BENCHMARK_CAPTURE(FromBinaryBuffer, bon8 / citm_catalog, TEST_DATA_DIRECTORY "/nativejson-benchmark/citm_catalog.json", binary_format::bon8);
-BENCHMARK_CAPTURE(FromBinaryBuffer, bon8 / twitter, TEST_DATA_DIRECTORY "/nativejson-benchmark/twitter.json", binary_format::bon8);
 // BSON requires an object at the top level, so the array-rooted test files
 // (jeopardy and the regression files) cannot be captured here
 BENCHMARK_CAPTURE(FromBinaryBuffer, bson / canada, TEST_DATA_DIRECTORY "/nativejson-benchmark/canada.json", binary_format::bson);
@@ -461,8 +450,6 @@ BENCHMARK_CAPTURE(FromBinaryFile, cbor / twitter, TEST_DATA_DIRECTORY "/nativejs
 BENCHMARK_CAPTURE(FromBinaryFile, ubjson / canada, TEST_DATA_DIRECTORY "/nativejson-benchmark/canada.json", binary_format::ubjson);
 BENCHMARK_CAPTURE(FromBinaryFile, ubjson / twitter, TEST_DATA_DIRECTORY "/nativejson-benchmark/twitter.json", binary_format::ubjson);
 BENCHMARK_CAPTURE(FromBinaryFile, bjdata / twitter, TEST_DATA_DIRECTORY "/nativejson-benchmark/twitter.json", binary_format::bjdata);
-BENCHMARK_CAPTURE(FromBinaryFile, bon8 / canada, TEST_DATA_DIRECTORY "/nativejson-benchmark/canada.json", binary_format::bon8);
-BENCHMARK_CAPTURE(FromBinaryFile, bon8 / twitter, TEST_DATA_DIRECTORY "/nativejson-benchmark/twitter.json", binary_format::bon8);
 BENCHMARK_CAPTURE(FromBinaryFile, bson / twitter, TEST_DATA_DIRECTORY "/nativejson-benchmark/twitter.json", binary_format::bson);
 
 //////////////////////////////////////////////////////////////////////////////
@@ -543,21 +530,18 @@ BENCHMARK_CAPTURE(FromBinaryShape, nested / msgpack, make_nested, binary_format:
 BENCHMARK_CAPTURE(FromBinaryShape, nested / ubjson, make_nested, binary_format::ubjson);
 BENCHMARK_CAPTURE(FromBinaryShape, nested / bjdata, make_nested, binary_format::bjdata);
 BENCHMARK_CAPTURE(FromBinaryShape, nested / bson, make_nested, binary_format::bson);
-BENCHMARK_CAPTURE(FromBinaryShape, nested / bon8, make_nested, binary_format::bon8);
 BENCHMARK_CAPTURE(FromBinaryShape, containers / cbor, make_containers, binary_format::cbor);
 BENCHMARK_CAPTURE(FromBinaryShape, containers / msgpack, make_containers, binary_format::msgpack);
 BENCHMARK_CAPTURE(FromBinaryShape, containers / ubjson, make_containers, binary_format::ubjson);
 BENCHMARK_CAPTURE(FromBinaryShape, containers / ubjson_optimized, make_containers, binary_format::ubjson_optimized);
 BENCHMARK_CAPTURE(FromBinaryShape, containers / bjdata, make_containers, binary_format::bjdata);
 BENCHMARK_CAPTURE(FromBinaryShape, containers / bson, make_containers, binary_format::bson);
-BENCHMARK_CAPTURE(FromBinaryShape, containers / bon8, make_containers, binary_format::bon8);
 // BSON names every array element, so a large array measures key generation
 // rather than scalar decoding and is left out here
 BENCHMARK_CAPTURE(FromBinaryShape, scalars / cbor, make_scalars, binary_format::cbor);
 BENCHMARK_CAPTURE(FromBinaryShape, scalars / msgpack, make_scalars, binary_format::msgpack);
 BENCHMARK_CAPTURE(FromBinaryShape, scalars / ubjson, make_scalars, binary_format::ubjson);
 BENCHMARK_CAPTURE(FromBinaryShape, scalars / bjdata, make_scalars, binary_format::bjdata);
-BENCHMARK_CAPTURE(FromBinaryShape, scalars / bon8, make_scalars, binary_format::bon8);
 
 /*!
 @brief parse an indefinite-length CBOR string

tests/fuzzing.md

@@ -1,6 +1,6 @@
 # Fuzz testing
 
-Each parser of the library (JSON, BJData, BON8, BSON, CBOR, MessagePack, and UBJSON) can be fuzz tested. Currently,
+Each parser of the library (JSON, BJData, BSON, CBOR, MessagePack, and UBJSON) can be fuzz tested. Currently,
 [libFuzzer](https://llvm.org/docs/LibFuzzer.html) and [afl++](https://github.com/AFLplusplus/AFLplusplus) are supported.
 
 ## Corpus creation
@@ -10,11 +10,11 @@ directory with some simple input files that cover several features of the parser
 for mutations.
 
 ```shell
-TEST_DATA_VERSION=3.2.0
+TEST_DATA_VERSION=3.1.0
 wget https://github.com/nlohmann/json_test_data/archive/refs/tags/v$TEST_DATA_VERSION.zip
 unzip v$TEST_DATA_VERSION.zip
 rm v$TEST_DATA_VERSION.zip
-for FORMAT in json bjdata bon8 bson cbor msgpack ubjson
+for FORMAT in json bjdata bson cbor msgpack ubjson
 do
   rm -fr corpus_$FORMAT
   mkdir corpus_$FORMAT

tests/src/fuzzer-parse_bon8.cpp

@@ -1,103 +0,0 @@
-//     __ _____ _____ _____
-//  __|  |   __|     |   | |  JSON for Modern C++ (supporting code)
-// |  |  |__   |  |  | | | |  version 3.12.0
-// |_____|_____|_____|_|___|  https://github.com/nlohmann/json
-//
-// SPDX-FileCopyrightText: 2013-2026 Niels Lohmann <https://nlohmann.me>
-// SPDX-License-Identifier: MIT
-
-/*
-This file implements a parser test suitable for fuzz testing. Given a byte
-array data, it performs the following steps:
-
-- j1 = from_bon8(data)
-- vec = to_bon8(j1)
-- j2 = from_bon8(vec)
-- assert(j1 == j2)
-
-It also checks that reading the data from a stream, which reads strings byte by
-byte, gives the same value or error as reading it from contiguous memory, which
-copies strings in bulk.
-
-The provided function `LLVMFuzzerTestOneInput` can be used in different fuzzer
-drivers.
-*/
-
-#include <cassert>
-#include <iostream>
-#include <sstream>
-#include <nlohmann/json.hpp>
-
-// the round-trip checks below are assertions; NDEBUG would compile them away
-#ifdef NDEBUG
-    #error "the fuzzer drivers must be built without NDEBUG"
-#endif
-
-using json = nlohmann::json;
-
-namespace
-{
-// the serialization of the value read from @a input, or the error message
-template<typename InputType>
-std::string read_bon8(InputType&& input)
-{
-    try
-    {
-        const auto vec = json::to_bon8(json::from_bon8(std::forward<InputType>(input)));
-        return {vec.begin(), vec.end()};
-    }
-    catch (const json::exception& e)
-    {
-        return e.what();
-    }
-}
-} // namespace
-
-// see http://llvm.org/docs/LibFuzzer.html
-extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
-{
-    // contiguous and stream input must be read alike
-    {
-        std::istringstream stream(std::string(reinterpret_cast<const char*>(data), size));
-        assert(read_bon8(std::vector<uint8_t>(data, data + size)) == read_bon8(stream));
-    }
-
-    try
-    {
-        // step 1: parse input
-        std::vector<uint8_t> const vec1(data, data + size);
-        json const j1 = json::from_bon8(vec1);
-
-        try
-        {
-            // step 2: round trip
-            std::vector<uint8_t> const vec2 = json::to_bon8(j1);
-
-            // parse serialization
-            json const j2 = json::from_bon8(vec2);
-
-            // serializations must match
-            assert(json::to_bon8(j2) == vec2);
-        }
-        catch (const json::parse_error&)
-        {
-            // parsing a BON8 serialization must not fail
-            assert(false);
-        }
-    }
-    catch (const json::parse_error&)
-    {
-        // parse errors are ok, because input may be random bytes
-    }
-    catch (const json::type_error&)
-    {
-        // type errors can occur during parsing, too
-    }
-    catch (const json::out_of_range&)
-    {
-        // out of range errors may happen if provided sizes are excessive
-    }
-
-    // return 0 - non-zero return values are reserved for future use
-    return 0;
-}

tests/src/unit-alt-string.cpp

@@ -185,7 +185,6 @@ TEST_CASE("alternative string type")
 
         CHECK(alt_json::from_cbor(alt_json::to_cbor(doc)) == doc);
         CHECK(alt_json::from_msgpack(alt_json::to_msgpack(doc)) == doc);
-        CHECK(alt_json::from_bon8(alt_json::to_bon8(doc)) == doc);
         // BSON is not covered: it additionally needs string_t::find(value_type),
         // which alt_string does not provide
         CHECK(alt_json::from_ubjson(alt_json::to_ubjson(doc)) == doc);

tests/src/unit-binary_formats.cpp

@@ -25,7 +25,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         const auto bjdata_1_size = json::to_bjdata(j).size();
         const auto bjdata_2_size = json::to_bjdata(j, true).size();
         const auto bjdata_3_size = json::to_bjdata(j, true, true).size();
-        const auto bon8_size = json::to_bon8(j).size();
         const auto bson_size = json::to_bson(j).size();
         const auto cbor_size = json::to_cbor(j).size();
         const auto msgpack_size = json::to_msgpack(j).size();
@@ -37,7 +36,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK(bjdata_1_size == 1112030);
         CHECK(bjdata_2_size == 1224148);
         CHECK(bjdata_3_size == 1224148);
-        CHECK(bon8_size == 1055792);
         CHECK(bson_size == 1794522);
         CHECK(cbor_size == 1055552);
         CHECK(msgpack_size == 1056145);
@@ -49,7 +47,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK((100.0 * double(bjdata_1_size) / double(json_size)) == Approx(53.199));
         CHECK((100.0 * double(bjdata_2_size) / double(json_size)) == Approx(58.563));
         CHECK((100.0 * double(bjdata_3_size) / double(json_size)) == Approx(58.563));
-        CHECK((100.0 * double(bon8_size) / double(json_size)) == Approx(50.509));
         CHECK((100.0 * double(bson_size) / double(json_size)) == Approx(85.849));
         CHECK((100.0 * double(cbor_size) / double(json_size)) == Approx(50.497));
         CHECK((100.0 * double(msgpack_size) / double(json_size)) == Approx(50.526));
@@ -67,7 +64,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         const auto bjdata_1_size = json::to_bjdata(j).size();
         const auto bjdata_2_size = json::to_bjdata(j, true).size();
         const auto bjdata_3_size = json::to_bjdata(j, true, true).size();
-        const auto bon8_size = json::to_bon8(j).size();
         const auto bson_size = json::to_bson(j).size();
         const auto cbor_size = json::to_cbor(j).size();
         const auto msgpack_size = json::to_msgpack(j).size();
@@ -79,7 +75,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK(bjdata_1_size == 425342);
         CHECK(bjdata_2_size == 429970);
         CHECK(bjdata_3_size == 429970);
-        CHECK(bon8_size == 391396);
         CHECK(bson_size == 444568);
         CHECK(cbor_size == 402814);
         CHECK(msgpack_size == 401510);
@@ -91,7 +86,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK((100.0 * double(bjdata_1_size) / double(json_size)) == Approx(91.097));
         CHECK((100.0 * double(bjdata_2_size) / double(json_size)) == Approx(92.089));
         CHECK((100.0 * double(bjdata_3_size) / double(json_size)) == Approx(92.089));
-        CHECK((100.0 * double(bon8_size) / double(json_size)) == Approx(83.828));
         CHECK((100.0 * double(bson_size) / double(json_size)) == Approx(95.215));
         CHECK((100.0 * double(cbor_size) / double(json_size)) == Approx(86.273));
         CHECK((100.0 * double(msgpack_size) / double(json_size)) == Approx(85.993));
@@ -109,7 +103,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         const auto bjdata_1_size = json::to_bjdata(j).size();
         const auto bjdata_2_size = json::to_bjdata(j, true).size();
         const auto bjdata_3_size = json::to_bjdata(j, true, true).size();
-        const auto bon8_size = json::to_bon8(j).size();
         const auto bson_size = json::to_bson(j).size();
         const auto cbor_size = json::to_cbor(j).size();
         const auto msgpack_size = json::to_msgpack(j).size();
@@ -121,7 +114,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK(bjdata_1_size == 390781);
         CHECK(bjdata_2_size == 433557);
         CHECK(bjdata_3_size == 432964);
-        CHECK(bon8_size == 317879);
         CHECK(bson_size == 479430);
         CHECK(cbor_size == 342373);
         CHECK(msgpack_size == 342473);
@@ -133,7 +125,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK((100.0 * double(bjdata_1_size) / double(json_size)) == Approx(78.109));
         CHECK((100.0 * double(bjdata_2_size) / double(json_size)) == Approx(86.659));
         CHECK((100.0 * double(bjdata_3_size) / double(json_size)) == Approx(86.541));
-        CHECK((100.0 * double(bon8_size) / double(json_size)) == Approx(63.538));
         CHECK((100.0 * double(bson_size) / double(json_size)) == Approx(95.828));
         CHECK((100.0 * double(cbor_size) / double(json_size)) == Approx(68.433));
         CHECK((100.0 * double(msgpack_size) / double(json_size)) == Approx(68.453));
@@ -151,7 +142,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         const auto bjdata_1_size = json::to_bjdata(j).size();
         const auto bjdata_2_size = json::to_bjdata(j, true).size();
         const auto bjdata_3_size = json::to_bjdata(j, true, true).size();
-        const auto bon8_size = json::to_bon8(j).size();
         const auto bson_size = json::to_bson({{"", j}}).size(); // wrap array in object for BSON
         const auto cbor_size = json::to_cbor(j).size();
         const auto msgpack_size = json::to_msgpack(j).size();
@@ -163,7 +153,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK(bjdata_1_size == 50710965);
         CHECK(bjdata_2_size == 51144830);
         CHECK(bjdata_3_size == 51144830);
-        CHECK(bon8_size == 45942080);
         CHECK(bson_size == 56008520);
         CHECK(cbor_size == 46187320);
         CHECK(msgpack_size == 46158575);
@@ -175,7 +164,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK((100.0 * double(bjdata_1_size) / double(json_size)) == Approx(96.576));
         CHECK((100.0 * double(bjdata_2_size) / double(json_size)) == Approx(97.402));
         CHECK((100.0 * double(bjdata_3_size) / double(json_size)) == Approx(97.402));
-        CHECK((100.0 * double(bon8_size) / double(json_size)) == Approx(87.494));
         CHECK((100.0 * double(bson_size) / double(json_size)) == Approx(106.665));
         CHECK((100.0 * double(cbor_size) / double(json_size)) == Approx(87.961));
         CHECK((100.0 * double(msgpack_size) / double(json_size)) == Approx(87.906));
@@ -193,7 +181,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         const auto bjdata_1_size = json::to_bjdata(j).size();
         const auto bjdata_2_size = json::to_bjdata(j, true).size();
         const auto bjdata_3_size = json::to_bjdata(j, true, true).size();
-        const auto bon8_size = json::to_bon8(j).size();
         // BSON cannot process the file as it contains code point  U+0000
         const auto cbor_size = json::to_cbor(j).size();
         const auto msgpack_size = json::to_msgpack(j).size();
@@ -205,7 +192,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK(bjdata_1_size == 148695);
         CHECK(bjdata_2_size == 150569);
         CHECK(bjdata_3_size == 150569);
-        CHECK(bon8_size == 144477);
         CHECK(cbor_size == 147095);
         CHECK(msgpack_size == 147017);
         CHECK(ubjson_1_size == 148695);
@@ -216,7 +202,6 @@ TEST_CASE("Binary Formats" * doctest::skip())
         CHECK((100.0 * double(bjdata_1_size) / double(json_size)) == Approx(88.153));
         CHECK((100.0 * double(bjdata_2_size) / double(json_size)) == Approx(89.264));
         CHECK((100.0 * double(bjdata_3_size) / double(json_size)) == Approx(89.264));
-        CHECK((100.0 * double(bon8_size) / double(json_size)) == Approx(85.653));
         CHECK((100.0 * double(cbor_size) / double(json_size)) == Approx(87.205));
         CHECK((100.0 * double(msgpack_size) / double(json_size)) == Approx(87.158));
         CHECK((100.0 * double(ubjson_1_size) / double(json_size)) == Approx(88.153));

tests/src/unit-binary_writer_sinks.cpp

@@ -12,7 +12,6 @@
 using nlohmann::json;
 
 #include <cstdint>
-#include <limits>
 #include <string>
 #include <vector>
 
@@ -50,12 +49,6 @@ std::vector<json> test_values()
     };
 }
 
-// BON8 has no integers above the int64 range, so to_bon8() rejects them
-bool bon8_representable(const json& j)
-{
-    return !j.is_number_unsigned() || j.get<std::uint64_t>() <= static_cast<std::uint64_t>((std::numeric_limits<std::int64_t>::max)());
-}
-
 // values to_bson() accepts: the document must be an object
 std::vector<json> bson_values()
 {
@@ -99,13 +92,6 @@ TEST_CASE("binary writer output sinks")
             json::to_msgpack(j, msgpack);
             CHECK(json::to_msgpack(j) == msgpack);
 
-            if (bon8_representable(j))
-            {
-                std::vector<std::uint8_t> bon8;
-                json::to_bon8(j, bon8);
-                CHECK(json::to_bon8(j) == bon8);
-            }
-
             for (const bool use_size :
                     {
                         false, true
@@ -186,10 +172,6 @@ TEST_CASE("binary_reserve_hint never over-reserves")
         CHECK(hint <= json::to_ubjson(j).size());
         CHECK(hint <= json::to_ubjson(j, true, true).size());
         CHECK(hint <= json::to_bjdata(j).size());
-        if (bon8_representable(j))
-        {
-            CHECK(hint <= json::to_bon8(j).size());
-        }
     }
 
     for (const auto& j : bson_values())

tests/src/unit-bson.cpp

@@ -1066,45 +1066,6 @@ TEST_CASE("Incomplete BSON Input")
     }
 }
 
-// the test catches the exceptions of invalid input
-#if !defined(JSON_NOEXCEPTION)
-TEST_CASE("BSON keys from contiguous and stream input")
-{
-    // contiguous input reads a key up to its \x00-byte in one step, a stream
-    // reads it byte by byte; both must give the same value or error for the
-    // complete document and for every truncation of it
-    const json j = {{"", true}, {"k", {1, 2, 3}}, {std::string(40, 'x'), {{"nested key", "value"}}}};
-    const std::vector<std::uint8_t> bson = json::to_bson(j);
-    CHECK(json::from_bson(bson) == j);
-
-    for (std::size_t length = 0; length <= bson.size(); ++length)
-    {
-        CAPTURE(length)
-        const std::vector<std::uint8_t> input(bson.begin(), bson.begin() + static_cast<std::ptrdiff_t>(length));
-        std::string from_vector;
-        std::string from_stream;
-        try
-        {
-            from_vector = json::from_bson(input).dump();
-        }
-        catch (const json::parse_error& e)
-        {
-            from_vector = e.what();
-        }
-        try
-        {
-            std::istringstream stream(std::string(input.begin(), input.end()));
-            from_stream = json::from_bson(stream).dump();
-        }
-        catch (const json::parse_error& e)
-        {
-            from_stream = e.what();
-        }
-        CHECK(from_vector == from_stream);
-    }
-}
-#endif
-
 TEST_CASE("Negative size of binary value")
 {
     // invalid BSON: the size of the binary value is -1

tests/src/unit-class_lexer.cpp

@@ -666,7 +666,7 @@ TEST_CASE("parse_float_fast declines what it cannot convert exactly")
     // always safe: the caller then falls back to a slower, exact conversion.
     const auto fast = [](const std::string & s, double & out)
     {
-        return nlohmann::detail::parse_float_fast(s.data(), s.data() + s.size(), out);
+        return nlohmann::detail::parse_float_fast(s.data(), s.data() + s.size(), '.', out);
     };
     double out = 0;
 

tests/src/unit-class_parser.cpp

@@ -2761,7 +2761,7 @@ TEST_CASE("diagnostic positions: value lifetime, input adapters, and SAX")
 
         SECTION("binary formats have no text positions")
         {
-            // binary formats (BJData, BON8, BSON, CBOR, MessagePack, UBJSON) are
+            // binary formats (CBOR, MessagePack, UBJSON, BSON, BJData) are
             // parsed via detail::binary_reader, which never sets
             // start_position/end_position on the values it produces (they
             // have no notion of a text offset), so every value's position
@@ -2778,10 +2778,6 @@ TEST_CASE("diagnostic positions: value lifetime, input adapters, and SAX")
             CHECK(from_msgpack.start_pos() == std::string::npos);
             CHECK(from_msgpack.end_pos() == std::string::npos);
 
-            const json from_bon8 = json::from_bon8(json::to_bon8(src));
-            CHECK(from_bon8.start_pos() == std::string::npos);
-            CHECK(from_bon8.end_pos() == std::string::npos);
-
             const json from_ubjson = json::from_ubjson(json::to_ubjson(src));
             CHECK(from_ubjson.start_pos() == std::string::npos);
             CHECK(from_ubjson.end_pos() == std::string::npos);

tests/src/unit-custom-binary-type.cpp

@@ -84,8 +84,6 @@ TEST_CASE("binary type whose value type is not std::uint8_t")
 
         // UBJSON has no binary type, so binary values are written as an array
         CHECK(byte_binary_json::from_ubjson(byte_binary_json::to_ubjson(j)) == byte_binary_json({0, 1, 255}));
-        // the same holds for BON8
-        CHECK(byte_binary_json::from_bon8(byte_binary_json::to_bon8(j)) == byte_binary_json({0, 1, 255}));
     }
 #endif
 }

tests/src/unit-custom-object-type.cpp

@@ -297,7 +297,6 @@ TEST_CASE("object type without key_compare")
         const auto j = no_key_compare_json::parse(R"({"a":[1,2,3],"b":"x"})");
         CHECK(no_key_compare_json::from_cbor(no_key_compare_json::to_cbor(j)) == j);
         CHECK(no_key_compare_json::from_msgpack(no_key_compare_json::to_msgpack(j)) == j);
-        CHECK(no_key_compare_json::from_bon8(no_key_compare_json::to_bon8(j)) == j);
     }
 
     SECTION("flatten and unflatten")

tests/src/unit-explicit_instantiation.cpp

@@ -1,37 +0,0 @@
-//     __ _____ _____ _____
-//  __|  |   __|     |   | |  JSON for Modern C++ (supporting code)
-// |  |  |__   |  |  | | | |  version 3.12.0
-// |_____|_____|_____|_|___|  https://github.com/nlohmann/json
-//
-// SPDX-FileCopyrightText: 2013-2026 Niels Lohmann <https://nlohmann.me>
-// SPDX-License-Identifier: MIT
-
-// cmake/test.cmake selects the C++ standard versions with which to build a
-// unit test based on the presence of JSON_HAS_CPP_<VERSION> macros.
-// The regression below only showed on C++17, so build this file for every
-// standard like the other regression tests:
-// JSON_HAS_CPP_17 JSON_HAS_CPP_20 (do not remove; see note at top of file)
-
-#include "doctest_compatibility.h"
-
-#include <nlohmann/json.hpp>
-using json = nlohmann::json;
-
-/////////////////////////////////////////////////////////////////////
-// for #4825 - explicitly instantiating basic_json must compile; this
-// forces instantiation of binary_writer::write_bjdata_ndarray, whose
-// static_cast<string_t> was ambiguous under explicit instantiation on
-// C++17. Merely compiling this translation unit is the regression test.
-//
-// The instantiation compiles every member function, so it has a file of its
-// own: in unit-regression3.cpp it made the object too large for the MinGW
-// linker to relocate (see #5511).
-/////////////////////////////////////////////////////////////////////
-template class nlohmann::basic_json<>;
-
-TEST_CASE("explicit instantiation of basic_json (#4825)")
-{
-    const json j = {1, "two", 3.0};
-    CHECK(j.size() == 3);
-    CHECK(json::from_bjdata(json::to_bjdata(j)) == j);
-}

tests/src/unit-locale-cpp.cpp

@@ -12,12 +12,7 @@
 #include <nlohmann/json.hpp>
 using nlohmann::json;
 
-#include <array>
 #include <clocale>
-#include <map>
-#include <string>
-#include <utility>
-#include <vector>
 
 struct ParserImpl final: public nlohmann::json_sax<json>
 {
@@ -180,208 +175,3 @@ TEST_CASE("locale-dependent test (LC_NUMERIC=de_DE)")
         MESSAGE("locale de_DE is not usable");
     }
 }
-
-namespace
-{
-// records the numbers of a flat array and switches LC_NUMERIC to the given
-// locale once the array opens - after the lexer was constructed, but before
-// any number in the array is lexed
-struct LocaleSwitchingSax final: public nlohmann::json_sax<json>
-{
-    explicit LocaleSwitchingSax(const char* switch_to)
-        : locale_after_open(switch_to)
-    {}
-
-    bool null() override
-    {
-        return true;
-    }
-    bool boolean(bool /*val*/) override
-    {
-        return true;
-    }
-    bool number_integer(json::number_integer_t /*val*/) override
-    {
-        return true;
-    }
-    bool number_unsigned(json::number_unsigned_t /*val*/) override
-    {
-        return true;
-    }
-    bool number_float(json::number_float_t val, const json::string_t& s) override
-    {
-        values.push_back(val);
-        strings.push_back(s);
-        return true;
-    }
-    bool string(json::string_t& /*val*/) override
-    {
-        return true;
-    }
-    bool binary(json::binary_t& /*val*/) override
-    {
-        return true;
-    }
-    bool start_object(std::size_t /*val*/) override
-    {
-        return true;
-    }
-    bool key(json::string_t& /*val*/) override
-    {
-        return true;
-    }
-    bool end_object() override
-    {
-        return true;
-    }
-    bool start_array(std::size_t /*val*/) override
-    {
-        switched = std::setlocale(LC_NUMERIC, locale_after_open) != nullptr;
-        return true;
-    }
-    bool end_array() override
-    {
-        return true;
-    }
-    bool parse_error(std::size_t /*val*/, const std::string& /*val*/, const nlohmann::detail::exception& /*val*/) override
-    {
-        return false;
-    }
-
-    const char* locale_after_open;
-    bool switched = false;
-    std::vector<json::number_float_t> values;
-    std::vector<json::string_t> strings;
-};
-} // namespace
-
-TEST_CASE("locale changes between lexer construction and number conversion (#5198)")
-{
-    // The numbers are chosen so that the conversion also takes the strtod
-    // fallback, which honors the locale that is current at conversion time:
-    // too many significant digits for Clinger's fast path, an underflow that
-    // std::from_chars rejects, and a plain value.
-    const std::vector<std::string> numbers = {"3.14159265358979323846", "1.5e-400", "12.34", "-0.000123456789012345678"};
-    std::string text = "[";
-    for (const auto& n : numbers)
-    {
-        text += (text.size() == 1 ? "" : ",") + n;
-    }
-    text += "]";
-
-    using long_double_json = nlohmann::basic_json<std::map, std::vector, std::string, bool, std::int64_t, std::uint64_t, long double>;
-
-    // reference values, parsed without a locale switch
-    REQUIRE(std::setlocale(LC_NUMERIC, "C") != nullptr);
-    const json expected = json::parse(text);
-    const long_double_json expected_ld = long_double_json::parse(text);
-
-    const std::array<std::pair<const char*, const char*>, 2> transitions =
-    {
-        {
-            {"C", "de_DE"},
-            {"de_DE", "C"}
-        }
-    };
-
-    for (const auto& transition : transitions)
-    {
-        CAPTURE(transition.first);
-        CAPTURE(transition.second);
-
-        if (std::setlocale(LC_NUMERIC, transition.first) == nullptr)
-        {
-            MESSAGE("locale is not usable");
-            continue;
-        }
-
-        // SAX parsing
-        {
-            LocaleSwitchingSax sax(transition.second);
-            CHECK(json::sax_parse(text, &sax));
-            if (sax.switched)
-            {
-                CHECK(sax.values == expected.get<std::vector<json::number_float_t>>());
-                CHECK(sax.strings == numbers);
-            }
-        }
-
-        // DOM parsing with a callback
-        {
-            bool switched = false;
-            const auto cb = [&](int /*depth*/, json::parse_event_t event, json& /*parsed*/)
-            {
-                if (event == json::parse_event_t::array_start)
-                {
-                    switched = std::setlocale(LC_NUMERIC, transition.second) != nullptr;
-                }
-                return true;
-            };
-            const json j = json::parse(text, cb);
-            if (switched)
-            {
-                CHECK(j == expected);
-            }
-        }
-
-        // a long double goes through std::strtold unless std::from_chars supports it
-        {
-            bool switched = false;
-            const auto cb = [&](int /*depth*/, long_double_json::parse_event_t event, long_double_json& /*parsed*/)
-            {
-                if (event == long_double_json::parse_event_t::array_start)
-                {
-                    switched = std::setlocale(LC_NUMERIC, transition.second) != nullptr;
-                }
-                return true;
-            };
-            const long_double_json j = long_double_json::parse(text, cb);
-            if (switched)
-            {
-                CHECK(j == expected_ld);
-            }
-        }
-    }
-
-    std::setlocale(LC_NUMERIC, "C");
-}
-
-TEST_CASE("locale with a multi-byte decimal point")
-{
-    // Some locales use a decimal point that is not a single character, e.g.
-    // U+066B ARABIC DECIMAL SEPARATOR (two bytes in UTF-8). It cannot be
-    // substituted in place for '.', so the strtod fallback stops early. The
-    // conversion must still terminate rather than retry forever.
-    const std::array<const char*, 6> names = {{"ar_EG.UTF-8", "ar_SA.UTF-8", "fa_IR.UTF-8", "ps_AF.UTF-8", "ar_EG", "fa_IR"}};
-    bool tested = false;
-    for (const char* name : names)
-    {
-        if (std::setlocale(LC_NUMERIC, name) == nullptr)
-        {
-            continue;
-        }
-        const std::string decimal_point = std::localeconv()->decimal_point;
-        if (decimal_point.size() < 2)
-        {
-            continue;
-        }
-        CAPTURE(name);
-        tested = true;
-
-        // too many significant digits for Clinger's fast path, and an underflow
-        // that std::from_chars rejects: both reach the strtod fallback
-        json j;
-        CHECK_NOTHROW(j = json::parse("[3.14159265358979323846, 1.5e-400, -0.000123456789012345678]"));
-        CHECK(j.is_array());
-        CHECK(json::accept("3.14159265358979323846"));
-
-        // a value the locale-independent paths convert is not affected
-        CHECK(json::parse("12.5") == 12.5);
-    }
-    if (!tested)
-    {
-        MESSAGE("no locale with a multi-byte decimal point is usable");
-    }
-
-    std::setlocale(LC_NUMERIC, "C");
-}

tests/src/unit-ordered_json2.cpp

@@ -326,15 +326,6 @@ TEST_CASE("ordered_json across binary formats")
         CHECK(collect_keys(restored) == original_keys);
         CHECK(collect_keys(restored["mango"]) == original_mango_keys);
     }
-
-    SECTION("BON8")
-    {
-        const auto bytes = ordered_json::to_bon8(original);
-        const auto restored = ordered_json::from_bon8(bytes);
-        CHECK(restored == original);
-        CHECK(collect_keys(restored) == original_keys);
-        CHECK(collect_keys(restored["mango"]) == original_mango_keys);
-    }
 }
 
 TEST_CASE("alt_json (custom string_t) across binary formats")
@@ -362,13 +353,6 @@ TEST_CASE("alt_json (custom string_t) across binary formats")
         CHECK(restored == original);
     }
 
-    SECTION("BON8")
-    {
-        const auto bytes = alt_json::to_bon8(original);
-        const auto restored = alt_json::from_bon8(bytes);
-        CHECK(restored == original);
-    }
-
     SECTION("BSON")
     {
         const auto bytes = alt_json::to_bson(original);

tests/src/unit-regression2.cpp

@@ -332,7 +332,6 @@ TEST_CASE("regression tests 2")
         CHECK(float_json::from_cbor(float_json::to_cbor(j)) == j);
         CHECK(float_json::from_msgpack(float_json::to_msgpack(j)) == j);
         CHECK(float_json::from_ubjson(float_json::to_ubjson(j)) == j);
-        CHECK(float_json::from_bon8(float_json::to_bon8(j)) == j);
 
         float_json j2 = {1000.0, 2000.0, 3000.0};
         CHECK(float_json::from_ubjson(float_json::to_ubjson(j2, true, true)) == j2);
@@ -766,6 +765,20 @@ TEST_CASE("regression tests 2")
         CHECK(j == k);
     }
 
+#ifdef JSON_HAS_CPP_17
+    SECTION("issue #5066 - MSVC converts json to std::variant<json> via the conversion operator")
+    {
+        // std::variant<json> must not be retrievable via get<>(), because otherwise the
+        // implicit conversion operator becomes a candidate that MSVC picks over the variant's
+        // converting constructor, routing a number through the string from_json overload
+        static_assert(!nlohmann::detail::is_detected<nlohmann::detail::get_template_function, const json&, std::variant<json>>::value,
+                      "std::variant<json> must not be retrievable via get<>()");
+
+        std::vector<std::variant<json>> v;
+        v.push_back(json(1));
+        CHECK(std::get<0>(v[0]) == 1);
+    }
+#endif
 }
 
 TEST_CASE("regression test - parser callback must not lose a duplicate key's prior value")

tests/src/unit-regression3.cpp

@@ -74,7 +74,13 @@ using ordered_json = nlohmann::ordered_json;
     #endif
 #endif
 
-// the explicit instantiation for #4825 is in unit-explicit_instantiation.cpp
+/////////////////////////////////////////////////////////////////////
+// for #4825 - explicitly instantiating basic_json must compile; this
+// forces instantiation of binary_writer::write_bjdata_ndarray, whose
+// static_cast<string_t> was ambiguous under explicit instantiation on
+// C++17. Merely compiling this translation unit is the regression test.
+/////////////////////////////////////////////////////////////////////
+template class nlohmann::basic_json<>;
 
 /////////////////////////////////////////////////////////////////////
 // for #4440
@@ -888,7 +894,6 @@ TEST_CASE("regression test #5476 - array type without reserve()")
         // the binary formats pass a definite length to start_array()
         CHECK(deque_json::from_cbor(deque_json::to_cbor(j)) == j);
         CHECK(deque_json::from_msgpack(deque_json::to_msgpack(j)) == j);
-        CHECK(deque_json::from_bon8(deque_json::to_bon8(j)) == j);
 
         // parse() instantiates the callback parser as well, which reserves too
         const auto with_callback = deque_json::parse(R"([1,2,3])", [](int /*depth*/, deque_json::parse_event_t /*event*/, deque_json& /*parsed*/) noexcept