Fix clang-tidy 22 findings in unit-json_view_edit.cpp and edit.hpp

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

include/nlohmann/detail/view/edit.hpp

@@ -323,7 +323,7 @@ class editor
         node* w = h + 1;
         std::size_t erased = 0;
         bool kept = false;
-        for (node* r = h + 1, *end = h + h->next; r != end; r += 2)
+        for (const node* r = h + 1, *end = h + h->next; r != end; r += 2)
         {
             const bool match = key_equals(*r, key);
             if (match && (kept || !keep_first))
@@ -547,7 +547,7 @@ class editor
         const bool negative = k == value_t::number_integer && static_cast<std::int64_t>(bits) < 0;
         std::uint64_t magnitude = negative ? 0 - bits : bits;
         std::array<char, 24> buf{};
-        char* p = buf.data() + buf.size();
+        char* p = buf.data() + buf.size(); // NOLINT(misc-const-correctness): digits are written through p
         do
         {
             *--p = static_cast<char>('0' + (magnitude % 10));

tests/src/unit-json_view_edit.cpp

@@ -265,7 +265,7 @@ void check_lookups(const ordered_json_editable_view& v)
     }
     else if (v.is_array())
     {
-        for (std::size_t i = 0; i < v.size(); ++i)
+        for (std::size_t i = 0; i < v.size(); ++i) // NOLINT(modernize-loop-convert): both v[i] and v.at(i) are tested
         {
             check_lookups(v[i]);
             check_lookups(v.at(i));