🐛 fix leak for strings

2026-03-02 07:16:24 +00:00 · 2021-07-15 12:52:17 +02:00
parent 6cbdc83994
commit c1298e69a6
1 changed files with 4 additions and 1 deletions
--- a/include/nlohmann/detail/conversions/to_json.hpp
+++ b/include/nlohmann/detail/conversions/to_json.hpp
@@ -236,7 +236,10 @@ template<typename BasicJsonType, typename CompatibleString,
         enable_if_t<std::is_constructible<typename BasicJsonType::string_t, CompatibleString>::value, int> = 0>
 void to_json(BasicJsonType& j, const CompatibleString& s)
 {
-    j.m_value.destroy(j.m_type);
+    if (!j.is_null())
+    {
+        j = nullptr;
+    }
    external_constructor<value_t::string>::construct(j, s);
 }