Name the expected vector in the unit-iterators1 reverse test for MSVC 2017

MSVC 2017 (/permissive- /std:c++17) rejects the braced std::vector<int>
temporary inside CHECK() in this templated test case (C2440).

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This commit is contained in:
Niels Lohmann committed 2026-10-16 13:12:19 +02:00
1 parent cb9634301e
commit 845ad8c52b
1 file changed
+4 -3
+4 -3
View File
@@ -1637,6 +1637,7 @@ TEST_CASE_TEMPLATE("reverse iteration and member access", Json, nlohmann::json,
{
Json j = {1, 2, 3, 4};
const std::vector<int> reversed = {4, 3, 2, 1};
auto it = j.end();
std::vector<int> seen;
while (it != j.begin())
@@ -1644,7 +1645,7 @@ TEST_CASE_TEMPLATE("reverse iteration and member access", Json, nlohmann::json,
--it;
seen.push_back(it->template get<int>());
}
CHECK(seen == std::vector<int> {4, 3, 2, 1});
CHECK(seen == reversed);
auto it2 = j.end();
auto old = it2--;
@@ -1656,14 +1657,14 @@ TEST_CASE_TEMPLATE("reverse iteration and member access", Json, nlohmann::json,
{
seen.push_back(r->template get<int>());
}
CHECK(seen == std::vector<int> {4, 3, 2, 1});
CHECK(seen == reversed);
seen.clear();
for (auto r = j.crbegin(); r != j.crend(); ++r)
{
seen.push_back(r->template get<int>());
}
CHECK(seen == std::vector<int> {4, 3, 2, 1});
CHECK(seen == reversed);
}
SECTION("object: -- and rbegin/rend")