Fixed an issue with round (#207)

* Fix the problem that the result has a decimal point when the round function, when the precision is 0.

* fix tests/test-functions.cpp:91 for round check
This commit is contained in:
逐雁南飛
2021-07-01 13:59:00 +08:00
committed by GitHub
parent c70fd585e5
commit 14f0d38cac
3 changed files with 11 additions and 3 deletions
+5 -1
View File
@@ -439,7 +439,11 @@ class Renderer : public NodeVisitor {
const auto args = get_arguments<2>(node);
const int precision = args[1]->get<int>();
const double result = std::round(args[0]->get<double>() * std::pow(10.0, precision)) / std::pow(10.0, precision);
result_ptr = std::make_shared<json>(std::move(result));
if(0==precision){
result_ptr = std::make_shared<json>(int(result));
}else{
result_ptr = std::make_shared<json>(std::move(result));
}
json_tmp_stack.push_back(result_ptr);
json_eval_stack.push(result_ptr.get());
} break;
+5 -1
View File
@@ -3935,7 +3935,11 @@ class Renderer : public NodeVisitor {
const auto args = get_arguments<2>(node);
const int precision = args[1]->get<int>();
const double result = std::round(args[0]->get<double>() * std::pow(10.0, precision)) / std::pow(10.0, precision);
result_ptr = std::make_shared<json>(std::move(result));
if(0==precision){
result_ptr = std::make_shared<json>(int(result));
}else{
result_ptr = std::make_shared<json>(std::move(result));
}
json_tmp_stack.push_back(result_ptr);
json_eval_stack.push(result_ptr.get());
} break;
+1 -1
View File
@@ -88,7 +88,7 @@ TEST_CASE("functions") {
}
SUBCASE("round") {
CHECK(env.render("{{ round(4, 0) }}", data) == "4.0");
CHECK(env.render("{{ round(4, 0) }}", data) == "4");
CHECK(env.render("{{ round(temperature, 2) }}", data) == "25.68");
// CHECK_THROWS_WITH( env.render("{{ round(name, 2) }}", data), "[inja.exception.json_error]
// [json.exception.type_error.302] type must be number, but is string" );