Commit Graph

3030 Commits

Author SHA1 Message Date
Francis Lachapelle
9d5de9afb7 Merge pull request #201 from inverse-inc/warning-removal-again
Warning removal, next part.
2016-03-09 15:59:11 -05:00
Ludovic Marcotte
4026c4e2d9 (fix) more attendee checks 2016-03-09 10:06:18 -05:00
Ludovic Marcotte
bd81a56e58 (fix) make sure the attendee name is defined before using it 2016-03-08 10:41:49 -05:00
Ludovic Marcotte
81daade9ec (fix) remove unnecessary error message 2016-03-08 08:24:16 -05:00
Francis Lachapelle
255e21795e Update translations 2016-03-07 10:59:54 -05:00
Patrice Levesque
c3f69416be Replace stubs with parent implementations.
Which makes real sense; reference from
https://github.com/inverse-inc/sogo/pull/201#discussion_r54880038 and
https://github.com/inverse-inc/sogo/pull/201#discussion_r54880094
2016-03-07 10:46:40 -05:00
Patrice Levesque
4210131e12 Initialize highestmodseq to avoid any surprise.
Strongly inspired by comment at https://github.com/inverse-inc/sogo/pull/201#discussion-diff-54879796
2016-03-07 10:43:38 -05:00
Patrice Levesque
ce38a9c606 Fix one warning: expected ‘struct NSError **’ but argument is of type ‘id’
nil is not recognized by GCC as a (NSError**), but as an (id).  NULL works the
same but does not spawn warnings.
2016-03-07 10:34:41 -05:00
Patrice Levesque
a813e38897 Comment out sendMail method in SOGoDraftObject and replace its sole known usage by sendMailAndCopyToSent.
In a 2011-09-26 commit (in Changelog.old), I understand the author wanted to
phase sendMail out and replace it by sendMailAndCopyToSent.  Since there are
compilation warnings related to sendMail, removing the sendMail method and
replacing the sole call to it seemed like the cleanest way.
2016-03-07 10:34:41 -05:00
Patrice Levesque
281062a1a1 Fix warning: incomplete implementation of category ‘SOGoExtensions’
Original method was commented out, but not its matching .h declaration;
hence commenting out the .h declaration.
2016-03-07 10:34:41 -05:00
Patrice Levesque
c1095a5ea9 Fix warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
As previous commit, this code assumed pointers are unsigned int, for display
purpose.  Replaced the cast with the native '%p' token from
NSMutableString::appendFormat that's provided for pointer address output.
2016-03-07 10:34:41 -05:00
Patrice Levesque
022fd81474 Fix warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Those are all log formatting routines that assume pointers are unsigned int,
for display purpose.  Replace the cast with the native '%p' token from
NSString::stringWithFormat that's provided for pointer address output.
2016-03-07 10:34:41 -05:00
Patrice Levesque
478b313122 Fix warning: distinct Objective-C type in return
Method is supposed to return a WOResponse pointer, but currently returns a
NSException pointer; typecast the return value, just like the archiveUIDs
method does.
2016-03-07 10:34:41 -05:00
Patrice Levesque
3ba0e9f82f Implement stubs for SOGoCalendarComponent::isNew and SOGoCalendarComponent::setIsNew methods.
Those are required to implement the SOGoComponentOccurence protocol hence
their absence creates compilation warnings.
2016-03-07 10:34:40 -05:00
Patrice Levesque
0b1cf9faaf Avoid warning: the address of ‘timezone’ will always evaluate as ‘true’
As timezone is a pointer allocated on the stack, there is no need to check
for a NULL pointer - if that was ever the initial intention.
2016-03-07 10:34:40 -05:00
Patrice Levesque
5b71ed319a Fix warning: variable ‘uidnext’ set but not used [-Wunused-but-set-variable]
Remove uidnext declaration and calls that change its value.
2016-03-07 10:34:40 -05:00
Patrice Levesque
ddade629fd Synchronize .h and .m method signatures. 2016-03-07 10:34:40 -05:00
Patrice Levesque
5e9d0ce95a Fix warning: ‘-textValue’ not found in protocol(s)
Confusingly, labelNode is a DOMElement, not a DOMNode, so textValue cannot
apply here; textContent which would be an appropriate replacement does not
exist AFAIK in this DOM Library.

So we manually get the text node via firstChild then get its text value
via nodeValue.
2016-03-07 10:34:40 -05:00
Francis Lachapelle
eefb9056ca (html) Use datepicker for task completion date 2016-03-04 11:34:02 -05:00
Francis Lachapelle
b808067cf7 Keep specified task status when not completed
Fixes #3499
2016-03-04 10:24:12 -05:00
Francis Lachapelle
3529d52c3b Fix extraction of mail column from SQL source
Fixes #3544
2016-02-29 11:56:32 -05:00
Francis Lachapelle
a668d89ef9 Fix unseen count retrieval of nested IMAP folders 2016-02-26 14:59:54 -05:00
Francis Lachapelle
07d47829ab Fix default priority of sent messages
Fixes #3542
2016-02-25 11:53:34 -05:00
Francis Lachapelle
5387b5d5a3 Expose listRequiresDot in SOGoContactSourceFolder 2016-02-24 16:47:07 -05:00
Francis Lachapelle
4030cf86fd (feature) Live loading of (GCS) addressbooks
Using md-on-demand of md-virtual-repeat, we now progressively load the
cards metadata of a personal addressbook.
2016-02-19 23:19:07 -05:00
Francis Lachapelle
21dcb57ca9 Remove unrelevent #warning 2016-02-19 16:28:43 -05:00
Francis Lachapelle
485a9d4462 Fix import of cn from SQL source 2016-02-19 16:09:08 -05:00
Patrice Levesque
9cb1b899b0 Merge branch 'master' into fix-some-warnings
Conflicts:
	UI/Scheduler/UIxAppointmentActions.m
2016-02-16 14:32:50 -05:00
Francis Lachapelle
4c01417690 Handle resource limits in the Web interface
See @d7b010
2016-02-16 12:40:59 -05:00
Francis Lachapelle
d56d9f8b08 Handle attendee conflicts in the Web interface
See @d7b010
2016-02-15 16:03:16 -05:00
Patrice Levesque
a5cc2bb5d5 Merge branch 'master' into fix-some-warnings
Conflicts:
	SoObjects/Appointments/SOGoAppointmentObject.m
2016-02-15 11:23:27 -05:00
Patrice Levesque
9e83ff9f04 Fix compilation errors with OpenSSL 2016-02-15 11:14:06 -05:00
Patrice Levesque
bd56f4cf9f Remove pointless #include from .m and .h files
This was done with a brute-force approach, ensuring no additional
warnings from GCC 4.9 under x86_64.
2016-02-13 17:41:54 -05:00
Patrice Levesque
7c25b53fdf Remove pointless #imports from .m and .h files
This was done with a brute-force approach, ensuring no additional
warnings from GCC 4.9 under x86_64.
2016-02-13 16:11:52 -05:00
Ludovic Marcotte
132234cc19 (fix) don't consider default ACLs for attendees 2016-02-12 14:40:51 -05:00
Francis Lachapelle
256a64172e (feature) Custom base font size for HTML messages
If SOGoMailComposeFontSize is set to zero, we keep the previous
behaviour (no font-size added to the message HTML body).
2016-02-11 17:45:57 -05:00
Ludovic Marcotte
d7b010526b (feat) warn when double-booking attendees and offer force save option 2016-02-11 10:54:07 -05:00
Francis Lachapelle
99e5c1b93c (feature) Convert a message to an event or task
Resolves #1722
2016-02-10 16:15:00 -05:00
Patrice Levesque
93158f5121 Wrap common looping idiom inside double-parenthesis to shutup warning 2016-02-10 15:16:42 -05:00
Ludovic Marcotte
8c99fdc99a (fix) allow resources to prevent invitations (fixes #3410) 2016-02-10 15:03:20 -05:00
Patrice Levesque
296d510572 Merge branch 'missing-prototypes' into fix-some-warnings
Avoid compilation errors when using GCC with -Werror=missing-declarations
and -Werror=missing-prototypes (those flags are wanted to track and fix
further warnings).
2016-02-10 14:58:28 -05:00
Patrice Levesque
51cbb980ad Add some missing preprocessing #import directives
Fixes most GCC warnings of form:
	warning: @interface of class ‘MyClass’ not found
2016-02-10 14:46:11 -05:00
Ludovic Marcotte
693f80dc9a (feat) now supports RFC6154 and NoInferiors IMAP flag 2016-02-10 10:00:59 -05:00
Patrice Levesque
5539b7a823 Add missing header prototypes
Fixes compiling errors with GCC using -Werror=missing-prototypes.
2016-02-08 16:14:33 -05:00
Ludovic Marcotte
ee3276f01d (feat) added Junk handling feature from v2 2016-02-08 15:36:01 -05:00
Ludovic Marcotte
d3f59ba621 (fix) add shared/public namespaces in the list or returned folders 2016-02-05 10:01:18 -05:00
Francis Lachapelle
d4ab5dd21b Update translations 2016-02-04 14:01:31 -05:00
Francis Lachapelle
a8845d262f Fix frequency detection of recurrence rule 2016-02-04 09:20:11 -05:00
Francis Lachapelle
bd4f42b948 Fix comparisons with NSNotFound
Fixes #3472
2016-02-03 13:54:08 -05:00
Francis Lachapelle
5a927dfeb3 Improve formatting of SOGoDefaults.plist 2016-01-27 11:27:30 -05:00