(js) Fix possible errors (help from jsjint)

UI/WebServerResources/js/Mailer/Mailbox.service.js

@@ -160,7 +160,7 @@
       // Make a copy of the data for an eventual reset
       this.$shadowData = this.$omit();
     }
-  }
+  };
 
   /**
    * @function $id
@@ -183,7 +183,7 @@
 
     count = 0;
     if (this.$messages) {
-      count = (_.filter(this.$messages, function(message) { return message.selected })).length;
+      count = (_.filter(this.$messages, function(message) { return message.selected; })).length;
     }
     return count;
   };
@@ -215,7 +215,7 @@
       angular.extend(options, { sortingAttributes: Mailbox.$query });
       if (angular.isDefined(filters)) {
         options.filters = _.reject(filters, function(filter) {
-          return angular.isUndefined(filter.searchInput) || filter.searchInput.length == 0;
+          return angular.isUndefined(filter.searchInput) || filter.searchInput.length === 0;
         });
         _.each(options.filters, function(filter) {
           var secondFilter,
@@ -257,8 +257,8 @@
 
       // Preload more headers if possible
       endIndex = Math.min(startIndex + Mailbox.PRELOAD.LOOKAHEAD, max - 1);
-      if (!angular.isDefined(this.$messages[endIndex].subject)
-          && !angular.isDefined(this.$messages[endIndex].loading)) {
+      if (!angular.isDefined(this.$messages[endIndex].subject) &&
+          !angular.isDefined(this.$messages[endIndex].loading)) {
         endIndex = Math.min(startIndex + Mailbox.PRELOAD.SIZE, max);
         for (uids = []; startIndex < endIndex && startIndex < max; startIndex++) {
           if (angular.isDefined(this.$messages[startIndex].subject) || this.$messages[startIndex].loading) {
@@ -332,7 +332,7 @@
 
     // Find mailbox parent
     parent = findParent(null, this.$account.$mailboxes);
-    if (parent == null)
+    if (parent === null)
       children = this.$account.$mailboxes;
     else
       children = parent.children;

UI/WebServerResources/js/Mailer/MailboxController.js

@@ -40,7 +40,7 @@
                      l('Are you sure you want to delete the selected messages?'))
         .then(function() {
           // User confirmed the deletion
-          var selectedMessages = _.filter(vm.selectedFolder.$messages, function(message) { return message.selected });
+          var selectedMessages = _.filter(vm.selectedFolder.$messages, function(message) { return message.selected; });
           var selectedUIDs = _.pluck(selectedMessages, 'uid');
           vm.selectedFolder.$deleteMessages(selectedUIDs).then(function() {
             vm.selectedFolder.$messages = _.difference(vm.selectedFolder.$messages, selectedMessages);
@@ -51,7 +51,7 @@
     }
 
     function copySelectedMessages(folder) {
-      var selectedMessages = _.filter(vm.selectedFolder.$messages, function(message) { return message.selected });
+      var selectedMessages = _.filter(vm.selectedFolder.$messages, function(message) { return message.selected; });
       var selectedUIDs = _.pluck(selectedMessages, 'uid');
       vm.selectedFolder.$copyMessages(selectedUIDs, '/' + folder).then(function() {
         // TODO: refresh target mailbox?

UI/WebServerResources/js/Mailer/Message.service.js

@@ -317,7 +317,7 @@
   Message.prototype.$sendMDN = function() {
     this.shouldAskReceipt = 0;
     return Message.$$resource.post(this.id, 'sendMDN');
-  }
+  };
 
   /**
    * @function $deleteAttachment
@@ -331,12 +331,13 @@
     Message.$$resource.post(this.$absolutePath({asDraft: true}), action).then(function(data) {
       Message.$timeout(function() {
         _this.editable.attachmentAttrs = _.filter(_this.editable.attachmentAttrs, function(attachment) {
-          return attachment.filename != filename});
+          return attachment.filename != filename;
+        });
       }, function() {
         // TODO: show toast
       });
     });
-  }
+  };
 
   /**
    * @function $markAsFlaggedOrUnflagged
@@ -356,7 +357,7 @@
         _this.isflagged = !_this.isflagged;
       });
     });
-  }
+  };
 
   /**
    * @function $reload

UI/WebServerResources/js/Mailer/MessageEditorController.js

@@ -46,15 +46,15 @@
     if ($stateParams.actionName == 'reply') {
       stateMessage.$reply().then(function(msgObject) {
         vm.message = msgObject;
-        vm.hideCc = (!msgObject.editable.cc || msgObject.editable.cc.length == 0);
-        vm.hideBcc = (!msgObject.editable.bcc || msgObject.editable.bcc.length == 0);
+        vm.hideCc = (!msgObject.editable.cc || msgObject.editable.cc.length === 0);
+        vm.hideBcc = (!msgObject.editable.bcc || msgObject.editable.bcc.length === 0);
       });
     }
     else if ($stateParams.actionName == 'replyall') {
       stateMessage.$replyAll().then(function(msgObject) {
         vm.message = msgObject;
-        vm.hideCc = (!msgObject.editable.cc || msgObject.editable.cc.length == 0);
-        vm.hideBcc = (!msgObject.editable.bcc || msgObject.editable.bcc.length == 0);
+        vm.hideCc = (!msgObject.editable.cc || msgObject.editable.cc.length === 0);
+        vm.hideBcc = (!msgObject.editable.bcc || msgObject.editable.bcc.length === 0);
       });
     }
     else if ($stateParams.actionName == 'forward') {

UI/WebServerResources/js/Mailer/sgIMIP.directive.js

@@ -1,6 +1,7 @@
 /* -*- Mode: javascript; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 
 (function() {
+  /* jshint validthis: true */
   'use strict';
 
   /**
@@ -22,21 +23,20 @@
     }
 
     controller.$inject = ['$scope', 'User'];
-    
     function controller($scope, User) {
       var vm = this;
+
       $scope.delegateInvitation = false;
       $scope.delegatedTo = '';
       $scope.searchText = '';
-      
+
       $scope.userFilter = function($query) {
         return User.$filter($query);
       };
-      
+
       $scope.iCalendarAction = function(action) {
-      
         var data;
-        
+
         if (action == 'delegate') {
           data = {receiveUpdates: false,
                   delegatedTo: $scope.delegatedTo.c_email};
@@ -46,7 +46,7 @@
       };
     }
   }
-    
+
   angular
     .module('SOGo.MailerUI')
     .directive('sgImip', sgImip);