From d560d0e4703cef7bfa0cb63e2ebb5553de0fc06f Mon Sep 17 00:00:00 2001 From: Ludovic Marcotte Date: Mon, 17 Feb 2014 11:28:06 -0500 Subject: [PATCH] Always return a response avoiding iOS crashes on no-changes --- ActiveSync/SOGoActiveSyncDispatcher+Sync.m | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ActiveSync/SOGoActiveSyncDispatcher+Sync.m b/ActiveSync/SOGoActiveSyncDispatcher+Sync.m index 2894c5cf6..dfa0b3110 100644 --- a/ActiveSync/SOGoActiveSyncDispatcher+Sync.m +++ b/ActiveSync/SOGoActiveSyncDispatcher+Sync.m @@ -998,7 +998,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. if (changeDetected) { NSLog(@"Change detected, we push the content."); - [output appendString: s]; break; } else @@ -1008,6 +1007,11 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. } } + // We always return the last generated response. + // If we only return , + // iOS powered devices will simply crash. + [output appendString: s]; + [output appendString: @""]; d = [[output dataUsingEncoding: NSUTF8StringEncoding] xml2wbxml];