From 5ccfce7cdcf58227771b7e34c384800601af2bed Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 17:12:37 +0000
Subject: [PATCH 01/12] Monotone-Parent:
 d20b6efa6a8c415c1db8ca849c311e740a312646 Monotone-Revision:
 1dda8463cbff42910b1cacd540a640120d4d4939

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T17:12:37
Monotone-Branch: ca.inverse.sogo
---
 ChangeLog                 |  6 ++++
 SoObjects/SOGo/SOGoUser.m | 76 +++++++++++++++++++++++----------------
 2 files changed, 51 insertions(+), 31 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 54838b558..5e1697b8e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2007-11-06  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
+
+	* SoObjects/SOGo/SOGoUser.m ([SOGoUser -mailAccounts]): we now
+	fetch the accounts from the user defaults and create default
+	values if missing.
+
 2007-11-05  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
 
 	* UI/MailPartViewers/UIxMailPartTextViewer.m
diff --git a/SoObjects/SOGo/SOGoUser.m b/SoObjects/SOGo/SOGoUser.m
index 708ed4f96..64671657c 100644
--- a/SoObjects/SOGo/SOGoUser.m
+++ b/SoObjects/SOGo/SOGoUser.m
@@ -368,44 +368,58 @@ NSString *SOGoWeekStartFirstFullWeek = @"FirstFullWeek";
 }
 
 /* mail */
-- (NSArray *) mailAccounts
+- (void) _prepareDefaultMailAccounts
 {
-#warning should be implemented with the user defaults interfaces
   NSMutableDictionary *mailAccount, *identity;
   NSMutableArray *identities;
   NSString *name, *fullName;
+  NSArray *mails;
+  unsigned int count, max;
+
+  mailAccount = [NSMutableDictionary dictionary];
+  name = [NSString stringWithFormat: @"%@@%@",
+		   login, fallbackIMAP4Server];
+  [mailAccount setObject: login forKey: @"userName"];
+  [mailAccount setObject: fallbackIMAP4Server forKey: @"serverName"];
+  [mailAccount setObject: name forKey: @"name"];
+
+  identities = [NSMutableArray array];
+  mails = [self allEmails];
+
+  max = [mails count];
+  if (max > 1)
+    max--;
+  for (count = 0; count < max; count++)
+    {
+      identity = [NSMutableDictionary dictionary];
+      fullName = [self cn];
+      if (![fullName length])
+	fullName = login;
+      [identity setObject: fullName forKey: @"fullName"];
+      [identity setObject: [mails objectAtIndex: count] forKey: @"email"];
+      [identities addObject: identity];
+    }
+  [[identities objectAtIndex: 0] setObject: [NSNumber numberWithBool: YES]
+				 forKey: @"isDefault"];
+
+  [mailAccount setObject: identities forKey: @"identities"];
+
+  mailAccounts = [NSMutableArray new];
+  [mailAccounts addObject: mailAccount];
+}
+
+- (NSArray *) mailAccounts
+{
+  NSUserDefaults *ud;
 
   if (!mailAccounts)
     {
-      NSArray *mails;
-      int i;
-
-      mailAccount = [NSMutableDictionary dictionary];
-      name = [NSString stringWithFormat: @"%@@%@", login, fallbackIMAP4Server];
-      [mailAccount setObject: login forKey: @"userName"];
-      [mailAccount setObject: fallbackIMAP4Server forKey: @"serverName"];
-      [mailAccount setObject: name forKey: @"name"];
-
-      identities = [NSMutableArray array];
-      mails = [self allEmails];
-
-      for (i = 0; i < [mails count]; i++)
-	{
-	  identity = [NSMutableDictionary dictionary];
-	  fullName = [self cn];
-	  if (![fullName length])
-	    fullName = login;
-	  [identity setObject: fullName forKey: @"fullName"];
-	  [identity setObject: [mails objectAtIndex: i] forKey: @"email"];
-	  
-	  if (i == 0) [identity setObject: [NSNumber numberWithBool: YES] forKey: @"isDefault"];
-	  [identities addObject: identity];
-	}
-	
-      [mailAccount setObject: identities forKey: @"identities"];
-
-      mailAccounts = [NSMutableArray new];
-      [mailAccounts addObject: mailAccount];
+      ud = [self userDefaults];
+      mailAccounts = [ud objectForKey: @"MailAccounts"];
+      if (mailAccounts)
+	[mailAccounts retain];
+      else
+	[self _prepareDefaultMailAccounts];
     }
 
   return mailAccounts;

From 533da99dcc958f9521ca640347423a7b0738d658 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 17:13:03 +0000
Subject: [PATCH 02/12] Monotone-Parent:
 1dda8463cbff42910b1cacd540a640120d4d4939 Monotone-Revision:
 56e8fb42c60b615f9c931f4b5e80a51560db4269

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T17:13:03
Monotone-Branch: ca.inverse.sogo
---
 UI/PreferencesUI/UIxJSONPreferences.m | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/UI/PreferencesUI/UIxJSONPreferences.m b/UI/PreferencesUI/UIxJSONPreferences.m
index 0b18a97b8..de9055939 100644
--- a/UI/PreferencesUI/UIxJSONPreferences.m
+++ b/UI/PreferencesUI/UIxJSONPreferences.m
@@ -33,14 +33,14 @@
 
 @implementation UIxJSONPreferences
 
-- (WOResponse *) _makeResponse: (NSString *) jsonText
+- (WOResponse *) _makeResponse: (NSUserDefaults *) defaults
 {
   WOResponse *response;
 
   response = [context response];
   [response setHeader: @"text/plain; charset=utf-8"
 	    forKey: @"content-type"];
-  [response appendContentString: jsonText];
+  [response appendContentString: [defaults jsonRepresentation]];
 
   return response;
 }
@@ -51,7 +51,7 @@
 
   defaults = [[context activeUser] userDefaults];
 
-  return [self _makeResponse: [defaults jsonRepresentation]];
+  return [self _makeResponse: defaults];
 }
 
 - (WOResponse *) jsonSettingsAction
@@ -60,7 +60,7 @@
 
   settings = [[context activeUser] userSettings];
 
-  return [self _makeResponse: [settings jsonRepresentation]];
+  return [self _makeResponse: settings];
 }
 
 @end

From 4cf8731681471c114274afaa7804c34851d4d70a Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 17:13:15 +0000
Subject: [PATCH 03/12] Monotone-Parent:
 56e8fb42c60b615f9c931f4b5e80a51560db4269 Monotone-Revision:
 d25dc292baa2e15a7f6d397c032c8cb30ccdafb2

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T17:13:15
Monotone-Branch: ca.inverse.sogo
---
 .../English.lproj/Localizable.strings         |  3 ++
 .../French.lproj/Localizable.strings          |  3 ++
 UI/PreferencesUI/GNUmakefile                  |  1 +
 .../German.lproj/Localizable.strings          |  3 ++
 UI/PreferencesUI/UIxPreferences.h             |  2 +-
 UI/PreferencesUI/UIxPreferences.m             | 30 +++++++++++++++++++
 UI/PreferencesUI/product.plist                |  4 +++
 7 files changed, 45 insertions(+), 1 deletion(-)

diff --git a/UI/PreferencesUI/English.lproj/Localizable.strings b/UI/PreferencesUI/English.lproj/Localizable.strings
index d216c0fe6..d9b2679cb 100644
--- a/UI/PreferencesUI/English.lproj/Localizable.strings
+++ b/UI/PreferencesUI/English.lproj/Localizable.strings
@@ -82,6 +82,9 @@
 "messageforward_inline" = "Inline";
 "messageforward_attached" = "As Attachment";
 
+"Default identity:" = "Default identity:";
+"Manage identities..." = "Manage identities...";
+
 /* password */
 "New password:" = "New password:";
 "Confirmation:" = "Confirmation:";
diff --git a/UI/PreferencesUI/French.lproj/Localizable.strings b/UI/PreferencesUI/French.lproj/Localizable.strings
index 99d333873..d41dd6d1d 100644
--- a/UI/PreferencesUI/French.lproj/Localizable.strings
+++ b/UI/PreferencesUI/French.lproj/Localizable.strings
@@ -79,6 +79,9 @@
 "messageforward_inline" = "intégrés";
 "messageforward_attached" = "en pièces jointes";
 
+"Default identity:" = "Identité par défaut :";
+"Manage identities..." = "Gérer les identitiés...";
+
 /* password */
 "New password:" = "Nouveau mot de passe :";
 "Confirmation:" = "Confirmation :";
diff --git a/UI/PreferencesUI/GNUmakefile b/UI/PreferencesUI/GNUmakefile
index 2b34be9b5..496a1eda3 100644
--- a/UI/PreferencesUI/GNUmakefile
+++ b/UI/PreferencesUI/GNUmakefile
@@ -11,6 +11,7 @@ PreferencesUI_LANGUAGES = English French German
 PreferencesUI_OBJC_FILES =		\
 	PreferencesUIProduct.m		\
 	\
+	UIxIdentities.m			\
 	UIxJSONPreferences.m		\
 	UIxPreferences.m
 
diff --git a/UI/PreferencesUI/German.lproj/Localizable.strings b/UI/PreferencesUI/German.lproj/Localizable.strings
index e25c85fb0..55db9ef65 100644
--- a/UI/PreferencesUI/German.lproj/Localizable.strings
+++ b/UI/PreferencesUI/German.lproj/Localizable.strings
@@ -79,6 +79,9 @@
 "messageforward_inline" = "Eingebunden";
 "messageforward_attached" = "Als Anhang";
 
+"Default identity:" = "Default identity:";
+"Manage identities..." = "Manage identities...";
+
 /* password */
 "New password:" = "Neues Passwort:";
 "Confirmation:" = "Bestätigung:";
diff --git a/UI/PreferencesUI/UIxPreferences.h b/UI/PreferencesUI/UIxPreferences.h
index 5570fbc7e..c97889248 100644
--- a/UI/PreferencesUI/UIxPreferences.h
+++ b/UI/PreferencesUI/UIxPreferences.h
@@ -32,7 +32,7 @@
 
 @interface UIxPreferences : UIxComponent
 {
-  NSString *item;
+  id item;
   SOGoUser *user;
   NSUserDefaults *userDefaults;
   NSCalendarDate *today;
diff --git a/UI/PreferencesUI/UIxPreferences.m b/UI/PreferencesUI/UIxPreferences.m
index 0a6c33ef1..958675336 100644
--- a/UI/PreferencesUI/UIxPreferences.m
+++ b/UI/PreferencesUI/UIxPreferences.m
@@ -28,6 +28,7 @@
 #import <NGObjWeb/WOContext.h>
 #import <NGObjWeb/WORequest.h>
 
+#import <SoObjects/SOGo/NSDictionary+Utilities.h>
 #import <SoObjects/SOGo/SOGoUser.h>
 
 #import "UIxPreferences.h"
@@ -466,6 +467,35 @@ static BOOL shouldDisplayPasswordChange = NO;
   [userDefaults setObject: newMessageForwarding forKey: @"MessageForwarding"];
 }
 
+// 	<label><var:string label:value="Default identity:"/>
+// 	  <var:popup list="identitiesList" item="item"
+// 	    string="itemIdentityText" selection="defaultIdentity"/></label>
+- (NSArray *) identitiesList
+{
+  return [user allIdentities];
+}
+
+- (NSString *) itemIdentityText
+{
+  return [item keysWithFormat: @"%{fullName} <%{email}>"];
+}
+
+- (NSDictionary *) defaultIdentity
+{
+  NSDictionary *currentIdentity, *defaultIdentity;
+  NSEnumerator *identities;
+
+  defaultIdentity = nil;
+
+  identities = [[user allIdentities] objectEnumerator];
+  while (!defaultIdentity
+	 && (currentIdentity = [identities nextObject]))
+    if ([[currentIdentity objectForKey: @"isDefault"] boolValue])
+      defaultIdentity = currentIdentity;
+
+  return defaultIdentity;
+}
+
 - (id <WOActionResults>) defaultAction
 {
   id <WOActionResults> results;
diff --git a/UI/PreferencesUI/product.plist b/UI/PreferencesUI/product.plist
index de4a1d90d..2891bffa1 100644
--- a/UI/PreferencesUI/product.plist
+++ b/UI/PreferencesUI/product.plist
@@ -20,6 +20,10 @@
 	      protectedBy = "View";
 	      pageName = "UIxPreferences";
 	   };
+	   identities = {
+	      protectedBy = "View";
+	      pageName = "UIxIdentities";
+	   };
 	   jsonDefaults = {
 	      protectedBy = "View";
 	      actionClass = "UIxJSONPreferences";

From 58aeee0393c0c65afb61d1190fdbe0fb5f604fab Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 17:13:19 +0000
Subject: [PATCH 04/12] Monotone-Parent:
 d25dc292baa2e15a7f6d397c032c8cb30ccdafb2 Monotone-Revision:
 8c2a059d02106d28fe1332f9ecd1d7d5b75cfaeb

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T17:13:19
Monotone-Branch: ca.inverse.sogo
---
 UI/WebServerResources/UIxPreferences.js | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/UI/WebServerResources/UIxPreferences.js b/UI/WebServerResources/UIxPreferences.js
index 8549871bc..4a08999d7 100644
--- a/UI/WebServerResources/UIxPreferences.js
+++ b/UI/WebServerResources/UIxPreferences.js
@@ -3,3 +3,21 @@ function savePreferences(sender) {
 
    return false;
 }
+
+function initPreferences() {
+  var identitiesBtn = $("manageIdentitiesBtn");
+  Event.observe(identitiesBtn, "click",
+		popupIdentitiesWindow.bindAsEventListener(identitiesBtn));
+}
+
+function popupIdentitiesWindow(event) {
+  var urlstr = UserFolderURL + "identities";
+  var w = window.open(urlstr, "identities",
+		      "width=430,height=250,resizable=0,scrollbars=0,location=0");
+  w.opener = window;
+  w.focus();
+
+  preventDefault(event);
+}
+
+addEvent(window, 'load', initPreferences);

From f2b6271cefd62deb1d3360bb53723ed1e683cef5 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 17:13:23 +0000
Subject: [PATCH 05/12] Monotone-Parent:
 8c2a059d02106d28fe1332f9ecd1d7d5b75cfaeb Monotone-Revision:
 166aef5ba4c5699c0bde50ef5dddb543641e5c67

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T17:13:23
Monotone-Branch: ca.inverse.sogo
---
 UI/Templates/PreferencesUI/UIxPreferences.wox | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/UI/Templates/PreferencesUI/UIxPreferences.wox b/UI/Templates/PreferencesUI/UIxPreferences.wox
index dd0ca1af2..7857d13ff 100644
--- a/UI/Templates/PreferencesUI/UIxPreferences.wox
+++ b/UI/Templates/PreferencesUI/UIxPreferences.wox
@@ -80,6 +80,12 @@
 	<label><var:string label:value="Forward messages:"/>
 	  <var:popup list="messageForwardingList" item="item"
 	    string="itemMessageForwardingText" selection="userMessageForwarding"/></label><br/>
+	<label><var:string label:value="Default identity:"/>
+	  <var:popup list="identitiesList" item="item"
+	    string="itemIdentityText" selection="defaultIdentity"/></label>
+	<input type="button" class="button" id="manageIdentitiesBtn"
+	  label:value="Manage identities..."/>
+	<br/>
 	<!--	<label><input
 	const:name="inTheOffice" type="radio" const:value="YES"
 	var:selection="inTheOffice"/>

From 57f174e2f0d04ea6f8b58ad02cb163a05d5836d8 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 21:22:10 +0000
Subject: [PATCH 06/12] Monotone-Parent:
 166aef5ba4c5699c0bde50ef5dddb543641e5c67 Monotone-Revision:
 e5f7bc9b668fc4dd36afd650762d96297397bacf

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T21:22:10
Monotone-Branch: ca.inverse.sogo
---
 ChangeLog                        |  4 ++++
 UI/MailerUI/UIxMailToSelection.m | 30 ++++++++++++++++++++++++------
 2 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5e1697b8e..a379bb64b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2007-11-06  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
 
+	* UI/MailerUI/UIxMailToSelection.m ([UIxMailToSelection
+	-getAddressesFromFormValues:_dict]): take NSString and NSArray
+	values. Ignore addresses with a length of 0.
+
 	* SoObjects/SOGo/SOGoUser.m ([SOGoUser -mailAccounts]): we now
 	fetch the accounts from the user defaults and create default
 	values if missing.
diff --git a/UI/MailerUI/UIxMailToSelection.m b/UI/MailerUI/UIxMailToSelection.m
index ef5c141bc..cdcc83bf0 100644
--- a/UI/MailerUI/UIxMailToSelection.m
+++ b/UI/MailerUI/UIxMailToSelection.m
@@ -285,11 +285,31 @@ static NSArray *headers = nil;
 
 /* handling requests */
 
+- (void) _fillAddresses: (NSMutableArray *) addresses
+	     withObject: (id) object
+{
+  NSEnumerator *list;
+  NSString *currentAddress;
+
+  if ([object isKindOfClass: [NSString class]])
+    [addresses addObject: object];
+  else if ([object isKindOfClass: [NSArray class]])
+    {
+      list = [object objectEnumerator];
+      while ((currentAddress
+	      = [[list nextObject] stringByTrimmingSpaces]))
+	if ([currentAddress length])
+	  [addresses addObject: currentAddress];
+    }
+}
+
 - (void) getAddressesFromFormValues: (NSDictionary *) _dict
 {
   NSMutableArray *rawTo, *rawCc, *rawBcc;
+  NSString *idx, *popupKey, *popupValue;
   NSArray *keys;
   unsigned i, count;
+  id addr;
 
   rawTo  = [NSMutableArray arrayWithCapacity:4];
   rawCc  = [NSMutableArray arrayWithCapacity:4];
@@ -304,18 +324,16 @@ static NSArray *headers = nil;
       key = [keys objectAtIndex:i];
       if ([key hasPrefix:@"addr_"])
 	{
-	  NSString *idx, *addr, *popupKey, *popupValue;
-	  
-	  addr = [[_dict objectForKey:key] lastObject];
+	  addr = [_dict objectForKey:key];
 	  idx  = [self getIndexFromIdentifier:key];
 	  popupKey = [NSString stringWithFormat:@"popup_%@", idx];
 	  popupValue = [[_dict objectForKey:popupKey] lastObject];
 	  if([popupValue isEqualToString:@"0"])
-	    [rawTo addObject:addr];
+	    [self _fillAddresses: rawTo withObject: addr];
 	  else if([popupValue isEqualToString:@"1"])
-	    [rawCc addObject:addr];
+	    [self _fillAddresses: rawCc withObject: addr];
 	  else
-	    [rawBcc addObject:addr];
+	    [self _fillAddresses: rawBcc withObject: addr];
 	}
     }
   

From f4fc4f291923f5a08a6694cb0a52c95658e5dca2 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 21:22:29 +0000
Subject: [PATCH 07/12] Monotone-Parent:
 e5f7bc9b668fc4dd36afd650762d96297397bacf Monotone-Revision:
 22ead1833f863ecd3b5a400f21cc4916a09d95a1

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T21:22:29
Monotone-Branch: ca.inverse.sogo
---
 SOPE/GDLContentStore/gcs_mkdir.m | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/SOPE/GDLContentStore/gcs_mkdir.m b/SOPE/GDLContentStore/gcs_mkdir.m
index fc3b35473..9e62ee878 100644
--- a/SOPE/GDLContentStore/gcs_mkdir.m
+++ b/SOPE/GDLContentStore/gcs_mkdir.m
@@ -66,7 +66,9 @@
     return 1;
   }
   
-  if ((error = [self->folderManager createFolderOfType:_type atPath:_path])) {
+  if ((error = [self->folderManager createFolderOfType:_type
+		    withName: @"testFolder"
+		    atPath:_path])) {
     [self logWithFormat:@"creation of folder %@ at %@ failed: %@",
 	    _type, _path, error];
     return 1;

From e0593733184242f9bce049f44264df4a51b5adcf Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 21:22:39 +0000
Subject: [PATCH 08/12] Monotone-Parent:
 22ead1833f863ecd3b5a400f21cc4916a09d95a1 Monotone-Revision:
 4d00dad8739e7b006068670c6a0916934c2178bc

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T21:22:39
Monotone-Branch: ca.inverse.sogo
---
 SOPE/NGCards/iCalRepeatableEntityObject.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SOPE/NGCards/iCalRepeatableEntityObject.h b/SOPE/NGCards/iCalRepeatableEntityObject.h
index 08f19f819..fa475a01c 100644
--- a/SOPE/NGCards/iCalRepeatableEntityObject.h
+++ b/SOPE/NGCards/iCalRepeatableEntityObject.h
@@ -43,7 +43,7 @@
 
 - (void)removeAllRecurrenceRules;
 - (void)addToRecurrenceRules:(id)_rrule;
-- (void)setRecurrenceRules:(id)_rrule;
+- (void)setRecurrenceRules:(NSArray *)_rrule;
 - (BOOL)hasRecurrenceRules;
 - (NSArray *)recurrenceRules;
 

From 6c7d4936259d95c892ddd66a5cf7b9a07306a0d4 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 21:23:08 +0000
Subject: [PATCH 09/12] Monotone-Parent:
 4d00dad8739e7b006068670c6a0916934c2178bc Monotone-Revision:
 f6e1c82adf3299ac7fc2df5deef6ba13019de9de

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T21:23:08
Monotone-Branch: ca.inverse.sogo
---
 SoObjects/Mailer/NSData+Mail.h   | 1 +
 SoObjects/Mailer/NSString+Mail.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/SoObjects/Mailer/NSData+Mail.h b/SoObjects/Mailer/NSData+Mail.h
index 45e033f74..d22317820 100644
--- a/SoObjects/Mailer/NSData+Mail.h
+++ b/SoObjects/Mailer/NSData+Mail.h
@@ -30,6 +30,7 @@
 @interface NSData (SOGoMailUtilities)
 
 - (NSData *) bodyDataFromEncoding: (NSString *) encoding;
+- (NSString *) decodedSubject;
 
 @end
 
diff --git a/SoObjects/Mailer/NSString+Mail.h b/SoObjects/Mailer/NSString+Mail.h
index 72bc984a9..3b34491cb 100644
--- a/SoObjects/Mailer/NSString+Mail.h
+++ b/SoObjects/Mailer/NSString+Mail.h
@@ -28,7 +28,6 @@
 @interface NSString (SOGoExtension)
 
 - (NSString *) htmlToText;
-
 - (NSString *) decodedSubject;
 
 @end

From 3018edc28675030f9be2fdbe4f0156796dde6f50 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 21:24:13 +0000
Subject: [PATCH 10/12] Monotone-Parent:
 f6e1c82adf3299ac7fc2df5deef6ba13019de9de Monotone-Revision:
 db5a20bc6c2f5dd838cdcbfac3adf1bd6f707424

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T21:24:13
Monotone-Branch: ca.inverse.sogo
---
 SoObjects/Mailer/SOGoMailObject.m | 1 +
 SoObjects/Mailer/SOGoMailReply.m  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/SoObjects/Mailer/SOGoMailObject.m b/SoObjects/Mailer/SOGoMailObject.m
index 934f1c61c..87a86fa29 100644
--- a/SoObjects/Mailer/SOGoMailObject.m
+++ b/SoObjects/Mailer/SOGoMailObject.m
@@ -44,6 +44,7 @@
 #import <SoObjects/SOGo/SOGoPermissions.h>
 #import <SoObjects/SOGo/SOGoUser.h>
 
+#import "NSString+Mail.h"
 #import "NSData+Mail.h"
 #import "SOGoMailFolder.h"
 #import "SOGoMailAccount.h"
diff --git a/SoObjects/Mailer/SOGoMailReply.m b/SoObjects/Mailer/SOGoMailReply.m
index d2e939d94..f1758ed6a 100644
--- a/SoObjects/Mailer/SOGoMailReply.m
+++ b/SoObjects/Mailer/SOGoMailReply.m
@@ -21,6 +21,7 @@
  */
 
 #import <NGObjWeb/WOContext+SoObjects.h>
+#import <NGExtensions/NSString+misc.h>
 
 #import <SoObjects/SOGo/SOGoDateFormatter.h>
 #import <SoObjects/SOGo/SOGoUser.h>

From 7698dc9f79fc0b06614db2b6ee4097ddf6f0f805 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 21:24:22 +0000
Subject: [PATCH 11/12] Monotone-Parent:
 db5a20bc6c2f5dd838cdcbfac3adf1bd6f707424 Monotone-Revision:
 de445c20292c49e37a9bba2be90480d1d34799ae

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T21:24:22
Monotone-Branch: ca.inverse.sogo
---
 UI/SOGoUI/UIxComponent.m | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/UI/SOGoUI/UIxComponent.m b/UI/SOGoUI/UIxComponent.m
index 273d3e20b..efbe22c91 100644
--- a/UI/SOGoUI/UIxComponent.m
+++ b/UI/SOGoUI/UIxComponent.m
@@ -24,23 +24,27 @@
 #import <Foundation/NSUserDefaults.h>
 #import <Foundation/NSKeyValueCoding.h>
 #import <Foundation/NSPathUtilities.h>
+
 #import <NGObjWeb/SoHTTPAuthenticator.h>
 #import <NGObjWeb/SoObjects.h>
 #import <NGObjWeb/WOResourceManager.h>
 #import <NGObjWeb/WORequest.h>
+#import <NGObjWeb/WOResponse.h>
 #import <NGObjWeb/WOContext+SoObjects.h>
 #import <NGExtensions/NSObject+Logs.h>
 #import <NGExtensions/NSString+misc.h>
 #import <NGExtensions/NSURL+misc.h>
+
 #import <SoObjects/SOGo/SOGoUser.h>
 #import <SoObjects/SOGo/SOGoObject.h>
 #import <SoObjects/SOGo/SOGoCustomGroupFolder.h>
 #import <SoObjects/SOGo/NSCalendarDate+SOGo.h>
 #import <SoObjects/SOGo/NSString+Utilities.h>
 
-#import "UIxComponent.h"
 #import "UIxJSClose.h"
 
+#import "UIxComponent.h"
+
 @interface UIxComponent (PrivateAPI)
 - (void)_parseQueryString:(NSString *)_s;
 - (NSMutableDictionary *)_queryParameters;

From f2798d68860bfa8611826d1ddbb66ed95bd60a80 Mon Sep 17 00:00:00 2001
From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Date: Tue, 6 Nov 2007 22:07:39 +0000
Subject: [PATCH 12/12] Monotone-Parent:
 de445c20292c49e37a9bba2be90480d1d34799ae Monotone-Revision:
 dae312b4bfd2084618c23a6232f43e0a9c5d7938

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2007-11-06T22:07:39
Monotone-Branch: ca.inverse.sogo
---
 UI/WebServerResources/generic.js | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/UI/WebServerResources/generic.js b/UI/WebServerResources/generic.js
index 5103916e3..78298291e 100644
--- a/UI/WebServerResources/generic.js
+++ b/UI/WebServerResources/generic.js
@@ -218,8 +218,13 @@ function openUserFolderSelector(callback, type) {
 }
 
 function openContactWindow(url, wId) {
-  if (!wId)
-    wId = "" + (new Date().getTime());
+  if (typeof wId == "undefined")
+    wId = "_blank";
+  else {
+    var r = new RegExp("[\.\/-]", "g");
+    wId = wId.replace(r, "_");
+  }
+
   var w = window.open(url, wId,
 		      "width=450,height=600,resizable=0,location=0");
   w.focus();
@@ -230,12 +235,15 @@ function openContactWindow(url, wId) {
 function openMailComposeWindow(url, wId) {
   var parentWindow = this;
 
-  if (!wId)
-    wId = "" + (new Date().getTime());
-  else
+  if (typeof wId == "undefined")
+    wId = "_blank";
+  else {
+    var r = new RegExp("[\.\/-]", "g");
+    wId = wId.replace(r, "_");
     if (document.body.hasClassName("popup"))
       parentWindow = window.opener;
-  
+  }
+
   var w = parentWindow.open(url, wId,
                       "width=680,height=520,resizable=1,scrollbars=1,toolbar=0,"
                       + "location=0,directories=0,status=0,menubar=0"