From 8ebf0d88e55faefdecb354bb525ed1c0af2e509c Mon Sep 17 00:00:00 2001 From: Wolfgang Sourdeau Date: Thu, 10 May 2007 16:15:24 +0000 Subject: [PATCH] Monotone-Parent: 6a4ca400c5002f16d1bc1a5c29569fd895195891 Monotone-Revision: e29f563ab0cd9f47da56070fa528af4b9c253e7a Monotone-Author: wsourdeau@inverse.ca Monotone-Date: 2007-05-10T16:15:24 Monotone-Branch: ca.inverse.sogo --- ChangeLog | 4 ++++ SoObjects/SOGo/AgenorUserDefaults.m | 14 +++++--------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 62fa79aac..f8bf5b79a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2007-05-10 Wolfgang Sourdeau + * SoObjects/SOGo/AgenorUserDefaults.m ([AgenorUserDefaults + -primaryFetchProfile]): check that the value returned is not null + before interpreting it. + * SoObjects/SOGo/LDAPUserManager.m ([LDAPUserManager -contactInfosForUserWithUIDorEmail:uid]): check that uid is not empty. ([LDAPUserManager -_fillContactMailRecords:contact]): if the diff --git a/SoObjects/SOGo/AgenorUserDefaults.m b/SoObjects/SOGo/AgenorUserDefaults.m index 1b377f1ae..e7031c7c7 100644 --- a/SoObjects/SOGo/AgenorUserDefaults.m +++ b/SoObjects/SOGo/AgenorUserDefaults.m @@ -104,12 +104,11 @@ static NSString *uidColumnName = @"uid"; { GCSChannelManager *cm; EOAdaptorChannel *channel; - NSDictionary *row, *oldValues; + NSDictionary *row; NSException *ex; - NSString *sql; + NSString *sql, *value; NSArray *attrs; BOOL rc; - id column; rc = NO; @@ -143,12 +142,9 @@ static NSString *uidColumnName = @"uid"; [channel cancelFetch]; /* remember values */ - column = [row objectForKey: fieldName]; - if ([column isNotNull]) - { - oldValues = [column propertyList]; - [values setDictionary: oldValues]; - } + value = [row objectForKey: fieldName]; + if ([value isNotNull]) + [values setDictionary: [value propertyList]]; ASSIGN (lastFetch, [NSCalendarDate date]); defFlags.modified = NO;