From 6cc9f8e2f0bb3641efee2337839e8f8c89799c64 Mon Sep 17 00:00:00 2001
From: Francis Lachapelle <flachapelle@inverse.ca>
Date: Tue, 24 Jul 2012 15:17:38 +0000
Subject: [PATCH] See ChangeLog

Monotone-Parent: 247bc51241f490e20ac9abc386e95d4198cefbaf
Monotone-Revision: 8bbf9c70304e5cb8320d6acb300955b814d1ff0c

Monotone-Author: flachapelle@inverse.ca
Monotone-Date: 2012-07-24T15:17:38
---
 ChangeLog                                        |  5 +++++
 .../English.lproj/Localizable.strings            |  3 +++
 UI/WebServerResources/UIxPreferences.js          | 16 +++++++++++++---
 3 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c29ad3cb9..503f1b924 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-07-24  Francis Lachapelle  <flachapelle@inverse.ca>
+
+	* UI/WebServerResources/UIxPreferences.js (savePreferences):
+	validate the email address of the sender mail and reply-to fields.
+
 2012-07-23  Jean Raby  <jraby@inverse.ca>
 	* debian*/sogo.logrotate:
 	  drop distro specific log rotate scripts
diff --git a/UI/PreferencesUI/English.lproj/Localizable.strings b/UI/PreferencesUI/English.lproj/Localizable.strings
index 921eb83a5..ee816ede3 100644
--- a/UI/PreferencesUI/English.lproj/Localizable.strings
+++ b/UI/PreferencesUI/English.lproj/Localizable.strings
@@ -167,6 +167,9 @@
 "Signature" = "Signature";
 "Please enter your signature below:" = "Please enter your signature below:";
 
+"Please specify a valid sender address." = "Please specify a valid sender address.";
+"Please specify a valid reply-to address." = "Please specify a valid reply-to address.";
+
 /* Additional Parameters */
 "Additional Parameters" = "Additional Parameters";
 
diff --git a/UI/WebServerResources/UIxPreferences.js b/UI/WebServerResources/UIxPreferences.js
index 27c76912c..dc2397518 100644
--- a/UI/WebServerResources/UIxPreferences.js
+++ b/UI/WebServerResources/UIxPreferences.js
@@ -17,6 +17,16 @@ function savePreferences(sender) {
         serializeContactsCategories();
     }
 
+    if (mailCustomFromEnabled && !emailRE.test($("email").value)) {
+        showAlertDialog(_("Please specify a valid sender address."));
+        sendForm = false;
+    }
+
+    if (!emailRE.test($("replyTo").value)) {
+        showAlertDialog(_("Please specify a valid reply-to address."));
+        sendForm = false;
+    }
+
     if ($("dayStartTime")) {
         var start = $("dayStartTime");
         var selectedStart = parseInt(start.options[start.selectedIndex].value);
@@ -63,10 +73,10 @@ function savePreferences(sender) {
         $("sieveFilters").setValue(Object.toJSON(jsonFilters));
     }
 
-    saveMailAccounts();
-
-    if (sendForm)
+    if (sendForm) {
+        saveMailAccounts();
         $("mainForm").submit();
+    }
 
     return false;
 }