amorfo77/sogo
1
0
Fork 0
mirror of https://github.com/inverse-inc/sogo.git synced 2026-05-25 21:35:23 +00:00
Code Issues Projects Releases Wiki Activity

feat(login): add parameters to prevent uneccesary connection request when the domain is unknown

Browse Source
This commit is contained in:
Hivert Quentin
2024-10-01 17:53:46 +02:00
parent 4ee6d5af9d
commit 56598d1e37
4 changed files with 65 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SoObjects/SOGo/SOGoUserManager.m
+39 -1
View File
@@ -607,10 +607,48 @@ static const NSString *kObfuscatedSecondaryEmailKey = @"obfuscatedSecondaryEmail
{
*_domain = [username substringFromIndex: r.location+1];
if (![[[SOGoSystemDefaults sharedSystemDefaults] domainIds] containsObject: *_domain])
if (![[sd domainIds] containsObject: *_domain])
*_domain = nil;
}
}
// If the domains is unknwon we reject the auth
if([sd forbidUnknownDomainsAuth])
{
NSArray *domainsAllowed, *domainsKnown;
NSString *userDomain;
NSRange r;
BOOL allowed = NO;
if(!*_domain)
{
r = [username rangeOfString: @"@"];
if(r.location != NSNotFound)
userDomain = [username substringFromIndex: r.location+1];
else
userDomain = nil;
}
else
userDomain = *_domain;
if(!userDomain)
{
[self errorWithFormat: @"User attempt to login without domain"];
return allowed;
}
if((domainsAllowed = [sd domainsAllowed]) && [domainsAllowed containsObject: userDomain])
allowed = YES;
if((domainsKnown = [sd domainIds]) && [domainsKnown containsObject: userDomain])
allowed = YES;
if([domainsKnown length] == 0 && [domainsAllowed length] == 0)
[self errorWithFormat: @"SOGoForbidUnknownDomainsAuth is set but sogo don't know any domains"];
else if(!allowed)
[self errorWithFormat: @"User domain is unknown or not allowed: %@", userDomain];
return allowed;
}
// We check the fail count per user in memcache (per server). If the
// fail count reaches X in Y minutes, we deny immediately the