Stage 1 of clang compiler warning patches.

Tools/SOGoEAlarmsNotifier.m

@@ -81,8 +81,8 @@
   timestamp = (int) [[NSDate date] timeIntervalSince1970];
   pGUID = [[NSProcessInfo processInfo] globallyUniqueString];
 
-  messageID = [NSString stringWithFormat: @"<%0X-%0X-%0X-%0X@%u>",
-                        pid, timestamp, sequence, random(), [pGUID hash]];
+  messageID = [NSString stringWithFormat: @"<%0X-%0X-%0X-%0X@%lu>",
+                        pid, timestamp, sequence, (unsigned int)random(), [pGUID hash]];
 
   return [messageID lowercaseString];
 }

Tools/SOGoSockDOperation.m

@@ -145,7 +145,7 @@ Class SOGoContactSourceFolderKlass = Nil;
     [self _appendEntry: [resultEntries objectAtIndex: count]
               toResult: result];
 
-  [result appendFormat: @"RESULT\ncode: %", resultCode];
+  [result appendFormat: @"RESULT\ncode: %d", resultCode];
   [responseSocket
     safeWriteData: [result dataUsingEncoding: NSASCIIStringEncoding]];
 }

Tools/SOGoToolCreateFolder.m

@@ -97,7 +97,7 @@
   rc = [self createFolder: folder withFM: fm];
   if (!rc)
     {
-      NSLog (@"Create directory failed at path %s", folder);
+      NSLog (@"Create directory failed at path %@", folder);
       return NO;
     }
 

Tools/SOGoToolExpireUserSessions.m

@@ -143,7 +143,7 @@
   else
   {
     if (verbose)
-      NSLog(@"No session to remove", sessionsToDelete);
+      NSLog(@"No session to remove");
   }
 
   [cm releaseChannel: channel];

Tools/SOGoToolManageEAS.m

@@ -227,7 +227,7 @@ typedef enum
 
               NSMutableString *sql;
 
-              sql = [NSMutableString stringWithFormat: @"DELETE FROM %@" @" WHERE c_path like '/%@%'", [oc tableName], deviceId];
+              sql = [NSMutableString stringWithFormat: @"DELETE FROM %@ WHERE c_path like '/%@'", [oc tableName], deviceId];
 
               [oc performBatchSQLQueries: [NSArray arrayWithObject: sql]];
               rc = YES;

Tools/SOGoToolRemoveDoubles.m

@@ -175,7 +175,7 @@
 
   now = [NSCalendarDate date];
   delSql = [NSString stringWithFormat: @"UPDATE %@"
-                     @" SET c_deleted = 1, c_lastmodified = %d,"
+                     @" SET c_deleted = 1, c_lastmodified = %lu,"
                      @" c_content = ''"
 		     @" WHERE c_name = '%@'",
 		     tableName,

Tools/SOGoToolRenameUser.m

@@ -148,7 +148,7 @@
   if (sqlError)
     {
       [ac rollbackTransaction];
-      NSLog([sqlError reason]);
+      NSLog(@"%@", [sqlError reason]);
     }
   else
     rc = [ac commitTransaction];
@@ -201,7 +201,7 @@
   if (sqlError)
     {
       [ac rollbackTransaction];
-      NSLog([sqlError reason]);
+      NSLog(@"%@", [sqlError reason]);
     }
   else
     rc = [ac commitTransaction];

Tools/SOGoToolUserPreferences.m

@@ -115,7 +115,7 @@ typedef enum
       [theKey caseInsensitiveCompare: @"Vacation"] == NSOrderedSame)
     {
       /* credentials file handling */
-      NSString *credsFilename, *authname, *authpwd;
+      NSString *credsFilename=nil, *authname=nil, *authpwd=nil;
       SOGoCredentialsFile *cf;
 
       credsFilename = [[NSUserDefaults standardUserDefaults] stringForKey: @"p"];

Tools/sogo-tool.m

@@ -149,7 +149,7 @@
                   command, [currentTool objectAtIndex: 1]];
     }
 
-  NSLog (helpString);
+  NSLog (@"%@", helpString);
 }
 
 - (void) registerTools