From 364b9f3d6166448f40ee72f372d9e9d5e804f7d7 Mon Sep 17 00:00:00 2001 From: Wolfgang Sourdeau Date: Mon, 14 May 2012 17:11:10 +0000 Subject: [PATCH] Monotone-Parent: d4a2b559c00ba43032aff09497fe8be50f429e21 Monotone-Revision: bb27badf50d6df9168d73f3e08a4f10ce3626700 Monotone-Author: wsourdeau@inverse.ca Monotone-Date: 2012-05-14T17:11:10 --- ChangeLog | 7 +++++++ UI/WebServerResources/UIxPreferences.js | 17 ++++++----------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3b45e797c..787198b22 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-05-14 Wolfgang Sourdeau + + * UI/WebServerResources/UIxPreferences.js (initMailAccounts) + (displayMailAccount): getElementsByTagName seems too standard for + IE, we use $$() now so that we can invoke "each" on the result set + without triggering an exception. + 2012-05-09 Ludovic Marcotte * SoObjects/Mailer/SOGoDraftObject.m - don't encode message/rfc822 diff --git a/UI/WebServerResources/UIxPreferences.js b/UI/WebServerResources/UIxPreferences.js index e0ea18bd7..27c76912c 100644 --- a/UI/WebServerResources/UIxPreferences.js +++ b/UI/WebServerResources/UIxPreferences.js @@ -469,26 +469,23 @@ function initMailAccounts() { } } - var info = $("accountInfo"); - var inputs = info.getElementsByTagName("input"); + var inputs = $$("#accountInfo input"); for (var i = 0; i < inputs.length; i++) { $(inputs[i]).observe("change", onMailAccountInfoChange); } - info = $("identityInfo"); - inputs = info.getElementsByTagName("input"); + inputs = $$("#identityInfo input"); for (var i = 0; i < inputs.length; i++) { $(inputs[i]).observe("change", onMailIdentityInfoChange); } $("actSignature").observe("click", onMailIdentitySignatureClick); displayMailAccount(mailAccounts[0], true); - info = $("returnReceiptsInfo"); - inputs = info.getElementsByTagName("input"); + inputs = $$("#returnReceiptsInfo input"); for (var i = 0; i < inputs.length; i++) { $(inputs[i]).observe("change", onMailReceiptInfoChange); } - inputs = info.getElementsByTagName("select"); + inputs = $$("#returnReceiptsInfo select"); for (var i = 0; i < inputs.length; i++) { $(inputs[i]).observe("change", onMailReceiptActionChange); } @@ -656,13 +653,11 @@ function onMailAccountEntryClick(event) { } function displayMailAccount(mailAccount, readOnly) { - var fieldSet = $("accountInfo"); - var inputs = $(fieldSet.getElementsByTagName("input")); + var inputs = $$("#accountInfo input"); inputs.each(function (i) { i.disabled = readOnly; i.mailAccount = mailAccount; }); - fieldSet = $("identityInfo"); - inputs = $(fieldSet.getElementsByTagName("input")); + inputs = $$("#identityInfo input"); inputs.each(function (i) { i.mailAccount = mailAccount; }); if (!mailCustomFromEnabled) { for (var i = 0; i < 2; i++) {