From 2b685ae05c04dc5be9ab66ba1d8a869bd0a67bb0 Mon Sep 17 00:00:00 2001
From: Ludovic Marcotte <lmarcotte@inverse.ca>
Date: Mon, 2 Mar 2009 17:45:32 +0000
Subject: [PATCH] See ChangeLog

Monotone-Parent: d7098152cae36121388c0a0b60a86132b83eb7d6
Monotone-Revision: b3a500aa833d95b94e57f01645279aeda5ad3587

Monotone-Author: ludovic@Sophos.ca
Monotone-Date: 2009-03-02T17:45:32
Monotone-Branch: ca.inverse.sogo
---
 ChangeLog                   | 7 +++++++
 SoObjects/SOGo/SOGoObject.m | 9 +++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1508dbabb..675c0aea1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-03-02  Ludovic Marcotte <lmarcotte@inverse.ca>
+
+	* SoObjects/SOGo/SOGoObject.m
+	([SOGoObject -davRecordForUser:parameters:]):
+	Don't initialize the SOGoUser variable of
+	nocn AND noemail are passed.
+
 2009-02-23  Ludovic Marcotte <lmarcotte@inverse.ca>
 
 	* Updated German translation. Patch from
diff --git a/SoObjects/SOGo/SOGoObject.m b/SoObjects/SOGo/SOGoObject.m
index 2b5c706b5..2858b14d3 100644
--- a/SoObjects/SOGo/SOGoObject.m
+++ b/SoObjects/SOGo/SOGoObject.m
@@ -1356,19 +1356,19 @@ SEL SOGoSelectorForPropertySetter (NSString *property)
 		     parameters: (NSArray *) params
 {
   NSMutableString *userRecord;
-  SOGoUser *sogoUser;
 
   userRecord = [NSMutableString string];
 
   [userRecord appendFormat: @"<id>%@</id>",
 	      [user stringByEscapingXMLString]];
-  sogoUser = [SOGoUser userWithLogin: user roles: nil];
 
+  // Make sure to not call [SOGoUser userWithLogin...] here if nocn AND noemail
+  // is specified. We'll avoid generating LDAP calls by doing so.
   if (![params containsObject: @"nocn"])
     {
       NSString *cn;
 
-      cn = [sogoUser cn];
+      cn = [[SOGoUser userWithLogin: user roles: nil] cn];
       if (!cn)
 	cn = user;
       [userRecord appendFormat: @"<displayName>%@</displayName>",
@@ -1379,7 +1379,8 @@ SEL SOGoSelectorForPropertySetter (NSString *property)
     {
       NSString *email;
 
-      email = [[sogoUser allEmails] objectAtIndex: 0];
+      email = [[[SOGoUser userWithLogin: user roles: nil]
+		 allEmails] objectAtIndex: 0];
       if (email)
 	[userRecord appendFormat: @"<email>%@</email>",
 		    [email stringByEscapingXMLString]];