From 1786ec4d590e6d36565c57bac4108e846fe73ab5 Mon Sep 17 00:00:00 2001
From: Francis Lachapelle <flachapelle@inverse.ca>
Date: Thu, 9 Dec 2021 17:31:56 -0500
Subject: [PATCH] fix(mail(js)): ignore return key in input fields of editor

Fixes #4666
---
 UI/Templates/MailerUI/UIxMailEditor.wox                  | 9 ++++++++-
 .../js/Mailer/MessageEditorController.js                 | 9 +++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/UI/Templates/MailerUI/UIxMailEditor.wox b/UI/Templates/MailerUI/UIxMailEditor.wox
index 5884afe22..ce4a0a99c 100644
--- a/UI/Templates/MailerUI/UIxMailEditor.wox
+++ b/UI/Templates/MailerUI/UIxMailEditor.wox
@@ -33,6 +33,7 @@
           <md-autocomplete
               class="md-margin md-default-theme md-bg md-hue-1" flex="flex"
               required="required"
+              ng-keydown="editor.ignoreReturn($event)"
               md-input-name="from"
               md-require-match="true"
               md-selected-item="editor.fromIdentity"
@@ -95,6 +96,7 @@
                         md-autofocus="editor.isNew()"
                         md-autocomplete-snap="width">
                 <md-autocomplete
+                    ng-keydown="editor.ignoreReturn($event)"
                     md-menu-class="md-2-line"
                     md-search-text="editor.autocomplete.to.searchText"
                     md-selected-item="editor.autocomplete.to.selected"
@@ -136,6 +138,7 @@
                         md-add-on-blur="true"
                         md-autocomplete-snap="width">
                 <md-autocomplete
+                    ng-keydown="editor.ignoreReturn($event)"
                     md-menu-class="md-2-line"
                     md-search-text="editor.autocomplete.cc.searchText"
                     md-selected-item="editor.autocomplete.cc.selected"
@@ -177,6 +180,7 @@
                         md-add-on-blur="true"
                         md-autocomplete-snap="width">
                 <md-autocomplete
+                    ng-keydown="editor.ignoreReturn($event)"
                     md-menu-class="md-2-line"
                     md-selected-item="editor.autocomplete.bcc.selected"
                     md-search-text="editor.autocomplete.bcc.searchText"
@@ -212,7 +216,10 @@
               <label>
                 <var:string label:value="Subject"/>
               </label>
-              <input type="text" name="subject" ng-model="editor.message.editable.subject" ng-required="true"/>
+              <input type="text" name="subject"
+                     ng-model="editor.message.editable.subject"
+                     ng-keydown="editor.ignoreReturn($event)"
+                     ng-required="true"/>
               <div ng-messages="messageForm.subject.$error">
                 <div ng-message="required"><var:string label:value="Please specify a subject."/></div>
               </div>
diff --git a/UI/WebServerResources/js/Mailer/MessageEditorController.js b/UI/WebServerResources/js/Mailer/MessageEditorController.js
index 179d48875..d53be2bfc 100644
--- a/UI/WebServerResources/js/Mailer/MessageEditorController.js
+++ b/UI/WebServerResources/js/Mailer/MessageEditorController.js
@@ -209,6 +209,15 @@
       $mdDialog.hide();
     }
 
+    // Fix for https://www.sogo.nu/bugs/view.php?id=4666
+    this.ignoreReturn = function ($event) {
+      if ($event.keyCode == 13) {
+        $event.stopPropagation();
+        $event.preventDefault();
+        return false;
+      }
+    };
+
     this.save = function (options) {
       var ctrls = $parentControllers();
       this.message.$save().then(function() {