From 1328a2566b21cf0de4f04547b50c50d507b383d6 Mon Sep 17 00:00:00 2001 From: Francis Lachapelle Date: Mon, 16 May 2022 16:46:04 -0400 Subject: [PATCH] fix(admininistration(js)): improve handling of unauthorized access --- .../js/Administration/Administration.app.js | 8 +++++++- .../js/Administration/AdministrationAclController.js | 8 +++----- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/UI/WebServerResources/js/Administration/Administration.app.js b/UI/WebServerResources/js/Administration/Administration.app.js index 4872a57d6..4d34ec48a 100644 --- a/UI/WebServerResources/js/Administration/Administration.app.js +++ b/UI/WebServerResources/js/Administration/Administration.app.js @@ -43,7 +43,8 @@ }, resolve: { stateUser: stateUser, - stateFolder: stateFolder + stateFolder: stateFolder, + stateAcls: stateAcls } }) .state('administration.theme', { @@ -120,6 +121,11 @@ return o; } + stateAcls.$inject = ['stateFolder']; + function stateAcls(stateFolder) { + return stateFolder.$acl.$users(stateFolder.owner); + } + /** * @ngInject */ diff --git a/UI/WebServerResources/js/Administration/AdministrationAclController.js b/UI/WebServerResources/js/Administration/AdministrationAclController.js index c04770aab..6a8fb0c40 100644 --- a/UI/WebServerResources/js/Administration/AdministrationAclController.js +++ b/UI/WebServerResources/js/Administration/AdministrationAclController.js @@ -7,12 +7,13 @@ /** * @ngInject */ - AdministrationAclController.$inject = ['$timeout', '$state', '$mdMedia', '$mdToast', 'stateUser', 'stateFolder', 'sgConstant', 'User']; - function AdministrationAclController($timeout, $state, $mdMedia, $mdToast, stateUser, stateFolder, sgConstant, User) { + AdministrationAclController.$inject = ['$timeout', '$state', '$mdMedia', '$mdToast', 'stateUser', 'stateFolder', 'stateAcls', 'sgConstant', 'User']; + function AdministrationAclController($timeout, $state, $mdMedia, $mdToast, stateUser, stateFolder, stateAcls, sgConstant, User) { var vm = this; vm.user = stateUser; vm.folder = stateFolder; + vm.users = stateAcls; vm.folderType = angular.isDefined(stateFolder.$cards)? 'AddressBook' : 'Calendar'; vm.selectedUser = null; vm.selectedUid = null; @@ -29,9 +30,6 @@ vm.userFilter = userFilter; vm.addUser = addUser; - stateFolder.$acl.$users(stateFolder.owner).then(function(data) { - vm.users = data; - }); function getTemplate() { if (angular.isDefined(stateFolder.$cards))