d44df9d00d
backup: Always remove the status lines once a backup ends
2020-09-30 23:13:10 +02:00
8d0ba55ecd
backup: Fix possible deadlock of scanner goroutine
...
When the backup is interrupted for some reason while the scanner is
still active this could lead to a deadlock. Interruptions are triggered
by canceling the context object used by both the backup progress UI and
the scanner. It is possible that a context is canceled between the
respective check in the scanner and it calling the `ReportTotal` method
of the UI. The latter method sends a message to the UI goroutine.
However, a canceled context will also stop that goroutine, which can
cause the channel send operation to block indefinitely.
This is resolved by adding a `closed` channel which is closed once the
UI goroutine is stopped and serves as an escape hatch for reported UI
updates.
This change covers not just the ReportTotal method but all potentially
affected methods of the progress UI implementation.
2020-09-30 23:13:10 +02:00
14b312f00d
Merge pull request #2658 from creativeprojects/issue-2241
...
Don't echo authentication passwords (rest backend)
2020-09-22 22:17:53 +02:00
206cadfab4
Hide password from repository URLs
2020-09-22 22:00:51 +02:00
4875f7b659
Merge pull request #2614 from greatroar/simplify-fs
...
Simplify internal/fs
2020-09-21 22:05:10 +02:00
0d65b78168
Simplify os.ModeType|os.ModeCharDevice => os.ModeType
...
Since Go 1.12, ModeCharDevice is included in ModeType:
golang/go@a2a3dd00c9
2020-09-21 14:21:32 +02:00
95ebba85ff
Remove stray Printf from internal/fs
2020-09-21 14:21:32 +02:00
59b343a9bf
Remove OS-specific versions of fs.MkdirAll
...
Go has supported Windows paths correctly since 1.11, see
https://github.com/golang/go/issues/10900 and the commit referenced
there.
2020-09-21 14:21:32 +02:00
1557c58eef
Fix and simplify fs.Reader
...
fakeDir.{Readdir,Readdirnames} weren't handling the case n == 0
correctly. fakeFileInfo.sys is always nil, so omit the field.
2020-09-21 14:21:32 +02:00
c504aa505c
Remove unused fs.Rename
2020-09-21 14:21:32 +02:00
1b20f6beec
Remove io.Writer from fs.File
...
It was only used in a single test, which now uses plain *os.File instead.
2020-09-21 14:21:32 +02:00
f003410402
init: Add --copy-chunker-params option
...
This allows creating multiple repositories with identical chunker
parameters which is required for working deduplication when copying
snapshots between different repositories.
2020-09-19 16:53:05 +02:00
cb3f531050
Make Cache.Path private
...
It's only used inside the package.
2020-09-18 11:17:29 +02:00
23fcbb275a
Remove restic.Cache interface
...
It was used in one code path, which then asserted its concrete type as
*cache.Cache.
Privatised some of the interface methods.
2020-09-18 10:48:13 +02:00
6e3215a80d
Remove unused error type from internal/cache
2020-09-18 10:38:14 +02:00
9abef3bf1a
Move internal/fs.TestChdir to internal/test.Chdir
2020-09-17 10:43:33 +02:00
0c48e515f0
Merge pull request #2630 from MichaelEischer/fix-staticcheck
...
Fix lots of small issues reported by staticcheck
2020-09-13 16:19:22 +02:00
97950ab81a
options: Fix test for Go >= 1.15
2020-09-12 17:36:44 +02:00
88664ba222
Merge pull request #2893 from MichaelEischer/restore-preallocate
...
restorer: Preallocate files
2020-09-08 22:43:05 +02:00
121233e1b3
Add preallocate tests
2020-09-07 21:41:47 +02:00
8cc9514879
restorer: pre-allocate files before loading chunks
2020-09-07 21:41:47 +02:00
2e7d475029
Process packs in order of first appearance
2020-09-06 21:25:35 +02:00
c46edcd9d6
error strings should not end with punctuation
2020-09-05 10:07:17 +02:00
1ede018ea6
error variable names should start with 'Err'
2020-09-05 10:07:17 +02:00
b77e933d80
Convert underscore variable names to camelCase
2020-09-05 10:07:16 +02:00
d0329cf3eb
Adjust comments to match name of exported methods
2020-09-05 10:07:16 +02:00
dc31529fc3
Unindent else block after if block ending with a return statement
2020-09-05 10:07:16 +02:00
4784540f04
repository: Simplify worker group code
2020-09-05 10:07:16 +02:00
84ea2389ae
archiver_test: Only skip symlinks on windows
2020-09-05 10:07:16 +02:00
b4a7ce86cf
uint cannot be less than zero
2020-09-05 10:07:16 +02:00
7ee0964880
crypto: Remove unused error
2020-09-05 10:07:16 +02:00
f6f11400c2
restic: Remove unused variable value
2020-09-05 10:07:16 +02:00
e2dc5034d3
restic/file: Use FileType for all File constants
...
The data type of a variable is only carried on when using iota.
2020-09-05 10:07:16 +02:00
9a1b3cb5d9
restorer: Remove unused treeID struct member from test
2020-09-05 10:07:16 +02:00
ee05501ce7
archiver: Remove unused chmod function
2020-09-05 10:07:16 +02:00
014600bee6
archiver: Remove unused variable from test
2020-09-05 10:07:16 +02:00
d9a80e07b9
repository: Simplify index age calculation
2020-09-05 10:07:16 +02:00
460e2ffbf6
Collapse a few boolean operations
2020-09-05 10:07:14 +02:00
2f8335554c
Remove a few unused variables
2020-09-05 10:06:23 +02:00
37113282ca
Merge a few variable declaration and initializations
2020-09-05 10:05:34 +02:00
337725c354
Use sort.Strings
2020-09-05 10:05:34 +02:00
dcf9ded977
dump: Use slashes as path separators in tar on windows
...
This conversion is necessary as paths returned by filepath.Rel use the
operating-system native path separator
2020-08-30 18:26:50 +02:00
fe6445e0f4
dump: Added unit tests for tar output
2020-08-30 16:00:48 +02:00
80a11960dd
dump: Always dump relative paths into tarballs
...
Tarballs should only contain relative paths.
2020-08-29 21:14:34 +02:00
d6f739ec22
dump: Extract tar code to internal/dump
2020-08-29 21:14:34 +02:00
b25978a53c
backup: Fix reporting of directory count in summary
...
Previously the directory stats were reported immediately after calling
`SaveDir`. However, as the latter method saves the tree asynchronously
the stats were still initialized to their nil value. The stats are now
reported via a callback similar to the one used for the fileSaver.
2020-08-27 22:43:51 +02:00
b1b3f1ecb6
Merge pull request #2674 from MichaelEischer/prune-strict-checks
...
prune: Stricter error checks
2020-08-23 10:30:41 +02:00
51c22f4223
local backend: ignore not supported error on sync()
...
Closes #2395
2020-08-22 01:27:07 +02:00
f4b9544ab2
prune: Add test that repack aborts on wrong blob
2020-08-16 11:34:01 +02:00
367449dede
prune: Reduce memory allocations while repacking
...
The slicing operator `slice[low:high]` default to 0 for the lower bound and
len(slice) for the upper bound when either or both are not specified.
Fix the code to use `cap(slice)` to check for the slice capacity.
2020-08-16 11:34:01 +02:00
Michael Eischer
Fred
greatroar
Alexander Neumann
Alexander Neumann
Simon Beck
Hristo Trendev