From bd945df2ea92a70fae86c52f28ec09f4d455ecec Mon Sep 17 00:00:00 2001 From: Michael Eischer Date: Sat, 16 May 2026 13:23:05 +0200 Subject: [PATCH] archiver: note that fileSaver.Save expects non-blocking callbacks --- internal/archiver/file_saver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/archiver/file_saver.go b/internal/archiver/file_saver.go index b5048819a..3407cae16 100644 --- a/internal/archiver/file_saver.go +++ b/internal/archiver/file_saver.go @@ -64,7 +64,7 @@ type fileCompleteFunc func(*data.Node, ItemStats) // Save stores the file f and returns the data once it has been completed. The // file is closed by Save. completeReading is only called if the file was read // successfully. complete is always called. If completeReading is called, then -// this will always happen before calling complete. +// this will always happen before calling complete. The callbacks must not block. func (s *fileSaver) Save(ctx context.Context, snPath string, target string, file fs.File, start func(), completeReading func(), complete fileCompleteFunc) futureNode { fn, ch := newFutureNode() job := saveFileJob{