Apply go fix -slicescontains ./...

cmd/restic/cmd_backup.go

@@ -10,6 +10,7 @@ import (
 	"path"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"strconv"
 	"strings"
 	"time"
@@ -304,10 +305,8 @@ func (opts BackupOptions) Check(gopts global.Options, args []string) error {
 		}
 
 		filesFrom := append(append(opts.FilesFrom, opts.FilesFromVerbatim...), opts.FilesFromRaw...)
-		for _, filename := range filesFrom {
+		if slices.Contains(filesFrom, "-") {
-			if filename == "-" {
+			return errors.Fatal("unable to read password from stdin when data is to be read from stdin, use --password-file or $RESTIC_PASSWORD")
-				return errors.Fatal("unable to read password from stdin when data is to be read from stdin, use --password-file or $RESTIC_PASSWORD")
-			}
 		}
 	}
 

cmd/restic/cmd_backup_integration_test.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"strings"
 	"testing"
 	"time"
@@ -630,13 +631,7 @@ func linkEqual(source, dest []string) bool {
 	}
 
 	for i := range source {
-		found := false
+		found := slices.Contains(dest, source[i])
-		for j := range dest {
-			if source[i] == dest[j] {
-				found = true
-				break
-			}
-		}
 		if !found {
 			return false
 		}

cmd/restic/cmd_cat.go

@@ -3,6 +3,7 @@ package main
 import (
 	"context"
 	"encoding/json"
+	"slices"
 	"strings"
 
 	"github.com/spf13/cobra"
@@ -49,13 +50,7 @@ func validateCatArgs(args []string) error {
 		return errors.Fatal("type not specified")
 	}
 
-	validType := false
+	validType := slices.Contains(catAllowedCmds, args[0])
-	for _, v := range catAllowedCmds {
-		if v == args[0] {
-			validType = true
-			break
-		}
-	}
 	if !validType {
 		return errors.Fatalf("invalid type %q, must be one of [%s]", args[0], strings.Join(catAllowedCmds, "|"))
 	}

cmd/restic/integration_helpers_test.go

@@ -9,6 +9,7 @@ import (
 	"os"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"strings"
 	"testing"
 
@@ -339,13 +340,7 @@ func removePacksExcept(gopts global.Options, t testing.TB, keep restic.IDSet, re
 }
 
 func includes(haystack []string, needle string) bool {
-	for _, s := range haystack {
+	return slices.Contains(haystack, needle)
-		if s == needle {
-			return true
-		}
-	}
-
-	return false
 }
 
 func loadSnapshotMap(t testing.TB, gopts global.Options) map[string]struct{} {

internal/data/snapshot.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"os/user"
 	"path/filepath"
+	"slices"
 	"sync"
 	"time"
 
@@ -174,12 +175,7 @@ func (sn *Snapshot) RemoveTags(removeTags []string) (changed bool) {
 }
 
 func (sn *Snapshot) hasTag(tag string) bool {
-	for _, snTag := range sn.Tags {
+	return slices.Contains(sn.Tags, tag)
-		if tag == snTag {
-			return true
-		}
-	}
-	return false
 }
 
 // HasTags returns true if the snapshot has all the tags in l.
@@ -240,13 +236,7 @@ func (sn *Snapshot) HasHostname(hostnames []string) bool {
 		return true
 	}
 
-	for _, hostname := range hostnames {
+	return slices.Contains(hostnames, sn.Hostname)
-		if sn.Hostname == hostname {
-			return true
-		}
-	}
-
-	return false
 }
 
 // Snapshots is a list of snapshots.