mirror of
https://github.com/domainaware/parsedmarc.git
synced 2026-08-15 11:53:16 +00:00
Three unresolved review threads, all verified against cli.py's
re-raising init handler before fixing:
- elastic.py/opensearch.py: connections.get_connection() sat outside
migrate_indexes()'s try/except, so a connection-registration failure
would abort startup despite the docstring's promise that migration
errors are caught and logged. Now caught, logged, and skipped until
the next startup.
- opensearch.py: the legacy published_policy.fo migration loop did
unguarded network I/O (exists/get_field_mapping/reindex/delete), so a
transient cluster error aborted startup on the OpenSearch path while
the identical situation on the Elasticsearch path was logged and
survived. Each index's migration attempt is now wrapped, warns, and
moves on.
- opensearch_dashboards.ndjson: normalized two pre-existing panel
titles in the aggregate dashboard's panelsJSON ("Reporting
organizations " trailing space, "Map of message sources by country"
double space).
Regression tests assert migrate_indexes never propagates connection or
per-index cluster errors on either backend.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>