From d512b9f60e78f6df58f8a580bf85982c411e5969 Mon Sep 17 00:00:00 2001
From: Yuuki Takahashi <20282867+yktakaha4@users.noreply.github.com>
Date: Tue, 20 Feb 2024 08:53:52 +0900
Subject: [PATCH] fix: handle none value (#468)

---
 parsedmarc/__init__.py             |  2 +-
 samples/aggregate/empty_reason.xml | 56 ++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 1 deletion(-)
 create mode 100644 samples/aggregate/empty_reason.xml

diff --git a/parsedmarc/__init__.py b/parsedmarc/__init__.py
index 5afc1d2..f2d7125 100644
--- a/parsedmarc/__init__.py
+++ b/parsedmarc/__init__.py
@@ -698,7 +698,7 @@ def parsed_aggregate_reports_to_csv_rows(reports):
             row["dmarc_aligned"] = record["alignment"]["dmarc"]
             row["disposition"] = record["policy_evaluated"]["disposition"]
             policy_override_reasons = list(map(
-                lambda r_: r_["type"],
+                lambda r_: r_["type"] or "none",
                 record["policy_evaluated"]
                 ["policy_override_reasons"]))
             policy_override_comments = list(map(
diff --git a/samples/aggregate/empty_reason.xml b/samples/aggregate/empty_reason.xml
new file mode 100644
index 0000000..dfccafc
--- /dev/null
+++ b/samples/aggregate/empty_reason.xml
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<feedback>
+  <version>1.0</version>
+  <report_metadata>
+    <org_name>example.org</org_name>
+    <email>noreply-dmarc-support@example.org</email>
+    <extra_contact_info>https://support.example.org/dmarc</extra_contact_info>
+    <report_id>20240125141224705995</report_id>
+    <date_range>
+      <begin>1706159544</begin>
+      <end>1706185733</end>
+    </date_range>
+  </report_metadata>
+  <policy_published>
+    <domain>example.com</domain>
+    <adkim>r</adkim>
+    <aspf>r</aspf>
+    <p>quarantine</p>
+    <sp>quarantine</sp>
+    <pct>100</pct>
+    <fo>1</fo>
+  </policy_published>
+  <record>
+    <row>
+      <source_ip>198.51.100.123</source_ip>
+      <count>2</count>
+      <policy_evaluated>
+        <disposition>none</disposition>
+        <dkim>pass</dkim>
+        <spf>fail</spf>
+        <reason>
+          <type></type>
+          <comment></comment>
+        </reason>
+      </policy_evaluated>
+    </row>
+    <identifiers>
+      <envelope_to>example.net</envelope_to>
+      <envelope_from>example.edu</envelope_from>
+      <header_from>example.com</header_from>
+    </identifiers>
+    <auth_results>
+      <dkim>
+        <domain>example.com</domain>
+        <selector>example</selector>
+        <result>pass</result>
+        <human_result>2048-bit key</human_result>
+      </dkim>
+      <spf>
+        <domain>example.edu</domain>
+        <scope>mfrom</scope>
+        <result>pass</result>
+      </spf>
+    </auth_results>
+  </record>
+</feedback>