From c7854e0906e028b32d718d8d4276f05cfc99d503 Mon Sep 17 00:00:00 2001 From: Sean Whalen <44679+seanthegeek@users.noreply.github.com> Date: Sat, 11 Jul 2026 18:14:34 -0400 Subject: [PATCH] Use assertGreater for the reverse-DNS-map fallback size check Addresses the github-code-quality bot finding on PR #816: assertTrue with a comparison inside can't show the operands on failure, while assertGreater reports both values and the failed relation. No change to test behavior. Co-Authored-By: Claude Fable 5 --- tests/test_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_utils.py b/tests/test_utils.py index bfde0261..dfcbcaea 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -1054,7 +1054,7 @@ class TestUtilsReverseDnsMap(unittest.TestCase): with self.assertLogs("parsedmarc.log", level="WARNING") as cm: parsedmarc.utils.load_reverse_dns_map(rdns_map) self.assertTrue(any("Not a valid CSV file" in message for message in cm.output)) - self.assertTrue(len(rdns_map) > 0) + self.assertGreater(len(rdns_map), 0) def testGetServiceUsesProvidedMap(self): """get_service_from_reverse_dns_base_domain consults a caller-