From fa60ab7f313d2b91d309eb549b3b6ccd56a291e9 Mon Sep 17 00:00:00 2001 From: stumpylog <797416+stumpylog@users.noreply.github.com> Date: Thu, 10 Sep 2026 14:51:30 -0700 Subject: [PATCH] Reduces the complexity of this loop now that we know it is hashable --- src/documents/serialisers.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py index a30ecf292..092b8bd02 100644 --- a/src/documents/serialisers.py +++ b/src/documents/serialisers.py @@ -952,15 +952,11 @@ class _CachingCustomFieldPrimaryKeyField(serializers.PrimaryKeyRelatedField): class CustomFieldInstanceListSerializer(serializers.ListSerializer): def to_internal_value(self, data: Any) -> list[Any]: if isinstance(data, list): - field_ids = [] - for item in data: - if not isinstance(item, dict) or "field" not in item: - continue - try: - hash(item["field"]) - except TypeError: - continue - field_ids.append(item["field"]) + field_ids = [ + item["field"] + for item in data + if isinstance(item, dict) and "field" in item + ] if field_ids: self.child.fields["field"].prefetch(field_ids) return super().to_internal_value(data)