From f971b0d166414c47af12fb41aec471468a966006 Mon Sep 17 00:00:00 2001 From: stumpylog <797416+stumpylog@users.noreply.github.com> Date: Mon, 3 Aug 2026 11:25:10 -0700 Subject: [PATCH] refactor: remove redundant deleted_at filter in permitted_object_ids SoftDeleteManager's own get_queryset() already excludes soft-deleted rows, so the extra deleted_at__isnull=True filter was dead code. Co-Authored-By: Claude Sonnet 5 --- src/documents/permissions.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/documents/permissions.py b/src/documents/permissions.py index c93c454b0..29c850a54 100644 --- a/src/documents/permissions.py +++ b/src/documents/permissions.py @@ -183,15 +183,7 @@ def permitted_object_ids( manager = ( model.global_objects if include_deleted and has_soft_delete else model.objects ) - if has_soft_delete: - base_qs = ( - manager.all() - if include_deleted - else manager.filter(deleted_at__isnull=True) - ) - else: - base_qs = manager.all() - base_qs = base_qs.only("id", "owner") + base_qs = manager.all().only("id", "owner") if user is None or not getattr(user, "is_authenticated", False): return base_qs.filter(owner__isnull=True).values_list("id", flat=True)