Chore: Add shared helpers for granting test permissions and use them (#14200)

src/documents/tests/test_api_objects.py

@@ -3,12 +3,10 @@ import json
 from unittest import mock
 
 from django.contrib.auth.models import Group
-from django.contrib.auth.models import Permission
 from django.contrib.auth.models import User
 from django.db import connection
 from django.test import override_settings
 from django.test.utils import CaptureQueriesContext
-from guardian.shortcuts import assign_perm
 from guardian.shortcuts import get_groups_with_perms
 from guardian.shortcuts import get_users_with_perms
 from rest_framework import status
@@ -23,6 +21,8 @@ from documents.models import StoragePath
 from documents.models import Tag
 from paperless_testing.dirs import DirectoriesMixin
 from paperless_testing.factories import UserFactory
+from paperless_testing.permissions import grant_global
+from paperless_testing.permissions import grant_object
 
 
 class TestApiObjects(DirectoriesMixin, APITestCase):
@@ -164,9 +164,7 @@ class TestApiObjects(DirectoriesMixin, APITestCase):
         )
 
         user = UserFactory(username="regular")
-        user.user_permissions.add(
-            Permission.objects.get(codename="view_correspondent"),
-        )
+        grant_global(user, "view_correspondent")
         self.client.force_authenticate(user=user)
 
         response = self.client.get("/api/correspondents/?last_correspondence=true")
@@ -458,9 +456,7 @@ class TestApiStoragePaths(DirectoriesMixin, APITestCase):
     def test_test_storage_path_requires_document_view_permission(self) -> None:
         owner = UserFactory(username="owner")
         unprivileged = UserFactory(username="unprivileged")
-        unprivileged.user_permissions.add(
-            Permission.objects.get(codename="view_document"),
-        )
+        grant_global(unprivileged, "view_document")
         document = Document.objects.create(
             mime_type="application/pdf",
             owner=owner,
@@ -490,7 +486,7 @@ class TestApiStoragePaths(DirectoriesMixin, APITestCase):
             title="Shared",
             checksum="123",
         )
-        assign_perm("view_document", viewer, document)
+        grant_object(viewer, document, "view_document")
 
         self.client.force_authenticate(user=viewer)
         response = self.client.post(
@@ -505,9 +501,7 @@ class TestApiStoragePaths(DirectoriesMixin, APITestCase):
         )
         self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
 
-        viewer.user_permissions.add(
-            Permission.objects.get(codename="view_document"),
-        )
+        grant_global(viewer, "view_document")
         viewer = User.objects.get(pk=viewer.pk)
         self.client.force_authenticate(user=viewer)
         response = self.client.post(
@@ -551,9 +545,7 @@ class TestApiStoragePaths(DirectoriesMixin, APITestCase):
             password="password",
             email="owner@example.com",
         )
-        owner.user_permissions.add(
-            Permission.objects.get(codename="view_document"),
-        )
+        grant_global(owner, "view_document")
         document = Document.objects.create(
             mime_type="application/pdf",
             owner=owner,
@@ -628,10 +620,8 @@ class TestApiStoragePaths(DirectoriesMixin, APITestCase):
             title="Document",
             checksum="123",
         )
-        assign_perm("view_document", viewer, document)
-        viewer.user_permissions.add(
-            Permission.objects.get(codename="view_document"),
-        )
+        grant_object(viewer, document, "view_document")
+        grant_global(viewer, "view_document")
 
         self.client.force_authenticate(user=viewer)
         response = self.client.post(
@@ -718,10 +708,8 @@ class TestApiStoragePaths(DirectoriesMixin, APITestCase):
             checksum="123",
         )
         document.tags.add(private_tag)
-        assign_perm("view_document", viewer, document)
-        viewer.user_permissions.add(
-            Permission.objects.get(codename="view_document"),
-        )
+        grant_object(viewer, document, "view_document")
+        grant_global(viewer, "view_document")
 
         self.client.force_authenticate(user=viewer)
         response = self.client.post(
@@ -774,10 +762,8 @@ class TestApiStoragePaths(DirectoriesMixin, APITestCase):
             field=custom_field,
             value_int=42,
         )
-        assign_perm("view_document", viewer, document)
-        viewer.user_permissions.add(
-            Permission.objects.get(codename="view_document"),
-        )
+        grant_object(viewer, document, "view_document")
+        grant_global(viewer, "view_document")
 
         self.client.force_authenticate(user=viewer)
         response = self.client.post(
@@ -1031,9 +1017,7 @@ class TestBulkEditObjects(APITestCase):
         THEN:
             - User is able to delete objects
         """
-        self.user1.user_permissions.add(
-            *Permission.objects.filter(codename="delete_tag"),
-        )
+        grant_global(self.user1, "delete_tag")
         self.user1.save()
         self.client.force_authenticate(user=self.user1)
 
@@ -1063,9 +1047,7 @@ class TestBulkEditObjects(APITestCase):
         self.t2.owner = User.objects.get(username="temp_admin")
         self.t2.save()
 
-        self.user1.user_permissions.add(
-            *Permission.objects.filter(codename="delete_tag"),
-        )
+        grant_global(self.user1, "delete_tag")
         self.user1.save()
         self.client.force_authenticate(user=self.user1)
 
@@ -1098,9 +1080,7 @@ class TestBulkEditObjects(APITestCase):
         self.t2.owner = User.objects.get(username="temp_admin")
         self.t2.save()
 
-        self.user1.user_permissions.add(
-            *Permission.objects.filter(codename="delete_tag"),
-        )
+        grant_global(self.user1, "delete_tag")
         self.user1.save()
         self.client.force_authenticate(user=self.user1)