From f482fd6c3cc2181d039621ba9a10205b89755dbf Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Wed, 18 Nov 2026 08:48:26 -0800 Subject: [PATCH] Do some cleanup of GH html --- .../release-notes-dialog.component.scss | 6 +++++ .../release-notes-dialog.component.spec.ts | 21 ++++++++++++++- .../release-notes-dialog.component.ts | 26 ++++++++++++++++++- 3 files changed, 51 insertions(+), 2 deletions(-) diff --git a/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.scss b/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.scss index 0d88c8f358..488bb0d0f7 100644 --- a/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.scss +++ b/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.scss @@ -22,6 +22,12 @@ } } + // Keep the link underline off code, where it hides underscores + // e.g. PAPERLESS_ALLOWED_HOSTS + a code { + display: inline-block; + } + .markdown-alert { border-left: 0.25rem solid var(--bs-info); padding: 0.5rem 1rem; diff --git a/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.spec.ts b/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.spec.ts index 71b5c168cb..011ab8938b 100644 --- a/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.spec.ts +++ b/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.spec.ts @@ -8,7 +8,10 @@ import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap' import { SETTINGS_KEYS } from 'src/app/data/ui-settings' import { SettingsService } from 'src/app/services/settings.service' import { environment } from 'src/environments/environment' -import { ReleaseNotesDialogComponent } from './release-notes-dialog.component' +import { + prepareReleaseHtml, + ReleaseNotesDialogComponent, +} from './release-notes-dialog.component' describe('ReleaseNotesDialogComponent', () => { let component: ReleaseNotesDialogComponent @@ -74,6 +77,22 @@ describe('ReleaseNotesDialogComponent', () => { ).toEqual('1 change') }) + it('should open release note links safely and drop svg icons', () => { + const html = prepareReleaseHtml( + '
Note