From ebbe659618330e28c2797ccca839054e9ea09dad Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Sun, 8 Mar 2026 21:16:56 -0700 Subject: [PATCH] Refact --- src/documents/serialisers.py | 6 +++--- src/documents/views.py | 6 ++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py index a42226267..80be8ae2b 100644 --- a/src/documents/serialisers.py +++ b/src/documents/serialisers.py @@ -1752,7 +1752,7 @@ class BulkEditSerializer( SourceModeValidationMixin, ): # TODO: remove this and related backwards compatibility code when API v9 is dropped - LEGACY_FILE_METHOD_ENDPOINTS = { + MOVED_DOCUMENT_ACTION_ENDPOINTS = { "rotate": "/api/documents/rotate/", "merge": "/api/documents/merge/", "edit_pdf": "/api/documents/edit_pdf/", @@ -1760,7 +1760,7 @@ class BulkEditSerializer( "split": "/api/documents/edit_pdf/", "delete_pages": "/api/documents/edit_pdf/", } - LEGACY_FILE_METHODS = tuple(LEGACY_FILE_METHOD_ENDPOINTS.keys()) + LEGACY_DOCUMENT_ACTION_METHODS = tuple(MOVED_DOCUMENT_ACTION_ENDPOINTS.keys()) method = serializers.ChoiceField( choices=[ @@ -1774,7 +1774,7 @@ class BulkEditSerializer( "delete", "reprocess", "set_permissions", - *LEGACY_FILE_METHODS, + *LEGACY_DOCUMENT_ACTION_METHODS, ], label="Method", write_only=True, diff --git a/src/documents/views.py b/src/documents/views.py index 55dacb473..29a2b7805 100644 --- a/src/documents/views.py +++ b/src/documents/views.py @@ -2283,8 +2283,10 @@ class BulkEditView(DocumentOperationPermissionMixin): request_method = request.data.get("method") api_version = int(request.version or settings.REST_FRAMEWORK["DEFAULT_VERSION"]) # TODO: remove this and related backwards compatibility code when API v9 is dropped - if request_method in BulkEditSerializer.LEGACY_FILE_METHODS: - endpoint = BulkEditSerializer.LEGACY_FILE_METHOD_ENDPOINTS[request_method] + if request_method in BulkEditSerializer.LEGACY_DOCUMENT_ACTION_METHODS: + endpoint = BulkEditSerializer.MOVED_DOCUMENT_ACTION_ENDPOINTS[ + request_method + ] logger.warning( "Deprecated bulk_edit method '%s' requested on API version %s. " "Use '%s' instead.",