From e81ac3799bc93a81ab4776913c86a860e855e9b4 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Wed, 18 Nov 2026 14:20:10 -0800 Subject: [PATCH] Allow enable/disable update checking (and release notes) in the dialog --- .../app-frame/app-frame.component.spec.ts | 13 ++++ .../app-frame/app-frame.component.ts | 3 + .../release-notes-dialog.component.html | 14 ++++- .../release-notes-dialog.component.spec.ts | 63 +++++++++++++++++-- .../release-notes-dialog.component.ts | 30 +++++++-- 5 files changed, 111 insertions(+), 12 deletions(-) diff --git a/src-ui/src/app/components/app-frame/app-frame.component.spec.ts b/src-ui/src/app/components/app-frame/app-frame.component.spec.ts index a2578b9d09..f0dd76eed3 100644 --- a/src-ui/src/app/components/app-frame/app-frame.component.spec.ts +++ b/src-ui/src/app/components/app-frame/app-frame.component.spec.ts @@ -741,6 +741,19 @@ describe('AppFrameComponent', () => { httpTestingController.expectNone(`${environment.apiBaseUrl}ui_settings/`) }) + it('should save update checking chosen in the release notes dialog', () => { + const setUpdateCheckingSpy = jest + .spyOn(component, 'setUpdateChecking') + .mockImplementation(() => {}) + const modalSpy = jest.spyOn(modalService, 'open') + component.showReleaseNotes() + + const dialog = modalSpy.mock.results[0].value + .componentInstance as ReleaseNotesDialogComponent + dialog.updateCheckingChosen.emit(true) + expect(setUpdateCheckingSpy).toHaveBeenCalledWith(true) + }) + it('should show new release dot instead of documentation in slim sidebar', () => { settingsService.set(SETTINGS_KEYS.SLIM_SIDEBAR, true) settingsService.set(SETTINGS_KEYS.VERSION, '3.5.1') diff --git a/src-ui/src/app/components/app-frame/app-frame.component.ts b/src-ui/src/app/components/app-frame/app-frame.component.ts index 2ee4464b01..20f078c363 100644 --- a/src-ui/src/app/components/app-frame/app-frame.component.ts +++ b/src-ui/src/app/components/app-frame/app-frame.component.ts @@ -559,6 +559,9 @@ export class AppFrameComponent scrollable: true, }) modal.componentInstance.load(since) + modal.componentInstance.updateCheckingChosen.subscribe((enable: boolean) => + this.setUpdateChecking(enable) + ) if (since) { this.settingsService .markReleasesSeen() diff --git a/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.html b/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.html index 1dce18f94e..6c4f291869 100644 --- a/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.html +++ b/src-ui/src/app/components/common/release-notes-dialog/release-notes-dialog.component.html @@ -22,9 +22,17 @@