From e1bd11d0e40f3af9258843cff26b782dd943e7c0 Mon Sep 17 00:00:00 2001 From: Trenton H <797416+stumpylog@users.noreply.github.com> Date: Mon, 16 Nov 2026 07:19:12 -0800 Subject: [PATCH] Chore: remove unused Tag.parent_pk It was an alias of tn_parent_id used only by two test asserts, which now use tn_parent_id directly. --- src/documents/models.py | 4 ---- src/documents/tests/test_tag_hierarchy.py | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/documents/models.py b/src/documents/models.py index 12444a8de5..1045a20825 100644 --- a/src/documents/models.py +++ b/src/documents/models.py @@ -138,10 +138,6 @@ class Tag(MatchingModel): return TagHierarchy(cls.objects.values_list("pk", "tn_parent_id")) - @property - def parent_pk(self) -> int | None: - return self.tn_parent_id - def get_parent(self) -> "Tag | None": return self.tn_parent diff --git a/src/documents/tests/test_tag_hierarchy.py b/src/documents/tests/test_tag_hierarchy.py index b7416c1424..1275551c08 100644 --- a/src/documents/tests/test_tag_hierarchy.py +++ b/src/documents/tests/test_tag_hierarchy.py @@ -362,7 +362,7 @@ class TestTagHierarchy(DirectoriesMixin, APITestCase): x = Tag.objects.create(name="X2") y = Tag.objects.create(name="Y2", tn_parent=x) - assert y.parent_pk == x.pk + assert y.tn_parent_id == x.pk # Moving X under D would make deepest node Y exceed depth 5 -> reject resp_fail = self.client.patch( @@ -383,7 +383,7 @@ class TestTagHierarchy(DirectoriesMixin, APITestCase): ) assert resp_ok.status_code in (200, 202) x.refresh_from_db() - assert x.parent_pk == c.id + assert x.tn_parent_id == c.id def test_is_root_filter_returns_only_root_tags(self) -> None: other_root = Tag.objects.create(name="Other parent")