amorfo77/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2026-08-31 06:57:16 +00:00
Code Issues Projects Releases Wiki Activity

Fix: correct sharelink bundle + document link permissions display bugs (#13827)

Browse Source
This commit is contained in:
shamoon
2026-08-27 17:20:46 -07:00
committed by GitHub
parent 05917a04aa
commit e1aa9997d7
6 changed files with 102 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src-ui/src/app/components/common/input/document-link/document-link.component.html
+2 -2
View File
@@ -47,8 +47,8 @@
<i-bs width="0.9em" height="0.9em" name="file-text" class="me-1"></i-bs><span>{{document.title}}</span>
</a>
} @else {
<span class="badge bg-light text-muted" (click)="unselect(document)" (mousedown)="$event.stopImmediatePropagation()" type="button" title="Remove link" i18n-title>
<i-bs width="0.9em" height="0.9em" name="exclamation-triangle-fill" class="me-1"></i-bs><span i18n>Not found</span>
<span class="badge bg-light text-muted">
<i-bs width="0.9em" height="0.9em" name="exclamation-triangle-fill" class="me-1"></i-bs><span i18n>Unavailable</span>
</span>
}
</div>
src-ui/src/app/components/common/input/document-link/document-link.component.spec.ts
+26
View File
@@ -151,6 +151,23 @@ describe('DocumentLinkComponent', () => {
expect(component.selectedDocuments).toEqual([])
})
it('should preserve and neutrally label unavailable document IDs', async () => {
jest.spyOn(documentService, 'getFew').mockReturnValue(
of({
count: 0,
all: [],
results: [],
})
)
component.writeValue([99])
await fixture.whenStable()
expect(component.selectedDocuments).toEqual([{ id: 99 }])
expect(fixture.nativeElement.textContent).toContain('Unavailable')
expect(fixture.nativeElement.textContent).not.toContain('Not found')
})
it('should support unselect', () => {
const getSpy = jest.spyOn(documentService, 'getFew')
getSpy.mockImplementation((ids) => {
@@ -167,6 +184,15 @@ describe('DocumentLinkComponent', () => {
expect(component.selectedDocuments).toEqual([documents[1]])
})
it('should not unselect documents when disabled', () => {
component.disabled = true
component.selectedDocuments = [documents[0]]
component.unselect(documents[0])
expect(component.selectedDocuments).toEqual([documents[0]])
})
it('should use correct compare, trackBy functions', () => {
expect(component.compareDocuments(documents[0], { id: 1 })).toBeTruthy()
expect(component.compareDocuments(documents[0], { id: 2 })).toBeFalsy()
src-ui/src/app/components/common/input/document-link/document-link.component.ts
+3 -1
View File
@@ -101,7 +101,7 @@ export class DocumentLinkComponent
.subscribe((documentResults) => {
this.loading.set(false)
this.selectedDocuments = documentIDs.map(
(id) => documentResults.results.find((d) => d.id === id) ?? {}
(id) => documentResults.results.find((d) => d.id === id) ?? { id }
)
super.writeValue(documentIDs)
})
@@ -142,6 +142,8 @@ export class DocumentLinkComponent
}
unselect(document: Document): void {
if (this.disabled) return
this.selectedDocuments = this.selectedDocuments.filter(
(d) => d && d.id !== document.id
)