From be45149677928e39c5aea8be9a5556454b52a43b Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Sat, 5 Sep 2026 16:53:12 -0700
Subject: [PATCH] Fix: change share link bundle dialog button to close after
create, don't toast on copied (#14002)
---
.../share-link-bundle-dialog.component.html | 3 ++-
.../share-link-bundle-dialog.component.spec.ts | 2 +-
.../share-link-bundle-dialog.component.ts | 4 +---
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html
index ee93c0fff..748463685 100644
--- a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html
+++ b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html
@@ -64,7 +64,7 @@
Slug
{{ createdBundle.slug }}
Link
-
+
@@ -82,6 +82,7 @@
Copy link
+ Copied!
Documents
{{ createdBundle.document_count }}
diff --git a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.spec.ts b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.spec.ts
index 3b7dae922..7d4013524 100644
--- a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.spec.ts
+++ b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.spec.ts
@@ -115,7 +115,7 @@ describe('ShareLinkBundleDialogComponent', () => {
expect(copySpy).toHaveBeenCalledWith(component.getShareUrl(bundle))
expect(component.copied()).toBe(true)
- expect(toastService.showInfo).toHaveBeenCalled()
+ expect(toastService.showInfo).not.toHaveBeenCalled()
jest.advanceTimersByTime(3000)
expect(component.copied()).toBe(false)
diff --git a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts
index 7c3bf5fd9..1a80bc75f 100644
--- a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts
+++ b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts
@@ -17,7 +17,6 @@ import {
} from 'src/app/data/share-link-bundle'
import { DocumentTitlePipe } from 'src/app/pipes/document-title.pipe'
import { FileSizePipe } from 'src/app/pipes/file-size.pipe'
-import { ToastService } from 'src/app/services/toast.service'
import { environment } from 'src/environments/environment'
import { ConfirmDialogComponent } from '../confirm-dialog/confirm-dialog.component'
@@ -36,7 +35,6 @@ import { ConfirmDialogComponent } from '../confirm-dialog/confirm-dialog.compone
export class ShareLinkBundleDialogComponent extends ConfirmDialogComponent {
private readonly formBuilder = inject(FormBuilder)
private readonly clipboard = inject(Clipboard)
- private readonly toastService = inject(ToastService)
readonly documents = signal([])
readonly selectionCount = signal(0)
@@ -80,6 +78,7 @@ export class ShareLinkBundleDialogComponent extends ConfirmDialogComponent {
}
this.buttonsEnabled.set(false)
super.confirm()
+ this.cancelBtnCaption = $localize`Close`
}
getShareUrl(bundle: ShareLinkBundleSummary): string {
@@ -93,7 +92,6 @@ export class ShareLinkBundleDialogComponent extends ConfirmDialogComponent {
const success = this.clipboard.copy(this.getShareUrl(bundle))
if (success) {
this.copied.set(true)
- this.toastService.showInfo($localize`Share link copied to clipboard.`)
setTimeout(() => {
this.copied.set(false)
}, 3000)