More direct signals conversion

This commit is contained in:
shamoon
2026-07-08 12:58:40 -07:00
parent 0ed4f3cba6
commit b7836d7cfd
11 changed files with 45 additions and 87 deletions
@@ -15,7 +15,7 @@
</li>
}
@for (field of fields; track field) {
@for (field of fields(); track field) {
<li class="list-group-item">
<div class="row fade" [class.show]="show">
<div class="col d-flex align-items-center"><button class="btn btn-link p-0 text-start" type="button" (click)="editField(field)" [disabled]="!permissionsService.currentUserCan(PermissionAction.Change, PermissionType.CustomField)">{{field.name}}</button></div>
@@ -64,7 +64,7 @@
</div>
</li>
}
@if (!loading && fields.length === 0) {
@if (!loading && fields().length === 0) {
<li class="list-group-item" i18n>No fields defined.</li>
}
</ul>
@@ -51,15 +51,7 @@ export class CustomFieldsComponent
private readonly documentService = inject(DocumentService)
private readonly savedViewService = inject(SavedViewService)
private fieldsSignal = signal<CustomField[]>([])
public get fields(): CustomField[] {
return this.fieldsSignal()
}
public set fields(fields: CustomField[]) {
this.fieldsSignal.set(fields)
}
readonly fields = signal<CustomField[]>([])
ngOnInit() {
this.reload()
@@ -72,7 +64,7 @@ export class CustomFieldsComponent
.pipe(
takeUntil(this.unsubscribeNotifier),
tap((r) => {
this.fields = r.results
this.fields.set(r.results)
})
)
.subscribe(() => {
@@ -22,14 +22,14 @@
</div>
</li>
@if (loading && workflows.length === 0) {
@if (loading && workflows().length === 0) {
<li class="list-group-item">
<div class="spinner-border spinner-border-sm me-2" role="status"></div>
<ng-container i18n>Loading...</ng-container>
</li>
}
@for (workflow of workflows; track workflow.id) {
@for (workflow of workflows(); track workflow.id) {
<li class="list-group-item">
<div class="row fade" [class.show]="show">
<div class="col d-flex align-items-center"><button class="btn btn-link p-0 text-start" type="button" (click)="editWorkflow(workflow)" [disabled]="!permissionsService.currentUserCan(PermissionAction.Change, PermissionType.Workflow)">{{workflow.name}}</button></div>
@@ -76,7 +76,7 @@
</div>
</li>
}
@if (!loading && workflows.length === 0) {
@if (!loading && workflows().length === 0) {
<li class="list-group-item" [class.show]="show" i18n>No workflows defined.</li>
}
</ul>
@@ -39,15 +39,7 @@ export class WorkflowsComponent
private modalService = inject(NgbModal)
private toastService = inject(ToastService)
private workflowsSignal = signal<Workflow[]>([])
public get workflows(): Workflow[] {
return this.workflowsSignal()
}
public set workflows(workflows: Workflow[]) {
this.workflowsSignal.set(workflows)
}
readonly workflows = signal<Workflow[]>([])
ngOnInit() {
this.reload()
@@ -59,7 +51,7 @@ export class WorkflowsComponent
.listAll()
.pipe(
takeUntil(this.unsubscribeNotifier),
tap((r) => (this.workflows = r.results))
tap((r) => this.workflows.set(r.results))
)
.subscribe(() => {
this.show = true