From 9cc322455f4e34bec283c60d051c4394a2606738 Mon Sep 17 00:00:00 2001 From: stumpylog <797416+stumpylog@users.noreply.github.com> Date: Fri, 20 Nov 2026 13:07:18 -0800 Subject: [PATCH] Fix: keep exception text out of zone template validation errors CodeQL flags py/stack-trace-exposure. Log the detail and return a generic message, as MatchRuleSerializer does. --- src/documents/serialisers.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py index 9a22554ec0..d1abcbe7de 100644 --- a/src/documents/serialisers.py +++ b/src/documents/serialisers.py @@ -3859,7 +3859,10 @@ class OcrTemplateZoneSerializer(serializers.ModelSerializer[OcrTemplateZone]): try: round_trip = datetime.strptime(sample.strftime(value), value) except ValueError as e: - raise serializers.ValidationError(f"Invalid date format: {e}") from e + logger.debug(f"Invalid zone date format {value!r}: {e!s}") + raise serializers.ValidationError( + "Invalid date format, see log for details.", + ) from e if round_trip.date() != sample.date(): raise serializers.ValidationError( "The date format must read back a full date (day, month and year).", @@ -3871,8 +3874,9 @@ class OcrTemplateZoneSerializer(serializers.ModelSerializer[OcrTemplateZone]): try: validate_regex_pattern(value) except ValueError as e: + logger.debug(f"Invalid regular expression: {e!s}") raise serializers.ValidationError( - f"Invalid regular expression: {e}", + "Invalid regular expression, see log for details.", ) from e return value