From 66f5111dc164ff3ee540c8634fe92dac4f9c56c9 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Thu, 16 Jul 2026 10:42:00 -0700 Subject: [PATCH] Chore: some frontend sonar fixes --- .../app/components/admin/logs/logs.component.html | 5 +++-- .../src/app/components/admin/logs/logs.component.ts | 4 +--- .../admin/settings/settings.component.html | 12 ++++++------ .../admin/settings/settings.component.spec.ts | 12 ++++++------ .../app/components/admin/tasks/tasks.component.html | 7 ++++--- .../src/app/components/chat/chat/chat.component.html | 2 ++ .../app/components/chat/chat/chat.component.spec.ts | 4 ++-- .../workflow-edit-dialog.component.html | 2 +- .../workflow-edit-dialog.component.spec.ts | 10 +++++----- .../workflow-edit-dialog.component.ts | 2 +- .../components/common/input/tags/tags.component.ts | 4 ++-- .../common/page-header/page-header.component.ts | 2 +- .../share-link-bundle-dialog.component.html | 3 ++- .../document-detail.component.spec.ts | 2 +- .../document-history/document-history.component.html | 2 +- .../document-history/document-history.component.ts | 12 ++++++------ .../document-version-dropdown.component.html | 7 ++++++- .../filter-editor/filter-editor.component.spec.ts | 2 +- .../management-list/management-list.component.html | 8 ++++---- .../tag-list/tag-list.component.spec.ts | 4 ++-- .../processed-mail-dialog.component.html | 2 +- .../processed-mail-dialog.component.scss | 2 +- 22 files changed, 59 insertions(+), 51 deletions(-) diff --git a/src-ui/src/app/components/admin/logs/logs.component.html b/src-ui/src/app/components/admin/logs/logs.component.html index 2099429b3..0596ec60d 100644 --- a/src-ui/src/app/components/admin/logs/logs.component.html +++ b/src-ui/src/app/components/admin/logs/logs.component.html @@ -5,8 +5,9 @@ i18n-info>
- Show + lines
- +
diff --git a/src-ui/src/app/components/admin/logs/logs.component.ts b/src-ui/src/app/components/admin/logs/logs.component.ts index 48c70218c..95c2dc11c 100644 --- a/src-ui/src/app/components/admin/logs/logs.component.ts +++ b/src-ui/src/app/components/admin/logs/logs.component.ts @@ -100,9 +100,7 @@ export class LogsComponent parsed.some((log, idx) => { const current = this.logs()[idx] return ( - !current || - current.message !== log.message || - current.level !== log.level + current?.message !== log.message || current?.level !== log.level ) }) if (hasChanges) { diff --git a/src-ui/src/app/components/admin/settings/settings.component.html b/src-ui/src/app/components/admin/settings/settings.component.html index 80d7d1524..ed1d2cf3f 100644 --- a/src-ui/src/app/components/admin/settings/settings.component.html +++ b/src-ui/src/app/components/admin/settings/settings.component.html @@ -150,10 +150,10 @@
- Full search links to +
- @@ -199,10 +199,10 @@
Documents
- Items per page +
- @@ -274,10 +274,10 @@
PDF Editor
- Default editing mode +
- diff --git a/src-ui/src/app/components/admin/settings/settings.component.spec.ts b/src-ui/src/app/components/admin/settings/settings.component.spec.ts index 540e7b5c7..3fe69f743 100644 --- a/src-ui/src/app/components/admin/settings/settings.component.spec.ts +++ b/src-ui/src/app/components/admin/settings/settings.component.spec.ts @@ -399,17 +399,17 @@ describe('SettingsComponent', () => { completeSetup() const field = 'storage_path' expect( - component.settingsForm.get('documentDetailsHiddenFields').value.length - ).toEqual(0) + component.settingsForm.get('documentDetailsHiddenFields').value + ).toHaveLength(0) component.toggleDocumentDetailField(field, false) expect( - component.settingsForm.get('documentDetailsHiddenFields').value.length - ).toEqual(1) + component.settingsForm.get('documentDetailsHiddenFields').value + ).toHaveLength(1) expect(component.isDocumentDetailFieldShown(field)).toBeFalsy() component.toggleDocumentDetailField(field, true) expect( - component.settingsForm.get('documentDetailsHiddenFields').value.length - ).toEqual(0) + component.settingsForm.get('documentDetailsHiddenFields').value + ).toHaveLength(0) expect(component.isDocumentDetailFieldShown(field)).toBeTruthy() }) }) diff --git a/src-ui/src/app/components/admin/tasks/tasks.component.html b/src-ui/src/app/components/admin/tasks/tasks.component.html index 05a224a0a..7fae03a7f 100644 --- a/src-ui/src/app/components/admin/tasks/tasks.component.html +++ b/src-ui/src/app/components/admin/tasks/tasks.component.html @@ -15,7 +15,7 @@ Dismiss all
- +
@@ -93,7 +93,8 @@ } - Search tasks +
@@ -211,7 +212,7 @@ - +
+
{ component.input = 'Hello' component.sendMessage() - expect(component.messages.length).toBe(2) + expect(component.messages).toHaveLength(2) expect(component.messages[0].content).toBe('Hello') expect(component.loading).toBe(true) @@ -158,7 +158,7 @@ describe('ChatComponent', () => { const message = { content: '', role: 'assistant', isStreaming: true } component.enqueueTypewriter(null, message as any) // coverage for null component.enqueueTypewriter('Hello', message as any) - expect(component['typewriterBuffer'].length).toBe(4) + expect(component['typewriterBuffer']).toHaveLength(4) }) it('should scroll to bottom after sending a message', () => { diff --git a/src-ui/src/app/components/common/edit-dialog/workflow-edit-dialog/workflow-edit-dialog.component.html b/src-ui/src/app/components/common/edit-dialog/workflow-edit-dialog/workflow-edit-dialog.component.html index 9dce30891..0e3329ea3 100644 --- a/src-ui/src/app/components/common/edit-dialog/workflow-edit-dialog/workflow-edit-dialog.component.html +++ b/src-ui/src/app/components/common/edit-dialog/workflow-edit-dialog/workflow-edit-dialog.component.html @@ -180,7 +180,7 @@
- + Advanced Filters