From 45a0da45401dd6156ad70a38c965e719320eff14 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Wed, 8 Jul 2026 16:53:34 -0700 Subject: [PATCH] Missed these --- .../storage-path-edit-dialog.component.ts | 6 +++--- .../email-document-dialog.component.ts | 8 ++++---- .../permissions-filter-dropdown.component.ts | 2 +- .../profile-edit-dialog.component.ts | 18 +++++++++--------- .../share-link-bundle-dialog.component.ts | 2 +- ...hare-link-bundle-manage-dialog.component.ts | 10 +++++----- .../dashboard/dashboard.component.ts | 4 ++-- 7 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src-ui/src/app/components/common/edit-dialog/storage-path-edit-dialog/storage-path-edit-dialog.component.ts b/src-ui/src/app/components/common/edit-dialog/storage-path-edit-dialog/storage-path-edit-dialog.component.ts index 1ccf6a47a..f0d17a965 100644 --- a/src-ui/src/app/components/common/edit-dialog/storage-path-edit-dialog/storage-path-edit-dialog.component.ts +++ b/src-ui/src/app/components/common/edit-dialog/storage-path-edit-dialog/storage-path-edit-dialog.component.ts @@ -71,7 +71,7 @@ export class StoragePathEditDialogComponent constructor() { super() - this.loading = false + this.loading.set(false) this.service = inject(StoragePathService) this.userService = inject(UserService) this.settingsService = inject(SettingsService) @@ -138,7 +138,7 @@ export class StoragePathEditDialogComponent this.documentsInput$.pipe( distinctUntilChanged(), takeUntil(this.unsubscribeNotifier), - tap(() => (this.loading = true)), + tap(() => this.loading.set(true)), switchMap((title) => this.documentsService .listFiltered( @@ -152,7 +152,7 @@ export class StoragePathEditDialogComponent .pipe( map((result) => result.results), catchError(() => of([])), // empty on error - tap(() => (this.loading = false)) + tap(() => this.loading.set(false)) ) ) ) diff --git a/src-ui/src/app/components/common/email-document-dialog/email-document-dialog.component.ts b/src-ui/src/app/components/common/email-document-dialog/email-document-dialog.component.ts index cb42d9921..71d25d0f5 100644 --- a/src-ui/src/app/components/common/email-document-dialog/email-document-dialog.component.ts +++ b/src-ui/src/app/components/common/email-document-dialog/email-document-dialog.component.ts @@ -54,11 +54,11 @@ export class EmailDocumentDialogComponent extends LoadingComponentWithPermission constructor() { super() - this.loading = false + this.loading.set(false) } public emailDocuments() { - this.loading = true + this.loading.set(true) this.documentService .emailDocuments( this.documentIds, @@ -69,7 +69,7 @@ export class EmailDocumentDialogComponent extends LoadingComponentWithPermission ) .subscribe({ next: () => { - this.loading = false + this.loading.set(false) this.emailAddress = '' this.emailSubject = '' this.emailMessage = '' @@ -77,7 +77,7 @@ export class EmailDocumentDialogComponent extends LoadingComponentWithPermission this.toastService.showInfo($localize`Email sent`) }, error: (e) => { - this.loading = false + this.loading.set(false) const errorMessage = this.documentIds.length > 1 ? $localize`Error emailing documents` diff --git a/src-ui/src/app/components/common/permissions-filter-dropdown/permissions-filter-dropdown.component.ts b/src-ui/src/app/components/common/permissions-filter-dropdown/permissions-filter-dropdown.component.ts index 15a900eab..8476ed0f3 100644 --- a/src-ui/src/app/components/common/permissions-filter-dropdown/permissions-filter-dropdown.component.ts +++ b/src-ui/src/app/components/common/permissions-filter-dropdown/permissions-filter-dropdown.component.ts @@ -132,7 +132,7 @@ export class PermissionsFilterDropdownComponent extends ComponentWithPermissions } else if ( this.selectionModel.ownerFilter === OwnerFilterType.SHARED_BY_ME ) { - this.selectionModel.userID = this.settingsService.currentUser.id + this.selectionModel.userID = this.settingsService.currentUser()?.id this.selectionModel.includeUsers = [] this.selectionModel.excludeUsers = [] this.selectionModel.hideUnowned = false diff --git a/src-ui/src/app/components/common/profile-edit-dialog/profile-edit-dialog.component.ts b/src-ui/src/app/components/common/profile-edit-dialog/profile-edit-dialog.component.ts index 7f22652a1..f8bd68cbc 100644 --- a/src-ui/src/app/components/common/profile-edit-dialog/profile-edit-dialog.component.ts +++ b/src-ui/src/app/components/common/profile-edit-dialog/profile-edit-dialog.component.ts @@ -125,7 +125,7 @@ export class ProfileEditDialogComponent } get saveDisabled(): boolean { - return this.error?.password_confirm || this.error?.email_confirm + return this.error()?.password_confirm || this.error()?.email_confirm } onEmailKeyUp(event: KeyboardEvent): void { @@ -199,8 +199,8 @@ export class ProfileEditDialogComponent this.newPassword && this.currentPassword !== this.newPassword const profile = Object.assign({}, this.form.value) delete profile.totp_code - this.error = null - this.networkActive = true + this.error.set(null) + this.networkActive.set(true) this.profileService .update(profile) .pipe(takeUntil(this.unsubscribeNotifier)) @@ -221,8 +221,8 @@ export class ProfileEditDialogComponent }, error: (error) => { this.toastService.showError($localize`Error saving profile`, error) - this.error = error?.error - this.networkActive = false + this.error.set(error?.error) + this.networkActive.set(false) }, }) } @@ -247,9 +247,9 @@ export class ProfileEditDialogComponent copyAuthToken(): void { this.clipboard.copy(this.form.get('auth_token').value) - this.copied = true + this.copied.set(true) setTimeout(() => { - this.copied = false + this.copied.set(false) }, 3000) } @@ -341,9 +341,9 @@ export class ProfileEditDialogComponent public copyRecoveryCodes(): void { this.clipboard.copy(this.recoveryCodes.join('\n')) - this.codesCopied = true + this.codesCopied.set(true) setTimeout(() => { - this.codesCopied = false + this.codesCopied.set(false) }, 3000) } } diff --git a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts index d92aad81d..497bc757c 100644 --- a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts +++ b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts @@ -73,7 +73,7 @@ export class ShareLinkBundleDialogComponent extends ConfirmDialogComponent { constructor() { super() - this.loading = false + this.loading.set(false) this.title = $localize`Create share link bundle` this.btnCaption = $localize`Create link` } diff --git a/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts b/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts index 6603ee64c..7ee825d6f 100644 --- a/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts +++ b/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts @@ -78,13 +78,13 @@ export class ShareLinkBundleManageDialogComponent .pipe( switchMap((silent) => { if (!silent) { - this.loading = true + this.loading.set(true) } this.error = null return this.shareLinkBundleService.listAllBundles().pipe( catchError((error) => { if (!silent) { - this.loading = false + this.loading.set(false) } this.error = $localize`Failed to load share link bundles.` this.toastService.showError( @@ -102,7 +102,7 @@ export class ShareLinkBundleManageDialogComponent this.bundles = results this.copiedSlug = null } - this.loading = false + this.loading.set(false) }) this.triggerRefresh(false) @@ -138,14 +138,14 @@ export class ShareLinkBundleManageDialogComponent delete(bundle: ShareLinkBundleSummary): void { this.error = null - this.loading = true + this.loading.set(true) this.shareLinkBundleService.delete(bundle).subscribe({ next: () => { this.toastService.showInfo($localize`Share link bundle deleted.`) this.triggerRefresh(false) }, error: (e) => { - this.loading = false + this.loading.set(false) this.toastService.showError( $localize`Error deleting share link bundle.`, e diff --git a/src-ui/src/app/components/dashboard/dashboard.component.ts b/src-ui/src/app/components/dashboard/dashboard.component.ts index 46e0d7e3d..35c5bb093 100644 --- a/src-ui/src/app/components/dashboard/dashboard.component.ts +++ b/src-ui/src/app/components/dashboard/dashboard.component.ts @@ -73,11 +73,11 @@ export class DashboardComponent extends ComponentWithPermissions { } onDragStart(event: CdkDragStart) { - this.settingsService.globalDropzoneEnabled = false + this.settingsService.globalDropzoneEnabled.set(false) } onDragEnd(event: CdkDragEnd) { - this.settingsService.globalDropzoneEnabled = true + this.settingsService.globalDropzoneEnabled.set(true) } onDrop(event: CdkDragDrop) {