From 3f9355793495ede54b4b98bc74ba5f5720bb6609 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Wed, 22 Jul 2026 10:06:41 -0700 Subject: [PATCH] Fix (beta): prevent pdfjs offsetParent warning (#13197) --- .../common/pdf-viewer/pdf-viewer.component.spec.ts | 12 ++++++++++++ .../common/pdf-viewer/pdf-viewer.component.ts | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.spec.ts b/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.spec.ts index a8c973205..3b6add68c 100644 --- a/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.spec.ts +++ b/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.spec.ts @@ -138,6 +138,18 @@ describe('PngxPdfViewerComponent', () => { expect(applyScaleSpy).toHaveBeenCalled() }) + it('does not reset the viewer when it is already on the requested page', async () => { + await initComponent() + + const viewer = (component as any).pdfViewer as PDFViewer + const currentPageSpy = jest.spyOn(viewer, 'currentPageNumber', 'set') + component.page = viewer.currentPageNumber + + ;(component as any).applyViewerState() + + expect(currentPageSpy).not.toHaveBeenCalled() + }) + it('dispatches find when search query changes after render', async () => { await initComponent() diff --git a/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.ts b/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.ts index dba57ef2d..c86294b9d 100644 --- a/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.ts +++ b/src-ui/src/app/components/common/pdf-viewer/pdf-viewer.component.ts @@ -256,7 +256,9 @@ export class PngxPdfViewerComponent Math.max(Math.trunc(this.page), 1), this.pdfViewer.pagesCount ) - this.pdfViewer.currentPageNumber = nextPage + if (nextPage !== this.pdfViewer.currentPageNumber) { + this.pdfViewer.currentPageNumber = nextPage + } } if (this.page === this.lastViewerPage) { this.lastViewerPage = undefined